cpu: convert 'cpu' and 'machinecheck' sysdev_class to a regular subsystem

This moves the 'cpu sysdev_class' over to a regular 'cpu' subsystem
and converts the devices to regular devices. The sysdev drivers are
implemented as subsystem interfaces now.

After all sysdev classes are ported to regular driver core entities, the
sysdev implementation will be entirely removed from the kernel.

Userspace relies on events and generic sysfs subsystem infrastructure
from sysdev devices, which are made available with this conversion.

Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@amd64.org>
Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Cc: Len Brown <lenb@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2 files changed, 103 insertions, 102 deletions

diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c b/arch/powerpc/platforms/cell/cbe_thermal.c
index 4d4c8c169124..94560db788bf 100644
--- a/arch/powerpc/platforms/cell/cbe_thermal.c
+++ b/arch/powerpc/platforms/cell/cbe_thermal.c
@@ -46,7 +46,7 @@
  */
 
 #include <linux/module.h>
-#include <linux/sysdev.h>
+#include <linux/device.h>
 #include <linux/kernel.h>
 #include <linux/cpu.h>
 #include <asm/spu.h>
@@ -59,8 +59,8 @@
 #define TEMP_MIN 65
 #define TEMP_MAX 125
 
-#define SYSDEV_PREFIX_ATTR(_prefix,_name,_mode)                 \
-struct sysdev_attribute attr_ ## _prefix ## _ ## _name = {      \
+#define DEVICE_PREFIX_ATTR(_prefix,_name,_mode)                 \
+struct device_attribute attr_ ## _prefix ## _ ## _name = {      \
         .attr = { .name = __stringify(_name), .mode = _mode },  \
         .show   = _prefix ## _show_ ## _name,                   \
         .store  = _prefix ## _store_ ## _name,                  \
@@ -76,36 +76,36 @@ static inline u8 temp_to_reg(u8 temp)
         return ((temp - TEMP_MIN) >> 1) & 0x3f;
 }
 
-static struct cbe_pmd_regs __iomem *get_pmd_regs(struct sys_device *sysdev)
+static struct cbe_pmd_regs __iomem *get_pmd_regs(struct device *dev)
 {
         struct spu *spu;
 
-        spu = container_of(sysdev, struct spu, sysdev);
+        spu = container_of(dev, struct spu, dev);
 
         return cbe_get_pmd_regs(spu_devnode(spu));
 }
 
 /* returns the value for a given spu in a given register */
-static u8 spu_read_register_value(struct sys_device *sysdev, union spe_reg __iomem *reg)
+static u8 spu_read_register_value(struct device *dev, union spe_reg __iomem *reg)
 {
         union spe_reg value;
         struct spu *spu;
 
-        spu = container_of(sysdev, struct spu, sysdev);
+        spu = container_of(dev, struct spu, dev);
         value.val = in_be64(&reg->val);
 
         return value.spe[spu->spe_id];
 }
 
-static ssize_t spu_show_temp(struct sys_device *sysdev, struct sysdev_attribute *attr,
+static ssize_t spu_show_temp(struct device *dev, struct device_attribute *attr,
                         char *buf)
 {
         u8 value;
         struct cbe_pmd_regs __iomem *pmd_regs;
 
-        pmd_regs = get_pmd_regs(sysdev);
+        pmd_regs = get_pmd_regs(dev);
 
-        value = spu_read_register_value(sysdev, &pmd_regs->ts_ctsr1);
+        value = spu_read_register_value(dev, &pmd_regs->ts_ctsr1);
 
         return sprintf(buf, "%d\n", reg_to_temp(value));
 }
@@ -147,48 +147,48 @@ static ssize_t store_throttle(struct cbe_pmd_regs __iomem *pmd_regs, const char
         return size;
 }
 
-static ssize_t spu_show_throttle_end(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t spu_show_throttle_end(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(get_pmd_regs(sysdev), buf, 0);
+        return show_throttle(get_pmd_regs(dev), buf, 0);
 }
 
-static ssize_t spu_show_throttle_begin(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t spu_show_throttle_begin(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(get_pmd_regs(sysdev), buf, 8);
+        return show_throttle(get_pmd_regs(dev), buf, 8);
 }
 
-static ssize_t spu_show_throttle_full_stop(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t spu_show_throttle_full_stop(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(get_pmd_regs(sysdev), buf, 16);
+        return show_throttle(get_pmd_regs(dev), buf, 16);
 }
 
-static ssize_t spu_store_throttle_end(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t spu_store_throttle_end(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(get_pmd_regs(sysdev), buf, size, 0);
+        return store_throttle(get_pmd_regs(dev), buf, size, 0);
 }
 
-static ssize_t spu_store_throttle_begin(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t spu_store_throttle_begin(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(get_pmd_regs(sysdev), buf, size, 8);
+        return store_throttle(get_pmd_regs(dev), buf, size, 8);
 }
 
-static ssize_t spu_store_throttle_full_stop(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t spu_store_throttle_full_stop(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(get_pmd_regs(sysdev), buf, size, 16);
+        return store_throttle(get_pmd_regs(dev), buf, size, 16);
 }
 
-static ssize_t ppe_show_temp(struct sys_device *sysdev, char *buf, int pos)
+static ssize_t ppe_show_temp(struct device *dev, char *buf, int pos)
 {
         struct cbe_pmd_regs __iomem *pmd_regs;
         u64 value;
 
-        pmd_regs = cbe_get_cpu_pmd_regs(sysdev->id);
+        pmd_regs = cbe_get_cpu_pmd_regs(dev->id);
         value = in_be64(&pmd_regs->ts_ctsr2);
 
         value = (value >> pos) & 0x3f;
@@ -199,64 +199,64 @@ static ssize_t ppe_show_temp(struct sys_device *sysdev, char *buf, int pos)
 
 /* shows the temperature of the DTS on the PPE,
  * located near the linear thermal sensor */
-static ssize_t ppe_show_temp0(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t ppe_show_temp0(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return ppe_show_temp(sysdev, buf, 32);
+        return ppe_show_temp(dev, buf, 32);
 }
 
 /* shows the temperature of the second DTS on the PPE */
-static ssize_t ppe_show_temp1(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t ppe_show_temp1(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return ppe_show_temp(sysdev, buf, 0);
+        return ppe_show_temp(dev, buf, 0);
 }
 
-static ssize_t ppe_show_throttle_end(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t ppe_show_throttle_end(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, 32);
+        return show_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, 32);
 }
 
-static ssize_t ppe_show_throttle_begin(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t ppe_show_throttle_begin(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, 40);
+        return show_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, 40);
 }
 
-static ssize_t ppe_show_throttle_full_stop(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, char *buf)
+static ssize_t ppe_show_throttle_full_stop(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
-        return show_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, 48);
+        return show_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, 48);
 }
 
-static ssize_t ppe_store_throttle_end(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t ppe_store_throttle_end(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, size, 32);
+        return store_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, size, 32);
 }
 
-static ssize_t ppe_store_throttle_begin(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t ppe_store_throttle_begin(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, size, 40);
+        return store_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, size, 40);
 }
 
-static ssize_t ppe_store_throttle_full_stop(struct sys_device *sysdev,
-                        struct sysdev_attribute *attr, const char *buf, size_t size)
+static ssize_t ppe_store_throttle_full_stop(struct device *dev,
+                        struct device_attribute *attr, const char *buf, size_t size)
 {
-        return store_throttle(cbe_get_cpu_pmd_regs(sysdev->id), buf, size, 48);
+        return store_throttle(cbe_get_cpu_pmd_regs(dev->id), buf, size, 48);
 }
 
 
-static struct sysdev_attribute attr_spu_temperature = {
+static struct device_attribute attr_spu_temperature = {
         .attr = {.name = "temperature", .mode = 0400 },
         .show = spu_show_temp,
 };
 
-static SYSDEV_PREFIX_ATTR(spu, throttle_end, 0600);
-static SYSDEV_PREFIX_ATTR(spu, throttle_begin, 0600);
-static SYSDEV_PREFIX_ATTR(spu, throttle_full_stop, 0600);
+static DEVICE_PREFIX_ATTR(spu, throttle_end, 0600);
+static DEVICE_PREFIX_ATTR(spu, throttle_begin, 0600);
+static DEVICE_PREFIX_ATTR(spu, throttle_full_stop, 0600);
 
 
 static struct attribute *spu_attributes[] = {
@@ -272,19 +272,19 @@ static struct attribute_group spu_attribute_group = {
         .attrs  = spu_attributes,
 };
 
-static struct sysdev_attribute attr_ppe_temperature0 = {
+static struct device_attribute attr_ppe_temperature0 = {
         .attr = {.name = "temperature0", .mode = 0400 },
         .show = ppe_show_temp0,
 };
 
-static struct sysdev_attribute attr_ppe_temperature1 = {
+static struct device_attribute attr_ppe_temperature1 = {
         .attr = {.name = "temperature1", .mode = 0400 },
         .show = ppe_show_temp1,
 };
 
-static SYSDEV_PREFIX_ATTR(ppe, throttle_end, 0600);
-static SYSDEV_PREFIX_ATTR(ppe, throttle_begin, 0600);
-static SYSDEV_PREFIX_ATTR(ppe, throttle_full_stop, 0600);
+static DEVICE_PREFIX_ATTR(ppe, throttle_end, 0600);
+static DEVICE_PREFIX_ATTR(ppe, throttle_begin, 0600);
+static DEVICE_PREFIX_ATTR(ppe, throttle_full_stop, 0600);
 
 static struct attribute *ppe_attributes[] = {
         &attr_ppe_temperature0.attr,
@@ -307,7 +307,7 @@ static int __init init_default_values(void)
 {
         int cpu;
         struct cbe_pmd_regs __iomem *pmd_regs;
-        struct sys_device *sysdev;
+        struct device *dev;
         union ppe_spe_reg tpr;
         union spe_reg str1;
         u64 str2;
@@ -349,14 +349,14 @@ static int __init init_default_values(void)
 
         for_each_possible_cpu (cpu) {
                 pr_debug("processing cpu %d\n", cpu);
-                sysdev = get_cpu_sysdev(cpu);
+                dev = get_cpu_device(cpu);
 
-                if (!sysdev) {
-                        pr_info("invalid sysdev pointer for cbe_thermal\n");
+                if (!dev) {
+                        pr_info("invalid dev pointer for cbe_thermal\n");
                         return -EINVAL;
                 }
 
-                pmd_regs = cbe_get_cpu_pmd_regs(sysdev->id);
+                pmd_regs = cbe_get_cpu_pmd_regs(dev->id);
 
                 if (!pmd_regs) {
                         pr_info("invalid CBE regs pointer for cbe_thermal\n");
@@ -379,8 +379,8 @@ static int __init thermal_init(void)
         int rc = init_default_values();
 
         if (rc == 0) {
-                spu_add_sysdev_attr_group(&spu_attribute_group);
-                cpu_add_sysdev_attr_group(&ppe_attribute_group);
+                spu_add_dev_attr_group(&spu_attribute_group);
+                cpu_add_dev_attr_group(&ppe_attribute_group);
         }
 
         return rc;
@@ -389,8 +389,8 @@ module_init(thermal_init);
 
 static void __exit thermal_exit(void)
 {
-        spu_remove_sysdev_attr_group(&spu_attribute_group);
-        cpu_remove_sysdev_attr_group(&ppe_attribute_group);
+        spu_remove_dev_attr_group(&spu_attribute_group);
+        cpu_remove_dev_attr_group(&ppe_attribute_group);
 }
 module_exit(thermal_exit);
 
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index 3675da73623f..1708fb7aba35 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -522,31 +522,32 @@ void spu_init_channels(struct spu *spu)
 }
 EXPORT_SYMBOL_GPL(spu_init_channels);
 
-static struct sysdev_class spu_sysdev_class = {
+static struct bus_type spu_subsys = {
         .name = "spu",
+        .dev_name = "spu",
 };
 
-int spu_add_sysdev_attr(struct sysdev_attribute *attr)
+int spu_add_dev_attr(struct device_attribute *attr)
 {
         struct spu *spu;
 
         mutex_lock(&spu_full_list_mutex);
         list_for_each_entry(spu, &spu_full_list, full_list)
-                sysdev_create_file(&spu->sysdev, attr);
+                device_create_file(&spu->dev, attr);
         mutex_unlock(&spu_full_list_mutex);
 
         return 0;
 }
-EXPORT_SYMBOL_GPL(spu_add_sysdev_attr);
+EXPORT_SYMBOL_GPL(spu_add_dev_attr);
 
-int spu_add_sysdev_attr_group(struct attribute_group *attrs)
+int spu_add_dev_attr_group(struct attribute_group *attrs)
 {
         struct spu *spu;
         int rc = 0;
 
         mutex_lock(&spu_full_list_mutex);
         list_for_each_entry(spu, &spu_full_list, full_list) {
-                rc = sysfs_create_group(&spu->sysdev.kobj, attrs);
+                rc = sysfs_create_group(&spu->dev.kobj, attrs);
 
                 /* we're in trouble here, but try unwinding anyway */
                 if (rc) {
@@ -555,7 +556,7 @@ int spu_add_sysdev_attr_group(struct attribute_group *attrs)
 
                         list_for_each_entry_continue_reverse(spu,
                                         &spu_full_list, full_list)
-                                sysfs_remove_group(&spu->sysdev.kobj, attrs);
+                                sysfs_remove_group(&spu->dev.kobj, attrs);
                         break;
                 }
         }
@@ -564,45 +565,45 @@ int spu_add_sysdev_attr_group(struct attribute_group *attrs)
 
         return rc;
 }
-EXPORT_SYMBOL_GPL(spu_add_sysdev_attr_group);
+EXPORT_SYMBOL_GPL(spu_add_dev_attr_group);
 
 
-void spu_remove_sysdev_attr(struct sysdev_attribute *attr)
+void spu_remove_dev_attr(struct device_attribute *attr)
 {
         struct spu *spu;
 
         mutex_lock(&spu_full_list_mutex);
         list_for_each_entry(spu, &spu_full_list, full_list)
-                sysdev_remove_file(&spu->sysdev, attr);
+                device_remove_file(&spu->dev, attr);
         mutex_unlock(&spu_full_list_mutex);
 }
-EXPORT_SYMBOL_GPL(spu_remove_sysdev_attr);
+EXPORT_SYMBOL_GPL(spu_remove_dev_attr);
 
-void spu_remove_sysdev_attr_group(struct attribute_group *attrs)
+void spu_remove_dev_attr_group(struct attribute_group *attrs)
 {
         struct spu *spu;
 
         mutex_lock(&spu_full_list_mutex);
         list_for_each_entry(spu, &spu_full_list, full_list)
-                sysfs_remove_group(&spu->sysdev.kobj, attrs);
+                sysfs_remove_group(&spu->dev.kobj, attrs);
         mutex_unlock(&spu_full_list_mutex);
 }
-EXPORT_SYMBOL_GPL(spu_remove_sysdev_attr_group);
+EXPORT_SYMBOL_GPL(spu_remove_dev_attr_group);
 
-static int spu_create_sysdev(struct spu *spu)
+static int spu_create_dev(struct spu *spu)
 {
         int ret;
 
-        spu->sysdev.id = spu->number;
-        spu->sysdev.cls = &spu_sysdev_class;
-        ret = sysdev_register(&spu->sysdev);
+        spu->dev.id = spu->number;
+        spu->dev.bus = &spu_subsys;
+        ret = device_register(&spu->dev);
         if (ret) {
                 printk(KERN_ERR "Can't register SPU %d with sysfs\n",
                                 spu->number);
                 return ret;
         }
 
-        sysfs_add_device_to_node(&spu->sysdev, spu->node);
+        sysfs_add_device_to_node(&spu->dev, spu->node);
 
         return 0;
 }
@@ -638,7 +639,7 @@ static int __init create_spu(void *data)
         if (ret)
                 goto out_destroy;
 
-        ret = spu_create_sysdev(spu);
+        ret = spu_create_dev(spu);
         if (ret)
                 goto out_free_irqs;
 
@@ -695,10 +696,10 @@ static unsigned long long spu_acct_time(struct spu *spu,
 }
 
 
-static ssize_t spu_stat_show(struct sys_device *sysdev,
-                                struct sysdev_attribute *attr, char *buf)
+static ssize_t spu_stat_show(struct device *dev,
+                                struct device_attribute *attr, char *buf)
 {
-        struct spu *spu = container_of(sysdev, struct spu, sysdev);
+        struct spu *spu = container_of(dev, struct spu, dev);
 
         return sprintf(buf, "%s %llu %llu %llu %llu "
                       "%llu %llu %llu %llu %llu %llu %llu %llu\n",
@@ -717,7 +718,7 @@ static ssize_t spu_stat_show(struct sys_device *sysdev,
                 spu->stats.libassist);
 }
 
-static SYSDEV_ATTR(stat, 0644, spu_stat_show, NULL);
+static DEVICE_ATTR(stat, 0644, spu_stat_show, NULL);
 
 #ifdef CONFIG_KEXEC
 
@@ -816,8 +817,8 @@ static int __init init_spu_base(void)
         if (!spu_management_ops)
                 goto out;
 
-        /* create sysdev class for spus */
-        ret = sysdev_class_register(&spu_sysdev_class);
+        /* create system subsystem for spus */
+        ret = subsys_system_register(&spu_subsys, NULL);
         if (ret)
                 goto out;
 
@@ -826,7 +827,7 @@ static int __init init_spu_base(void)
         if (ret < 0) {
                 printk(KERN_WARNING "%s: Error initializing spus\n",
                         __func__);
-                goto out_unregister_sysdev_class;
+                goto out_unregister_subsys;
         }
 
         if (ret > 0)
@@ -836,15 +837,15 @@ static int __init init_spu_base(void)
         xmon_register_spus(&spu_full_list);
         crash_register_spus(&spu_full_list);
         mutex_unlock(&spu_full_list_mutex);
-        spu_add_sysdev_attr(&attr_stat);
+        spu_add_dev_attr(&dev_attr_stat);
         register_syscore_ops(&spu_syscore_ops);
 
         spu_init_affinity();
 
         return 0;
 
- out_unregister_sysdev_class:
-        sysdev_class_unregister(&spu_sysdev_class);
+ out_unregister_subsys:
+        bus_unregister(&spu_subsys);
  out:
         return ret;
 }