diff options
author | Andrea Arcangeli <aarcange@redhat.com> | 2011-11-02 16:37:11 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-02 19:06:57 -0400 |
commit | 8596468487e2062cae2aad56e973784e03959245 (patch) | |
tree | 259696a6595fbd3ea56a987a5947217475542744 /arch/powerpc/mm | |
parent | 405e44f2e312dd5dd63e5a9f459bffcbcd4368ef (diff) |
powerpc: gup_hugepte() avoid freeing the head page too many times
We only taken "refs" pins on the head page not "*nr" pins.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/powerpc/mm')
-rw-r--r-- | arch/powerpc/mm/hugetlbpage.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index b649c288af90..78b14abded65 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c | |||
@@ -428,10 +428,9 @@ static noinline int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long add | |||
428 | 428 | ||
429 | if (unlikely(pte_val(pte) != pte_val(*ptep))) { | 429 | if (unlikely(pte_val(pte) != pte_val(*ptep))) { |
430 | /* Could be optimized better */ | 430 | /* Could be optimized better */ |
431 | while (*nr) { | 431 | *nr -= refs; |
432 | while (refs--) | ||
432 | put_page(head); | 433 | put_page(head); |
433 | (*nr)--; | ||
434 | } | ||
435 | } | 434 | } |
436 | 435 | ||
437 | return 1; | 436 | return 1; |