diff options
author | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2015-03-30 01:11:03 -0400 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2015-04-16 21:23:39 -0400 |
commit | 691e95fd7396905a38d98919e9c150dbc3ea21a3 (patch) | |
tree | d89b898d4f42d167f0da169f482d7104b46870d8 /arch/powerpc/mm/hash_utils_64.c | |
parent | dac5657067919161eb3273ca787d8ae9814801e7 (diff) |
powerpc/mm/thp: Make page table walk safe against thp split/collapse
We can disable a THP split or a hugepage collapse by disabling irq.
We do send IPI to all the cpus in the early part of split/collapse,
and disabling local irq ensure we don't make progress with
split/collapse. If the THP is getting split we return NULL from
find_linux_pte_or_hugepte(). For all the current callers it should be ok.
We need to be careful if we want to use returned pte_t pointer outside
the irq disabled region. W.r.t to THP split, the pfn remains the same,
but then a hugepage collapse will result in a pfn change. There are
few steps we can take to avoid a hugepage collapse.One way is to take page
reference inside the irq disable region. Other option is to take
mmap_sem so that a parallel collapse will not happen. We can also
disable collapse by taking pmd_lock. Another method used by kvm
subsystem is to check whether we had a mmu_notifer update in between
using mmu_notifier_retry().
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/mm/hash_utils_64.c')
-rw-r--r-- | arch/powerpc/mm/hash_utils_64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 2c2022d16059..444f7a5b859b 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c | |||
@@ -1066,7 +1066,7 @@ int hash_page_mm(struct mm_struct *mm, unsigned long ea, | |||
1066 | #endif /* CONFIG_PPC_64K_PAGES */ | 1066 | #endif /* CONFIG_PPC_64K_PAGES */ |
1067 | 1067 | ||
1068 | /* Get PTE and page size from page tables */ | 1068 | /* Get PTE and page size from page tables */ |
1069 | ptep = find_linux_pte_or_hugepte(pgdir, ea, &hugeshift); | 1069 | ptep = __find_linux_pte_or_hugepte(pgdir, ea, &hugeshift); |
1070 | if (ptep == NULL || !pte_present(*ptep)) { | 1070 | if (ptep == NULL || !pte_present(*ptep)) { |
1071 | DBG_LOW(" no PTE !\n"); | 1071 | DBG_LOW(" no PTE !\n"); |
1072 | rc = 1; | 1072 | rc = 1; |