diff options
author | Jiri Kosina <jkosina@suse.cz> | 2012-08-12 23:18:28 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2012-08-24 06:26:07 -0400 |
commit | 7256a5d2da56f2ea8ad49e8dbe9e2984f0899b42 (patch) | |
tree | 95109ff3cb478eae2e56033b2a52859ca25b9b37 /arch/powerpc/kernel | |
parent | 4c374af5fdee4bc6b4f5ea96c1a0f0ad7d3566be (diff) |
powerpc: Fix personality handling in ppc64_personality()
Directly comparing current->personality against PER_LINUX32 doesn't work
in cases when any of the personality flags stored in the top three bytes
are used.
Directly forcefully setting personality to PER_LINUX32 or PER_LINUX
discards any flags stored in the top three bytes
Use personality() macro to compare only PER_MASK bytes and make sure that
we are setting only the bits that should be set, instead of overwriting
the whole value.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/kernel')
-rw-r--r-- | arch/powerpc/kernel/syscalls.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c index f2496f2faecc..4e3cc47f26b9 100644 --- a/arch/powerpc/kernel/syscalls.c +++ b/arch/powerpc/kernel/syscalls.c | |||
@@ -107,11 +107,11 @@ long ppc64_personality(unsigned long personality) | |||
107 | long ret; | 107 | long ret; |
108 | 108 | ||
109 | if (personality(current->personality) == PER_LINUX32 | 109 | if (personality(current->personality) == PER_LINUX32 |
110 | && personality == PER_LINUX) | 110 | && personality(personality) == PER_LINUX) |
111 | personality = PER_LINUX32; | 111 | personality = (personality & ~PER_MASK) | PER_LINUX32; |
112 | ret = sys_personality(personality); | 112 | ret = sys_personality(personality); |
113 | if (ret == PER_LINUX32) | 113 | if (personality(ret) == PER_LINUX32) |
114 | ret = PER_LINUX; | 114 | ret = (ret & ~PER_MASK) | PER_LINUX; |
115 | return ret; | 115 | return ret; |
116 | } | 116 | } |
117 | #endif | 117 | #endif |