diff options
author | Gavin Shan <shangw@linux.vnet.ibm.com> | 2013-06-27 01:46:46 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2013-06-30 21:10:33 -0400 |
commit | 56ca4fde90009094b1a46971de3879d5f2dd724e (patch) | |
tree | 2a49909519e9e41e0dd8d13ecdc82bae6dbfd75e /arch/powerpc/kernel/eeh.c | |
parent | 88b6d14b2bb48ea4f66fedfe671f98544395b305 (diff) |
powerpc/eeh: Refactor the output message
We needn't the the whole backtrace other than one-line message in
the error reporting interrupt handler. For errors triggered by
access PCI config space or MMIO, we replace "WARN(1, ...)" with
pr_err() and dump_stack(). The patch also adds more output messages
to indicate what EEH core is doing. Besides, some printk() are
replaced with pr_warning().
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/kernel/eeh.c')
-rw-r--r-- | arch/powerpc/kernel/eeh.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c index 416fb432d7e2..3a8f82fd9005 100644 --- a/arch/powerpc/kernel/eeh.c +++ b/arch/powerpc/kernel/eeh.c | |||
@@ -329,7 +329,9 @@ static int eeh_phb_check_failure(struct eeh_pe *pe) | |||
329 | eeh_serialize_unlock(flags); | 329 | eeh_serialize_unlock(flags); |
330 | eeh_send_failure_event(phb_pe); | 330 | eeh_send_failure_event(phb_pe); |
331 | 331 | ||
332 | WARN(1, "EEH: PHB failure detected\n"); | 332 | pr_err("EEH: PHB#%x failure detected\n", |
333 | phb_pe->phb->global_number); | ||
334 | dump_stack(); | ||
333 | 335 | ||
334 | return 1; | 336 | return 1; |
335 | out: | 337 | out: |
@@ -458,7 +460,10 @@ int eeh_dev_check_failure(struct eeh_dev *edev) | |||
458 | * a stack trace will help the device-driver authors figure | 460 | * a stack trace will help the device-driver authors figure |
459 | * out what happened. So print that out. | 461 | * out what happened. So print that out. |
460 | */ | 462 | */ |
461 | WARN(1, "EEH: failure detected\n"); | 463 | pr_err("EEH: Frozen PE#%x detected on PHB#%x\n", |
464 | pe->addr, pe->phb->global_number); | ||
465 | dump_stack(); | ||
466 | |||
462 | return 1; | 467 | return 1; |
463 | 468 | ||
464 | dn_unlock: | 469 | dn_unlock: |