aboutsummaryrefslogtreecommitdiffstats
path: root/arch/parisc/mm
diff options
context:
space:
mode:
authorJohannes Weiner <hannes@cmpxchg.org>2013-09-12 18:13:39 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-12 18:38:01 -0400
commit759496ba6407c6994d6a5ce3a5e74937d7816208 (patch)
treeaeff8de8af36f70f2591114cef58c9ae7df25565 /arch/parisc/mm
parent871341023c771ad233620b7a1fb3d9c7031c4e5c (diff)
arch: mm: pass userspace fault flag to generic fault handler
Unlike global OOM handling, memory cgroup code will invoke the OOM killer in any OOM situation because it has no way of telling faults occuring in kernel context - which could be handled more gracefully - from user-triggered faults. Pass a flag that identifies faults originating in user space from the architecture-specific fault handlers to generic code so that memcg OOM handling can be improved. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Michal Hocko <mhocko@suse.cz> Cc: David Rientjes <rientjes@google.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: azurIt <azurit@pobox.sk> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/parisc/mm')
-rw-r--r--arch/parisc/mm/fault.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/arch/parisc/mm/fault.c b/arch/parisc/mm/fault.c
index f247a3480e8e..d10d27a720c0 100644
--- a/arch/parisc/mm/fault.c
+++ b/arch/parisc/mm/fault.c
@@ -180,6 +180,10 @@ void do_page_fault(struct pt_regs *regs, unsigned long code,
180 if (in_atomic() || !mm) 180 if (in_atomic() || !mm)
181 goto no_context; 181 goto no_context;
182 182
183 if (user_mode(regs))
184 flags |= FAULT_FLAG_USER;
185 if (acc_type & VM_WRITE)
186 flags |= FAULT_FLAG_WRITE;
183retry: 187retry:
184 down_read(&mm->mmap_sem); 188 down_read(&mm->mmap_sem);
185 vma = find_vma_prev(mm, address, &prev_vma); 189 vma = find_vma_prev(mm, address, &prev_vma);
@@ -203,8 +207,7 @@ good_area:
203 * fault. 207 * fault.
204 */ 208 */
205 209
206 fault = handle_mm_fault(mm, vma, address, 210 fault = handle_mm_fault(mm, vma, address, flags);
207 flags | ((acc_type & VM_WRITE) ? FAULT_FLAG_WRITE : 0));
208 211
209 if ((fault & VM_FAULT_RETRY) && fatal_signal_pending(current)) 212 if ((fault & VM_FAULT_RETRY) && fatal_signal_pending(current))
210 return; 213 return;