diff options
author | Stephan Baerwolf <stephan.baerwolf@tu-ilmenau.de> | 2011-05-11 12:03:29 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-05-16 05:01:18 -0400 |
commit | db670dac49b5423b39b5e523d28fe32045d71b10 (patch) | |
tree | 194220c83cb097504ddf7bcccc7ce93d6a23eac3 /arch/mips/pmc-sierra | |
parent | db44fc017d5989302713ab4e7f9e922b648f4b59 (diff) |
sched: Fix and optimise calculation of the weight-inverse
If the inverse loadweight should be zero, function "calc_delta_mine"
calculates the inverse of "lw->weight" (in 32bit integer ops).
This calculation is actually a little bit impure (because it is
inverting something around "lw-weight"+1), especially when
"lw->weight" becomes smaller.
The correct inverse would be 1/lw->weight multiplied by
"WMULT_CONST" for fixcomma-scaling it into integers.
(So WMULT_CONST/lw->weight ...)
The old, impure algorithm took two divisions for inverting lw->weight,
the new, more exact one only takes one and an additional unlikely-if.
Signed-off-by: Stephan Baerwolf <stephan.baerwolf@tu-ilmenau.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/n/tip-0pz0wnyalr4tk4ln11xwumdx@git.kernel.org
[ This could explain some aritmetical issues for small shares but nothing
concrete has been reported yet so we are not confident enough to queue
this up in sched/urgent and for -stable backport. But if anyone finds
this commit and sees it to fix some badness then we can certainly
change our mind! ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/mips/pmc-sierra')
0 files changed, 0 insertions, 0 deletions