[IA64] hotplug/ia64: SN Hotplug Driver - new SN PROM version code

This patch is a rewrite of the code to check the PROM version.  The current
code has some deficiences in the way PROM comparisons were made.  The minimum
value of PROM that will boot has also been changed to 4.04.

Signed-off-by: Prarit Bhargava <prarit@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

2 files changed, 7 insertions, 9 deletions

diff --git a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
index 22e10d282c7f..7c7fe441d623 100644
--- a/arch/ia64/sn/kernel/setup.c
+++ b/arch/ia64/sn/kernel/setup.c
@@ -270,7 +270,7 @@ void __init sn_setup(char **cmdline_p)
 {
         long status, ticks_per_sec, drift;
         int pxm;
-        int major = sn_sal_rev_major(), minor = sn_sal_rev_minor();
+        u32 version = sn_sal_rev();
         extern void sn_cpu_init(void);
 
         ia64_sn_plat_set_error_handling_features();
@@ -308,22 +308,21 @@ void __init sn_setup(char **cmdline_p)
          * support here so we don't have to listen to failed keyboard probe
          * messages.
          */
-        if ((major < 2 || (major == 2 && minor <= 9)) &&
-            acpi_kbd_controller_present) {
+        if (version <= 0x0209 && acpi_kbd_controller_present) {
                 printk(KERN_INFO "Disabling legacy keyboard support as prom "
                        "is too old and doesn't provide FADT\n");
                 acpi_kbd_controller_present = 0;
         }
 
-        printk("SGI SAL version %x.%02x\n", major, minor);
+        printk("SGI SAL version %x.%02x\n", version >> 8, version & 0x00FF);
 
         /*
          * Confirm the SAL we're running on is recent enough...
          */
-        if ((major < SN_SAL_MIN_MAJOR) || (major == SN_SAL_MIN_MAJOR &&
-                                           minor < SN_SAL_MIN_MINOR)) {
+        if (version < SN_SAL_MIN_VERSION) {
                 printk(KERN_ERR "This kernel needs SGI SAL version >= "
-                       "%x.%02x\n", SN_SAL_MIN_MAJOR, SN_SAL_MIN_MINOR);
+                       "%x.%02x\n", SN_SAL_MIN_VERSION >> 8,
+                        SN_SAL_MIN_VERSION & 0x00FF);
                 panic("PROM version too old\n");
         }
 
diff --git a/arch/ia64/sn/pci/tioca_provider.c b/arch/ia64/sn/pci/tioca_provider.c
index 05aa8c2fe9bb..51cc4e63092c 100644
--- a/arch/ia64/sn/pci/tioca_provider.c
+++ b/arch/ia64/sn/pci/tioca_provider.c
@@ -589,8 +589,7 @@ tioca_bus_fixup(struct pcibus_bussoft *prom_bussoft)
 
         /* sanity check prom rev */
 
-        if (sn_sal_rev_major() < 4 ||
-            (sn_sal_rev_major() == 4 && sn_sal_rev_minor() < 6)) {
+        if (sn_sal_rev() < 0x0406) {
                 printk
                     (KERN_ERR "%s:  SGI prom rev 4.06 or greater required "
                      "for tioca support\n", __FUNCTION__);