TTY: switch tty_flip_buffer_push

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

Now, the one where most of tty_port_tty_get gets removed:
tty_flip_buffer_push.

IOW we also closed all the races in drivers not using tty_port_tty_get
at all yet.

Also we move tty_flip_buffer_push declaration from include/linux/tty.h
to include/linux/tty_flip.h to all others while we are changing it
anyway.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 4 insertions, 14 deletions

diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c
index 942022a5bc86..da2f319fb71d 100644
--- a/arch/ia64/hp/sim/simserial.c
+++ b/arch/ia64/hp/sim/simserial.c
@@ -53,9 +53,8 @@ struct tty_driver *hp_simserial_driver;
 
 static struct console *console;
 
-static void receive_chars(struct tty_struct *tty)
+static void receive_chars(struct tty_port *port)
 {
-        struct tty_port *port = tty->port;
         unsigned char ch;
         static unsigned char seen_esc = 0;
 
@@ -85,7 +84,7 @@ static void receive_chars(struct tty_struct *tty)
                 if (tty_insert_flip_char(port, ch, TTY_NORMAL) == 0)
                         break;
         }
-        tty_flip_buffer_push(tty);
+        tty_flip_buffer_push(port);
 }
 
 /*
@@ -94,18 +93,9 @@ static void receive_chars(struct tty_struct *tty)
 static irqreturn_t rs_interrupt_single(int irq, void *dev_id)
 {
         struct serial_state *info = dev_id;
-        struct tty_struct *tty = tty_port_tty_get(&info->port);
 
-        if (!tty) {
-                printk(KERN_INFO "%s: tty=0 problem\n", __func__);
-                return IRQ_NONE;
-        }
-        /*
-         * pretty simple in our case, because we only get interrupts
-         * on inbound traffic
-         */
-        receive_chars(tty);
-        tty_kref_put(tty);
+        receive_chars(&info->port);
+
         return IRQ_HANDLED;
 }