aboutsummaryrefslogtreecommitdiffstats
path: root/arch/cris
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2014-03-13 14:00:37 -0400
committerIngo Molnar <mingo@kernel.org>2014-04-18 08:20:00 -0400
commit17b40213ab2b091fd5d2a9337eae62312608ad3d (patch)
tree1ea889328bfcd260e92a06049312503404cdd453 /arch/cris
parenta8ec1516a74554992605f230859936d5d79c27ed (diff)
arch,cris: Convert smp_mb__*()
Cris fully relies on asm-generic/barrier.h, therefore its smp_mb() is barrier(), thus we can use the default implementation that uses smp_mb(). (Include asm/system.h and asm/barrier.h to avoid header dependency hell.) Signed-off-by: Peter Zijlstra <peterz@infradead.org> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Link: http://lkml.kernel.org/n/tip-wvewbe8os3s1e4pt1cdotuee@git.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Jesper Nilsson <jesper.nilsson@axis.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mikael Starvik <starvik@axis.com> Cc: linux-cris-kernel@axis.com Cc: linux-kernel@vger.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/cris')
-rw-r--r--arch/cris/include/asm/atomic.h8
-rw-r--r--arch/cris/include/asm/bitops.h9
2 files changed, 4 insertions, 13 deletions
diff --git a/arch/cris/include/asm/atomic.h b/arch/cris/include/asm/atomic.h
index 1056a5dfe04f..aa429baebaf9 100644
--- a/arch/cris/include/asm/atomic.h
+++ b/arch/cris/include/asm/atomic.h
@@ -7,6 +7,8 @@
7#include <linux/types.h> 7#include <linux/types.h>
8#include <asm/cmpxchg.h> 8#include <asm/cmpxchg.h>
9#include <arch/atomic.h> 9#include <arch/atomic.h>
10#include <arch/system.h>
11#include <asm/barrier.h>
10 12
11/* 13/*
12 * Atomic operations that C can't guarantee us. Useful for 14 * Atomic operations that C can't guarantee us. Useful for
@@ -151,10 +153,4 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)
151 return ret; 153 return ret;
152} 154}
153 155
154/* Atomic operations are already serializing */
155#define smp_mb__before_atomic_dec() barrier()
156#define smp_mb__after_atomic_dec() barrier()
157#define smp_mb__before_atomic_inc() barrier()
158#define smp_mb__after_atomic_inc() barrier()
159
160#endif 156#endif
diff --git a/arch/cris/include/asm/bitops.h b/arch/cris/include/asm/bitops.h
index 053c17b36559..bd49a546f4f5 100644
--- a/arch/cris/include/asm/bitops.h
+++ b/arch/cris/include/asm/bitops.h
@@ -21,6 +21,7 @@
21#include <arch/bitops.h> 21#include <arch/bitops.h>
22#include <linux/atomic.h> 22#include <linux/atomic.h>
23#include <linux/compiler.h> 23#include <linux/compiler.h>
24#include <asm/barrier.h>
24 25
25/* 26/*
26 * set_bit - Atomically set a bit in memory 27 * set_bit - Atomically set a bit in memory
@@ -42,7 +43,7 @@
42 * 43 *
43 * clear_bit() is atomic and may not be reordered. However, it does 44 * clear_bit() is atomic and may not be reordered. However, it does
44 * not contain a memory barrier, so if it is used for locking purposes, 45 * not contain a memory barrier, so if it is used for locking purposes,
45 * you should call smp_mb__before_clear_bit() and/or smp_mb__after_clear_bit() 46 * you should call smp_mb__before_atomic() and/or smp_mb__after_atomic()
46 * in order to ensure changes are visible on other processors. 47 * in order to ensure changes are visible on other processors.
47 */ 48 */
48 49
@@ -84,12 +85,6 @@ static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
84 return retval; 85 return retval;
85} 86}
86 87
87/*
88 * clear_bit() doesn't provide any barrier for the compiler.
89 */
90#define smp_mb__before_clear_bit() barrier()
91#define smp_mb__after_clear_bit() barrier()
92
93/** 88/**
94 * test_and_clear_bit - Clear a bit and return its old value 89 * test_and_clear_bit - Clear a bit and return its old value
95 * @nr: Bit to clear 90 * @nr: Bit to clear