diff options
author | Lennert Buytenhek <buytenh@wantstofly.org> | 2008-03-27 14:51:41 -0400 |
---|---|---|
committer | Nicolas Pitre <nico@marvell.com> | 2008-03-27 14:51:41 -0400 |
commit | 159ffb3a04f6bc619643af680df406faafd0199d (patch) | |
tree | 45d76928836065a3207c15e5bc2037b186213ace /arch/arm/mach-orion/pci.c | |
parent | d50c60a87a95a42f1bc984150d3eebc77a0b0c14 (diff) |
Orion: general cleanup
Various Orion cleanups:
- Unify GPL license banner format across all files.
- Unify naming of .h double inclusion guard preprocessor macros.
- Unify spelling of "PCIe" (variants seen: PCIE, PCIe, PCI-EX.)
- Various typo fixes.
- Remove __init attributes from prototypes declared in headers.
- Remove trailing comments from #endif statements.
- Mark a couple of locally-used-only structs static.
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Reviewed-by: Tzachi Perelstein <tzachi@marvell.com>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Nicolas Pitre <nico@marvell.com>
Diffstat (limited to 'arch/arm/mach-orion/pci.c')
-rw-r--r-- | arch/arm/mach-orion/pci.c | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/arch/arm/mach-orion/pci.c b/arch/arm/mach-orion/pci.c index e3aab14b943c..59684cc329bc 100644 --- a/arch/arm/mach-orion/pci.c +++ b/arch/arm/mach-orion/pci.c | |||
@@ -1,12 +1,12 @@ | |||
1 | /* | 1 | /* |
2 | * arch/arm/mach-orion/pci.c | 2 | * arch/arm/mach-orion/pci.c |
3 | * | 3 | * |
4 | * PCI and PCIE functions for Marvell Orion System On Chip | 4 | * PCI and PCIe functions for Marvell Orion System On Chip |
5 | * | 5 | * |
6 | * Maintainer: Tzachi Perelstein <tzachi@marvell.com> | 6 | * Maintainer: Tzachi Perelstein <tzachi@marvell.com> |
7 | * | 7 | * |
8 | * This file is licensed under the terms of the GNU General Public | 8 | * This file is licensed under the terms of the GNU General Public |
9 | * License version 2. This program is licensed "as is" without any | 9 | * License version 2. This program is licensed "as is" without any |
10 | * warranty of any kind, whether express or implied. | 10 | * warranty of any kind, whether express or implied. |
11 | */ | 11 | */ |
12 | 12 | ||
@@ -18,12 +18,12 @@ | |||
18 | #include "common.h" | 18 | #include "common.h" |
19 | 19 | ||
20 | /***************************************************************************** | 20 | /***************************************************************************** |
21 | * Orion has one PCIE controller and one PCI controller. | 21 | * Orion has one PCIe controller and one PCI controller. |
22 | * | 22 | * |
23 | * Note1: The local PCIE bus number is '0'. The local PCI bus number | 23 | * Note1: The local PCIe bus number is '0'. The local PCI bus number |
24 | * follows the scanned PCIE bridged busses, if any. | 24 | * follows the scanned PCIe bridged busses, if any. |
25 | * | 25 | * |
26 | * Note2: It is possible for PCI/PCIE agents to access many subsystem's | 26 | * Note2: It is possible for PCI/PCIe agents to access many subsystem's |
27 | * space, by configuring BARs and Address Decode Windows, e.g. flashes on | 27 | * space, by configuring BARs and Address Decode Windows, e.g. flashes on |
28 | * device bus, Orion registers, etc. However this code only enable the | 28 | * device bus, Orion registers, etc. However this code only enable the |
29 | * access to DDR banks. | 29 | * access to DDR banks. |
@@ -31,7 +31,7 @@ | |||
31 | 31 | ||
32 | 32 | ||
33 | /***************************************************************************** | 33 | /***************************************************************************** |
34 | * PCIE controller | 34 | * PCIe controller |
35 | ****************************************************************************/ | 35 | ****************************************************************************/ |
36 | #define PCIE_BASE ((void __iomem *)ORION_PCIE_VIRT_BASE) | 36 | #define PCIE_BASE ((void __iomem *)ORION_PCIE_VIRT_BASE) |
37 | 37 | ||
@@ -67,7 +67,7 @@ static int pcie_valid_config(int bus, int dev) | |||
67 | 67 | ||
68 | 68 | ||
69 | /* | 69 | /* |
70 | * PCIE config cycles are done by programming the PCIE_CONF_ADDR register | 70 | * PCIe config cycles are done by programming the PCIE_CONF_ADDR register |
71 | * and then reading the PCIE_CONF_DATA register. Need to make sure these | 71 | * and then reading the PCIE_CONF_DATA register. Need to make sure these |
72 | * transactions are atomic. | 72 | * transactions are atomic. |
73 | */ | 73 | */ |
@@ -133,7 +133,7 @@ static int pcie_wr_conf(struct pci_bus *bus, u32 devfn, | |||
133 | return ret; | 133 | return ret; |
134 | } | 134 | } |
135 | 135 | ||
136 | struct pci_ops pcie_ops = { | 136 | static struct pci_ops pcie_ops = { |
137 | .read = pcie_rd_conf, | 137 | .read = pcie_rd_conf, |
138 | .write = pcie_wr_conf, | 138 | .write = pcie_wr_conf, |
139 | }; | 139 | }; |
@@ -170,23 +170,23 @@ static int __init pcie_setup(struct pci_sys_data *sys) | |||
170 | /* | 170 | /* |
171 | * IORESOURCE_IO | 171 | * IORESOURCE_IO |
172 | */ | 172 | */ |
173 | res[0].name = "PCI-EX I/O Space"; | 173 | res[0].name = "PCIe I/O Space"; |
174 | res[0].flags = IORESOURCE_IO; | 174 | res[0].flags = IORESOURCE_IO; |
175 | res[0].start = ORION_PCIE_IO_BUS_BASE; | 175 | res[0].start = ORION_PCIE_IO_BUS_BASE; |
176 | res[0].end = res[0].start + ORION_PCIE_IO_SIZE - 1; | 176 | res[0].end = res[0].start + ORION_PCIE_IO_SIZE - 1; |
177 | if (request_resource(&ioport_resource, &res[0])) | 177 | if (request_resource(&ioport_resource, &res[0])) |
178 | panic("Request PCIE IO resource failed\n"); | 178 | panic("Request PCIe IO resource failed\n"); |
179 | sys->resource[0] = &res[0]; | 179 | sys->resource[0] = &res[0]; |
180 | 180 | ||
181 | /* | 181 | /* |
182 | * IORESOURCE_MEM | 182 | * IORESOURCE_MEM |
183 | */ | 183 | */ |
184 | res[1].name = "PCI-EX Memory Space"; | 184 | res[1].name = "PCIe Memory Space"; |
185 | res[1].flags = IORESOURCE_MEM; | 185 | res[1].flags = IORESOURCE_MEM; |
186 | res[1].start = ORION_PCIE_MEM_PHYS_BASE; | 186 | res[1].start = ORION_PCIE_MEM_PHYS_BASE; |
187 | res[1].end = res[1].start + ORION_PCIE_MEM_SIZE - 1; | 187 | res[1].end = res[1].start + ORION_PCIE_MEM_SIZE - 1; |
188 | if (request_resource(&iomem_resource, &res[1])) | 188 | if (request_resource(&iomem_resource, &res[1])) |
189 | panic("Request PCIE Memory resource failed\n"); | 189 | panic("Request PCIe Memory resource failed\n"); |
190 | sys->resource[1] = &res[1]; | 190 | sys->resource[1] = &res[1]; |
191 | 191 | ||
192 | sys->resource[2] = NULL; | 192 | sys->resource[2] = NULL; |
@@ -351,7 +351,7 @@ static int orion_pci_wr_conf(struct pci_bus *bus, u32 devfn, | |||
351 | PCI_FUNC(devfn), where, size, val); | 351 | PCI_FUNC(devfn), where, size, val); |
352 | } | 352 | } |
353 | 353 | ||
354 | struct pci_ops pci_ops = { | 354 | static struct pci_ops pci_ops = { |
355 | .read = orion_pci_rd_conf, | 355 | .read = orion_pci_rd_conf, |
356 | .write = orion_pci_wr_conf, | 356 | .write = orion_pci_wr_conf, |
357 | }; | 357 | }; |
@@ -508,7 +508,7 @@ static int __init pci_setup(struct pci_sys_data *sys) | |||
508 | 508 | ||
509 | 509 | ||
510 | /***************************************************************************** | 510 | /***************************************************************************** |
511 | * General PCIE + PCI | 511 | * General PCIe + PCI |
512 | ****************************************************************************/ | 512 | ****************************************************************************/ |
513 | static void __devinit rc_pci_fixup(struct pci_dev *dev) | 513 | static void __devinit rc_pci_fixup(struct pci_dev *dev) |
514 | { | 514 | { |