diff options
author | Paul Walmsley <paul@pwsan.com> | 2009-01-28 14:35:31 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-02-08 12:50:47 -0500 |
commit | 883992bd8f6924c9aa849f2dac381075e2e55a9d (patch) | |
tree | 30440178d023c8e1334e4e46aa0965906044792d /arch/arm/mach-omap2/clock34xx.c | |
parent | 8263e5b31eae2bbf689ff08a7da334329c9f353b (diff) |
[ARM] OMAP2/3 clock: don't tinker with hardirqs when they are supposed to be disabled
Clock rate change code executes inside a spinlock with hardirqs
disabled. The only code that should be messing around with the
hardirq state should be the plat-omap/clock.c code. In the
omap2_reprogram_dpllcore() case, this probably just wastes cycles, but
in the omap3_core_dpll_m2_set_rate() case, this is a nasty bug.
linux-omap source commit is b9b6208dadb5e0d8b290900a3ffa911673ca97ed.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-omap2/clock34xx.c')
-rw-r--r-- | arch/arm/mach-omap2/clock34xx.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c index a853b1e149ee..3b6e27bc9fe3 100644 --- a/arch/arm/mach-omap2/clock34xx.c +++ b/arch/arm/mach-omap2/clock34xx.c | |||
@@ -686,10 +686,8 @@ static int omap3_core_dpll_m2_set_rate(struct clk *clk, unsigned long rate) | |||
686 | WARN_ON(new_div != 1 && new_div != 2); | 686 | WARN_ON(new_div != 1 && new_div != 2); |
687 | 687 | ||
688 | /* REVISIT: Add SDRC_MR changing to this code also */ | 688 | /* REVISIT: Add SDRC_MR changing to this code also */ |
689 | local_irq_disable(); | ||
690 | omap3_configure_core_dpll(sp->rfr_ctrl, sp->actim_ctrla, | 689 | omap3_configure_core_dpll(sp->rfr_ctrl, sp->actim_ctrla, |
691 | sp->actim_ctrlb, new_div); | 690 | sp->actim_ctrlb, new_div); |
692 | local_irq_enable(); | ||
693 | 691 | ||
694 | return 0; | 692 | return 0; |
695 | } | 693 | } |