diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-05-08 19:48:02 -0400 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2013-05-08 19:48:02 -0400 |
commit | 348c34225d4395b769ec6d283b0c7ace0b430a38 (patch) | |
tree | d540863cbc177ccef26875666ffea16ab85949b0 /arch/arm/mach-omap1 | |
parent | e7e17c538604928b98107a08c2c5dc54745d85fe (diff) |
ARM: OMAP1: DMA: fix error handling in omap1_system_dma_init()
Add the missing iounmap() before return from omap1_system_dma_init()
in the error handling case.
Also removed platform_device_del() on add resources error case which
cause dup device delete.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm/mach-omap1')
-rw-r--r-- | arch/arm/mach-omap1/dma.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c index 1a4e887f028d..68ab858e27b7 100644 --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c | |||
@@ -301,7 +301,7 @@ static int __init omap1_system_dma_init(void) | |||
301 | if (ret) { | 301 | if (ret) { |
302 | dev_err(&pdev->dev, "%s: Unable to add resources for %s%d\n", | 302 | dev_err(&pdev->dev, "%s: Unable to add resources for %s%d\n", |
303 | __func__, pdev->name, pdev->id); | 303 | __func__, pdev->name, pdev->id); |
304 | goto exit_device_put; | 304 | goto exit_iounmap; |
305 | } | 305 | } |
306 | 306 | ||
307 | p = kzalloc(sizeof(struct omap_system_dma_plat_info), GFP_KERNEL); | 307 | p = kzalloc(sizeof(struct omap_system_dma_plat_info), GFP_KERNEL); |
@@ -309,7 +309,7 @@ static int __init omap1_system_dma_init(void) | |||
309 | dev_err(&pdev->dev, "%s: Unable to allocate 'p' for %s\n", | 309 | dev_err(&pdev->dev, "%s: Unable to allocate 'p' for %s\n", |
310 | __func__, pdev->name); | 310 | __func__, pdev->name); |
311 | ret = -ENOMEM; | 311 | ret = -ENOMEM; |
312 | goto exit_device_del; | 312 | goto exit_iounmap; |
313 | } | 313 | } |
314 | 314 | ||
315 | d = kzalloc(sizeof(struct omap_dma_dev_attr), GFP_KERNEL); | 315 | d = kzalloc(sizeof(struct omap_dma_dev_attr), GFP_KERNEL); |
@@ -402,8 +402,8 @@ exit_release_d: | |||
402 | kfree(d); | 402 | kfree(d); |
403 | exit_release_p: | 403 | exit_release_p: |
404 | kfree(p); | 404 | kfree(p); |
405 | exit_device_del: | 405 | exit_iounmap: |
406 | platform_device_del(pdev); | 406 | iounmap(dma_base); |
407 | exit_device_put: | 407 | exit_device_put: |
408 | platform_device_put(pdev); | 408 | platform_device_put(pdev); |
409 | 409 | ||