aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/kernel
diff options
context:
space:
mode:
authorNicolas Pitre <nicolas.pitre@linaro.org>2011-08-25 19:10:29 -0400
committerNicolas Pitre <nico@fluxnic.net>2011-11-18 13:51:21 -0500
commit27a3f0e91bed0f4dcf0a363e5f5938126d1ff4e5 (patch)
tree8ecb950e3b8c96cdb38ffda404571c2e375f0fcd /arch/arm/kernel
parent3e28c800440d80ede7edb21dbde61f6522d6536b (diff)
ARM: sort the meminfo array earlier
The meminfo array has to be sorted before sanity_check_meminfo() in arch/arm/mm/mmu.c is called for it to work properly. This also allows for a simpler find_limits() in arch/arm/mm/init.c. The sort is moved to arch/arm/kernel/setup.c because that's where the meminfo array is populated. Eventually this should be improved upon to make the memory bank parser a bit more robust against problems such as overlapping memory ranges. Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Diffstat (limited to 'arch/arm/kernel')
-rw-r--r--arch/arm/kernel/setup.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 7e7977ab994f..44510f879312 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -31,6 +31,7 @@
31#include <linux/memblock.h> 31#include <linux/memblock.h>
32#include <linux/bug.h> 32#include <linux/bug.h>
33#include <linux/compiler.h> 33#include <linux/compiler.h>
34#include <linux/sort.h>
34 35
35#include <asm/unified.h> 36#include <asm/unified.h>
36#include <asm/cpu.h> 37#include <asm/cpu.h>
@@ -888,6 +889,12 @@ static struct machine_desc * __init setup_machine_tags(unsigned int nr)
888 return mdesc; 889 return mdesc;
889} 890}
890 891
892static int __init meminfo_cmp(const void *_a, const void *_b)
893{
894 const struct membank *a = _a, *b = _b;
895 long cmp = bank_pfn_start(a) - bank_pfn_start(b);
896 return cmp < 0 ? -1 : cmp > 0 ? 1 : 0;
897}
891 898
892void __init setup_arch(char **cmdline_p) 899void __init setup_arch(char **cmdline_p)
893{ 900{
@@ -916,6 +923,7 @@ void __init setup_arch(char **cmdline_p)
916 923
917 parse_early_param(); 924 parse_early_param();
918 925
926 sort(&meminfo.bank, meminfo.nr_banks, sizeof(meminfo.bank[0]), meminfo_cmp, NULL);
919 sanity_check_meminfo(); 927 sanity_check_meminfo();
920 arm_memblock_init(&meminfo, mdesc); 928 arm_memblock_init(&meminfo, mdesc);
921 929