diff options
author | Ricardo Ribalda <ricardo.ribalda@gmail.com> | 2013-11-26 03:31:42 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-01-07 05:02:39 -0500 |
commit | f90580ca0133c533763a6cb3e632a21098a382df (patch) | |
tree | 05e66bbea641292153c2a78d781d49d866a16379 /Documentation | |
parent | da4a733946aa360e2219ce2d33b8d25ce4aa1959 (diff) |
[media] videodev2: Set vb2_rect's width and height as unsigned
As discussed on the media summit 2013, there is no reason for the width
and height to be signed.
Therefore this patch is an attempt to convert those fields from __s32 to
__u32.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi> (documentation and smiapp)
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'Documentation')
-rw-r--r-- | Documentation/DocBook/media/v4l/compat.xml | 12 | ||||
-rw-r--r-- | Documentation/DocBook/media/v4l/dev-overlay.xml | 9 | ||||
-rw-r--r-- | Documentation/DocBook/media/v4l/v4l2.xml | 10 | ||||
-rw-r--r-- | Documentation/DocBook/media/v4l/vidioc-cropcap.xml | 10 |
4 files changed, 27 insertions, 14 deletions
diff --git a/Documentation/DocBook/media/v4l/compat.xml b/Documentation/DocBook/media/v4l/compat.xml index 0c7195e3e093..c4cac6dbf9af 100644 --- a/Documentation/DocBook/media/v4l/compat.xml +++ b/Documentation/DocBook/media/v4l/compat.xml | |||
@@ -2523,6 +2523,18 @@ that used it. It was originally scheduled for removal in 2.6.35. | |||
2523 | </orderedlist> | 2523 | </orderedlist> |
2524 | </section> | 2524 | </section> |
2525 | 2525 | ||
2526 | <section> | ||
2527 | <title>V4L2 in Linux 3.14</title> | ||
2528 | <orderedlist> | ||
2529 | <listitem> | ||
2530 | <para> In struct <structname>v4l2_rect</structname>, the type | ||
2531 | of <structfield>width</structfield> and <structfield>height</structfield> | ||
2532 | fields changed from _s32 to _u32. | ||
2533 | </para> | ||
2534 | </listitem> | ||
2535 | </orderedlist> | ||
2536 | </section> | ||
2537 | |||
2526 | <section id="other"> | 2538 | <section id="other"> |
2527 | <title>Relation of V4L2 to other Linux multimedia APIs</title> | 2539 | <title>Relation of V4L2 to other Linux multimedia APIs</title> |
2528 | 2540 | ||
diff --git a/Documentation/DocBook/media/v4l/dev-overlay.xml b/Documentation/DocBook/media/v4l/dev-overlay.xml index 40d1d7681439..cc6e0c5c960c 100644 --- a/Documentation/DocBook/media/v4l/dev-overlay.xml +++ b/Documentation/DocBook/media/v4l/dev-overlay.xml | |||
@@ -346,17 +346,14 @@ rectangle, in pixels.</entry> | |||
346 | rectangle, in pixels. Offsets increase to the right and down.</entry> | 346 | rectangle, in pixels. Offsets increase to the right and down.</entry> |
347 | </row> | 347 | </row> |
348 | <row> | 348 | <row> |
349 | <entry>__s32</entry> | 349 | <entry>__u32</entry> |
350 | <entry><structfield>width</structfield></entry> | 350 | <entry><structfield>width</structfield></entry> |
351 | <entry>Width of the rectangle, in pixels.</entry> | 351 | <entry>Width of the rectangle, in pixels.</entry> |
352 | </row> | 352 | </row> |
353 | <row> | 353 | <row> |
354 | <entry>__s32</entry> | 354 | <entry>__u32</entry> |
355 | <entry><structfield>height</structfield></entry> | 355 | <entry><structfield>height</structfield></entry> |
356 | <entry>Height of the rectangle, in pixels. Width and | 356 | <entry>Height of the rectangle, in pixels.</entry> |
357 | height cannot be negative, the fields are signed for hysterical | ||
358 | reasons. <!-- video4linux-list@redhat.com on 22 Oct 2002 subject | ||
359 | "Re:[V4L][patches!] Re:v4l2/kernel-2.5" --></entry> | ||
360 | </row> | 357 | </row> |
361 | </tbody> | 358 | </tbody> |
362 | </tgroup> | 359 | </tgroup> |
diff --git a/Documentation/DocBook/media/v4l/v4l2.xml b/Documentation/DocBook/media/v4l/v4l2.xml index 8469fe13945c..74b7f27af71a 100644 --- a/Documentation/DocBook/media/v4l/v4l2.xml +++ b/Documentation/DocBook/media/v4l/v4l2.xml | |||
@@ -141,6 +141,14 @@ structs, ioctls) must be noted in more detail in the history chapter | |||
141 | applications. --> | 141 | applications. --> |
142 | 142 | ||
143 | <revision> | 143 | <revision> |
144 | <revnumber>3.14</revnumber> | ||
145 | <date>2013-11-25</date> | ||
146 | <authorinitials>rr</authorinitials> | ||
147 | <revremark>Set width and height as unsigned on v4l2_rect. | ||
148 | </revremark> | ||
149 | </revision> | ||
150 | |||
151 | <revision> | ||
144 | <revnumber>3.11</revnumber> | 152 | <revnumber>3.11</revnumber> |
145 | <date>2013-05-26</date> | 153 | <date>2013-05-26</date> |
146 | <authorinitials>hv</authorinitials> | 154 | <authorinitials>hv</authorinitials> |
@@ -501,7 +509,7 @@ and discussions on the V4L mailing list.</revremark> | |||
501 | </partinfo> | 509 | </partinfo> |
502 | 510 | ||
503 | <title>Video for Linux Two API Specification</title> | 511 | <title>Video for Linux Two API Specification</title> |
504 | <subtitle>Revision 3.11</subtitle> | 512 | <subtitle>Revision 3.14</subtitle> |
505 | 513 | ||
506 | <chapter id="common"> | 514 | <chapter id="common"> |
507 | &sub-common; | 515 | &sub-common; |
diff --git a/Documentation/DocBook/media/v4l/vidioc-cropcap.xml b/Documentation/DocBook/media/v4l/vidioc-cropcap.xml index bf7cc979fdfa..1f5ed64cd75a 100644 --- a/Documentation/DocBook/media/v4l/vidioc-cropcap.xml +++ b/Documentation/DocBook/media/v4l/vidioc-cropcap.xml | |||
@@ -133,18 +133,14 @@ rectangle, in pixels.</entry> | |||
133 | rectangle, in pixels.</entry> | 133 | rectangle, in pixels.</entry> |
134 | </row> | 134 | </row> |
135 | <row> | 135 | <row> |
136 | <entry>__s32</entry> | 136 | <entry>__u32</entry> |
137 | <entry><structfield>width</structfield></entry> | 137 | <entry><structfield>width</structfield></entry> |
138 | <entry>Width of the rectangle, in pixels.</entry> | 138 | <entry>Width of the rectangle, in pixels.</entry> |
139 | </row> | 139 | </row> |
140 | <row> | 140 | <row> |
141 | <entry>__s32</entry> | 141 | <entry>__u32</entry> |
142 | <entry><structfield>height</structfield></entry> | 142 | <entry><structfield>height</structfield></entry> |
143 | <entry>Height of the rectangle, in pixels. Width | 143 | <entry>Height of the rectangle, in pixels.</entry> |
144 | and height cannot be negative, the fields are signed for | ||
145 | hysterical reasons. <!-- video4linux-list@redhat.com | ||
146 | on 22 Oct 2002 subject "Re:[V4L][patches!] Re:v4l2/kernel-2.5" --> | ||
147 | </entry> | ||
148 | </row> | 144 | </row> |
149 | </tbody> | 145 | </tbody> |
150 | </tgroup> | 146 | </tgroup> |