diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-01-20 16:13:14 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-02-13 18:08:32 -0500 |
commit | 207fd32970b1def91b11ae28f6bebffc792db714 (patch) | |
tree | 75dd7d58e32b54395be26aba4381012251f65f55 /Documentation | |
parent | cd5428a5447cc6ca77ec6547d6f86834b205eac7 (diff) |
drm/fb-helper: improve kerneldoc
Now that the fbdev helper interface for drivers is trimmed down,
update the kerneldoc for all the remaining exported functions.
I've tried to beat the DocBook a bit by reordering the function
references a bit into a more sensible ordering. But that didn't work
out at all. Hence just extend the in-code DOC: section a bit.
Also remove the LOCKING: sections - especially for the setup functions
they're totally bogus. But that's not a documentation problem, but
simply an artifact of the current rather hazardous locking around drm
init and even more so around fbdev setup ...
v2: Some further improvements:
- Also add documentation for drm_fb_helper_single_add_all_connectors,
Dave Airlie didn't want me to kill this one from the fb helper
interface.
- Update docs for drm_fb_helper_fill_var/fix - they should be used
from the driver's ->fb_probe callback to setup the fbdev info
structure.
- Clarify what the ->fb_probe callback should all do - it needs to
setup both the fbdev info and allocate the drm framebuffer used as
backing storage.
- Add basic documentaation for the drm_fb_helper_funcs driver callback
vfunc.
v3: Implement clarifications Laurent Pinchart suggested in his review.
v4: Fix another mispelling Laurent spotted.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'Documentation')
-rw-r--r-- | Documentation/DocBook/drm.tmpl | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index b26de523ab70..51e1904ac4c7 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl | |||
@@ -2143,6 +2143,7 @@ void intel_crt_init(struct drm_device *dev) | |||
2143 | <title>fbdev Helper Functions Reference</title> | 2143 | <title>fbdev Helper Functions Reference</title> |
2144 | !Pdrivers/gpu/drm/drm_fb_helper.c fbdev helpers | 2144 | !Pdrivers/gpu/drm/drm_fb_helper.c fbdev helpers |
2145 | !Edrivers/gpu/drm/drm_fb_helper.c | 2145 | !Edrivers/gpu/drm/drm_fb_helper.c |
2146 | !Iinclude/drm/drm_fb_helper.h | ||
2146 | </sect2> | 2147 | </sect2> |
2147 | <sect2> | 2148 | <sect2> |
2148 | <title>Display Port Helper Functions Reference</title> | 2149 | <title>Display Port Helper Functions Reference</title> |