aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation/networking
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2013-11-13 09:32:54 -0500
committerDavid S. Miller <davem@davemloft.net>2013-11-14 16:25:14 -0500
commit98e09386c0ef4dfd48af7ba60ff908f0d525cdee (patch)
treecc572cb1114420baf8d957814bd778cf57e20d03 /Documentation/networking
parent6afae6457b3025f0b48228292a3ea92d7b30b1d4 (diff)
tcp: tsq: restore minimal amount of queueing
After commit c9eeec26e32e ("tcp: TSQ can use a dynamic limit"), several users reported throughput regressions, notably on mvneta and wifi adapters. 802.11 AMPDU requires a fair amount of queueing to be effective. This patch partially reverts the change done in tcp_write_xmit() so that the minimal amount is sysctl_tcp_limit_output_bytes. It also remove the use of this sysctl while building skb stored in write queue, as TSO autosizing does the right thing anyway. Users with well behaving NICS and correct qdisc (like sch_fq), can then lower the default sysctl_tcp_limit_output_bytes value from 128KB to 8KB. This new usage of sysctl_tcp_limit_output_bytes permits each driver authors to check how their driver performs when/if the value is set to a minimum of 4KB. Normally, line rate for a single TCP flow should be possible, but some drivers rely on timers to perform TX completion and too long TX completion delays prevent reaching full throughput. Fixes: c9eeec26e32e ("tcp: TSQ can use a dynamic limit") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Sujith Manoharan <sujith@msujith.org> Reported-by: Arnaud Ebalard <arno@natisbad.org> Tested-by: Sujith Manoharan <sujith@msujith.org> Cc: Felix Fietkau <nbd@openwrt.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/networking')
-rw-r--r--Documentation/networking/ip-sysctl.txt3
1 files changed, 0 insertions, 3 deletions
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 8b8a05787641..3c12d9a7ed00 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -577,9 +577,6 @@ tcp_limit_output_bytes - INTEGER
577 typical pfifo_fast qdiscs. 577 typical pfifo_fast qdiscs.
578 tcp_limit_output_bytes limits the number of bytes on qdisc 578 tcp_limit_output_bytes limits the number of bytes on qdisc
579 or device to reduce artificial RTT/cwnd and reduce bufferbloat. 579 or device to reduce artificial RTT/cwnd and reduce bufferbloat.
580 Note: For GSO/TSO enabled flows, we try to have at least two
581 packets in flight. Reducing tcp_limit_output_bytes might also
582 reduce the size of individual GSO packet (64KB being the max)
583 Default: 131072 580 Default: 131072
584 581
585tcp_challenge_ack_limit - INTEGER 582tcp_challenge_ack_limit - INTEGER