diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2013-12-05 17:56:54 -0500 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2014-02-17 17:55:58 -0500 |
| commit | 6e67669678d2d51b2bcf0411aeb629b4353a9880 (patch) | |
| tree | 954ea91326c4ca225a698ccb3d6e3c3f8ee4b3d0 /Documentation/RCU | |
| parent | 6d0abeca3242a88cab8232e4acd7e2bf088f3bc2 (diff) | |
documentation: Document call_rcu() safety mechanisms and limitations
The call_rcu() family of primitives will take action to accelerate
grace periods when the number of callbacks pending on a given CPU
becomes excessive. Although this safety mechanism can be useful,
it is no substitute for users of call_rcu() having rate-limit controls
in place. This commit adds this nuance to the documentation.
Reported-by: "Michael S. Tsirkin" <mst@redhat.com>
Reported-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Diffstat (limited to 'Documentation/RCU')
| -rw-r--r-- | Documentation/RCU/checklist.txt | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt index 91266193b8f4..9d10d1db16a5 100644 --- a/Documentation/RCU/checklist.txt +++ b/Documentation/RCU/checklist.txt | |||
| @@ -256,10 +256,10 @@ over a rather long period of time, but improvements are always welcome! | |||
| 256 | variations on this theme. | 256 | variations on this theme. |
| 257 | 257 | ||
| 258 | b. Limiting update rate. For example, if updates occur only | 258 | b. Limiting update rate. For example, if updates occur only |
| 259 | once per hour, then no explicit rate limiting is required, | 259 | once per hour, then no explicit rate limiting is |
| 260 | unless your system is already badly broken. The dcache | 260 | required, unless your system is already badly broken. |
| 261 | subsystem takes this approach -- updates are guarded | 261 | Older versions of the dcache subsystem take this approach, |
| 262 | by a global lock, limiting their rate. | 262 | guarding updates with a global lock, limiting their rate. |
| 263 | 263 | ||
| 264 | c. Trusted update -- if updates can only be done manually by | 264 | c. Trusted update -- if updates can only be done manually by |
| 265 | superuser or some other trusted user, then it might not | 265 | superuser or some other trusted user, then it might not |
| @@ -268,7 +268,8 @@ over a rather long period of time, but improvements are always welcome! | |||
| 268 | the machine. | 268 | the machine. |
| 269 | 269 | ||
| 270 | d. Use call_rcu_bh() rather than call_rcu(), in order to take | 270 | d. Use call_rcu_bh() rather than call_rcu(), in order to take |
| 271 | advantage of call_rcu_bh()'s faster grace periods. | 271 | advantage of call_rcu_bh()'s faster grace periods. (This |
| 272 | is only a partial solution, though.) | ||
| 272 | 273 | ||
| 273 | e. Periodically invoke synchronize_rcu(), permitting a limited | 274 | e. Periodically invoke synchronize_rcu(), permitting a limited |
| 274 | number of updates per grace period. | 275 | number of updates per grace period. |
| @@ -276,6 +277,13 @@ over a rather long period of time, but improvements are always welcome! | |||
| 276 | The same cautions apply to call_rcu_bh(), call_rcu_sched(), | 277 | The same cautions apply to call_rcu_bh(), call_rcu_sched(), |
| 277 | call_srcu(), and kfree_rcu(). | 278 | call_srcu(), and kfree_rcu(). |
| 278 | 279 | ||
| 280 | Note that although these primitives do take action to avoid memory | ||
| 281 | exhaustion when any given CPU has too many callbacks, a determined | ||
| 282 | user could still exhaust memory. This is especially the case | ||
| 283 | if a system with a large number of CPUs has been configured to | ||
| 284 | offload all of its RCU callbacks onto a single CPU, or if the | ||
| 285 | system has relatively little free memory. | ||
| 286 | |||
| 279 | 9. All RCU list-traversal primitives, which include | 287 | 9. All RCU list-traversal primitives, which include |
| 280 | rcu_dereference(), list_for_each_entry_rcu(), and | 288 | rcu_dereference(), list_for_each_entry_rcu(), and |
| 281 | list_for_each_safe_rcu(), must be either within an RCU read-side | 289 | list_for_each_safe_rcu(), must be either within an RCU read-side |
