aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation/CodingStyle
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-16 18:20:36 -0400
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-16 18:20:36 -0400
commit1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (patch)
tree0bba044c4ce775e45a88a51686b5d9f90697ea9d /Documentation/CodingStyle
Linux-2.6.12-rc2v2.6.12-rc2
Initial git repository build. I'm not bothering with the full history, even though we have it. We can create a separate "historical" git archive of that later if we want to, and in the meantime it's about 3.2GB when imported into git - space that would just make the early git days unnecessarily complicated, when we don't have a lot of good infrastructure for it. Let it rip!
Diffstat (limited to 'Documentation/CodingStyle')
-rw-r--r--Documentation/CodingStyle431
1 files changed, 431 insertions, 0 deletions
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
new file mode 100644
index 000000000000..f25b3953f513
--- /dev/null
+++ b/Documentation/CodingStyle
@@ -0,0 +1,431 @@
1
2 Linux kernel coding style
3
4This is a short document describing the preferred coding style for the
5linux kernel. Coding style is very personal, and I won't _force_ my
6views on anybody, but this is what goes for anything that I have to be
7able to maintain, and I'd prefer it for most other things too. Please
8at least consider the points made here.
9
10First off, I'd suggest printing out a copy of the GNU coding standards,
11and NOT read it. Burn them, it's a great symbolic gesture.
12
13Anyway, here goes:
14
15
16 Chapter 1: Indentation
17
18Tabs are 8 characters, and thus indentations are also 8 characters.
19There are heretic movements that try to make indentations 4 (or even 2!)
20characters deep, and that is akin to trying to define the value of PI to
21be 3.
22
23Rationale: The whole idea behind indentation is to clearly define where
24a block of control starts and ends. Especially when you've been looking
25at your screen for 20 straight hours, you'll find it a lot easier to see
26how the indentation works if you have large indentations.
27
28Now, some people will claim that having 8-character indentations makes
29the code move too far to the right, and makes it hard to read on a
3080-character terminal screen. The answer to that is that if you need
31more than 3 levels of indentation, you're screwed anyway, and should fix
32your program.
33
34In short, 8-char indents make things easier to read, and have the added
35benefit of warning you when you're nesting your functions too deep.
36Heed that warning.
37
38Don't put multiple statements on a single line unless you have
39something to hide:
40
41 if (condition) do_this;
42 do_something_everytime;
43
44Outside of comments, documentation and except in Kconfig, spaces are never
45used for indentation, and the above example is deliberately broken.
46
47Get a decent editor and don't leave whitespace at the end of lines.
48
49
50 Chapter 2: Breaking long lines and strings
51
52Coding style is all about readability and maintainability using commonly
53available tools.
54
55The limit on the length of lines is 80 columns and this is a hard limit.
56
57Statements longer than 80 columns will be broken into sensible chunks.
58Descendants are always substantially shorter than the parent and are placed
59substantially to the right. The same applies to function headers with a long
60argument list. Long strings are as well broken into shorter strings.
61
62void fun(int a, int b, int c)
63{
64 if (condition)
65 printk(KERN_WARNING "Warning this is a long printk with "
66 "3 parameters a: %u b: %u "
67 "c: %u \n", a, b, c);
68 else
69 next_statement;
70}
71
72 Chapter 3: Placing Braces
73
74The other issue that always comes up in C styling is the placement of
75braces. Unlike the indent size, there are few technical reasons to
76choose one placement strategy over the other, but the preferred way, as
77shown to us by the prophets Kernighan and Ritchie, is to put the opening
78brace last on the line, and put the closing brace first, thusly:
79
80 if (x is true) {
81 we do y
82 }
83
84However, there is one special case, namely functions: they have the
85opening brace at the beginning of the next line, thus:
86
87 int function(int x)
88 {
89 body of function
90 }
91
92Heretic people all over the world have claimed that this inconsistency
93is ... well ... inconsistent, but all right-thinking people know that
94(a) K&R are _right_ and (b) K&R are right. Besides, functions are
95special anyway (you can't nest them in C).
96
97Note that the closing brace is empty on a line of its own, _except_ in
98the cases where it is followed by a continuation of the same statement,
99ie a "while" in a do-statement or an "else" in an if-statement, like
100this:
101
102 do {
103 body of do-loop
104 } while (condition);
105
106and
107
108 if (x == y) {
109 ..
110 } else if (x > y) {
111 ...
112 } else {
113 ....
114 }
115
116Rationale: K&R.
117
118Also, note that this brace-placement also minimizes the number of empty
119(or almost empty) lines, without any loss of readability. Thus, as the
120supply of new-lines on your screen is not a renewable resource (think
12125-line terminal screens here), you have more empty lines to put
122comments on.
123
124
125 Chapter 4: Naming
126
127C is a Spartan language, and so should your naming be. Unlike Modula-2
128and Pascal programmers, C programmers do not use cute names like
129ThisVariableIsATemporaryCounter. A C programmer would call that
130variable "tmp", which is much easier to write, and not the least more
131difficult to understand.
132
133HOWEVER, while mixed-case names are frowned upon, descriptive names for
134global variables are a must. To call a global function "foo" is a
135shooting offense.
136
137GLOBAL variables (to be used only if you _really_ need them) need to
138have descriptive names, as do global functions. If you have a function
139that counts the number of active users, you should call that
140"count_active_users()" or similar, you should _not_ call it "cntusr()".
141
142Encoding the type of a function into the name (so-called Hungarian
143notation) is brain damaged - the compiler knows the types anyway and can
144check those, and it only confuses the programmer. No wonder MicroSoft
145makes buggy programs.
146
147LOCAL variable names should be short, and to the point. If you have
148some random integer loop counter, it should probably be called "i".
149Calling it "loop_counter" is non-productive, if there is no chance of it
150being mis-understood. Similarly, "tmp" can be just about any type of
151variable that is used to hold a temporary value.
152
153If you are afraid to mix up your local variable names, you have another
154problem, which is called the function-growth-hormone-imbalance syndrome.
155See next chapter.
156
157
158 Chapter 5: Functions
159
160Functions should be short and sweet, and do just one thing. They should
161fit on one or two screenfuls of text (the ISO/ANSI screen size is 80x24,
162as we all know), and do one thing and do that well.
163
164The maximum length of a function is inversely proportional to the
165complexity and indentation level of that function. So, if you have a
166conceptually simple function that is just one long (but simple)
167case-statement, where you have to do lots of small things for a lot of
168different cases, it's OK to have a longer function.
169
170However, if you have a complex function, and you suspect that a
171less-than-gifted first-year high-school student might not even
172understand what the function is all about, you should adhere to the
173maximum limits all the more closely. Use helper functions with
174descriptive names (you can ask the compiler to in-line them if you think
175it's performance-critical, and it will probably do a better job of it
176than you would have done).
177
178Another measure of the function is the number of local variables. They
179shouldn't exceed 5-10, or you're doing something wrong. Re-think the
180function, and split it into smaller pieces. A human brain can
181generally easily keep track of about 7 different things, anything more
182and it gets confused. You know you're brilliant, but maybe you'd like
183to understand what you did 2 weeks from now.
184
185
186 Chapter 6: Centralized exiting of functions
187
188Albeit deprecated by some people, the equivalent of the goto statement is
189used frequently by compilers in form of the unconditional jump instruction.
190
191The goto statement comes in handy when a function exits from multiple
192locations and some common work such as cleanup has to be done.