diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-12-12 02:36:10 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-12-13 08:30:22 -0500 |
commit | ff533fc058975579dffbb62a731f63911ae714be (patch) | |
tree | a6302e076afbc962b3ba016dfbd03d1793261e7d | |
parent | 02d62d6d17b9b718be2878477cdcae95df0d5b4e (diff) |
tools lib traceevent: Make add_left() return pevent_errno
So that it can propagate error properly.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386833777-3790-8-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/lib/traceevent/parse-filter.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index c08ce594cabe..774c3e4c1d9f 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c | |||
@@ -648,7 +648,7 @@ rotate_op_right(struct filter_arg *a, struct filter_arg *b) | |||
648 | return arg; | 648 | return arg; |
649 | } | 649 | } |
650 | 650 | ||
651 | static int add_left(struct filter_arg *op, struct filter_arg *arg) | 651 | static enum pevent_errno add_left(struct filter_arg *op, struct filter_arg *arg) |
652 | { | 652 | { |
653 | switch (op->type) { | 653 | switch (op->type) { |
654 | case FILTER_ARG_EXP: | 654 | case FILTER_ARG_EXP: |
@@ -667,11 +667,11 @@ static int add_left(struct filter_arg *op, struct filter_arg *arg) | |||
667 | /* left arg of compares must be a field */ | 667 | /* left arg of compares must be a field */ |
668 | if (arg->type != FILTER_ARG_FIELD && | 668 | if (arg->type != FILTER_ARG_FIELD && |
669 | arg->type != FILTER_ARG_BOOLEAN) | 669 | arg->type != FILTER_ARG_BOOLEAN) |
670 | return -1; | 670 | return PEVENT_ERRNO__INVALID_ARG_TYPE; |
671 | op->num.left = arg; | 671 | op->num.left = arg; |
672 | break; | 672 | break; |
673 | default: | 673 | default: |
674 | return -1; | 674 | return PEVENT_ERRNO__INVALID_ARG_TYPE; |
675 | } | 675 | } |
676 | return 0; | 676 | return 0; |
677 | } | 677 | } |