aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorImre Deak <imre.deak@nokia.com>2009-09-22 19:46:54 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-09-23 10:39:49 -0400
commitfd0eecbdfbb61076e75d34034cc5cd5ca1321a81 (patch)
treedbb3d5db754112a6be1060e6af4bde4f08f9b84a
parentc8f1c1b9e120223ab5b619ff0fc1f32c635248ad (diff)
omapfb: dispc: various typo fixes
- value and register offset was swapped in a dispc write - DISPC_CONTROL register was used instead of DISPC_SYSCONFIG - FIFO size bit field had incorrect length for OMAP3 Fixed-by: arun <arunedarath@mistralsolutions.com> Fixed-by: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com> Fixed-by: Andrzej Zaborowski <balrog@zabor.org> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Imre Deak <imre.deak@nokia.com> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/video/omap/dispc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
index 915439dc05a0..f1308aa04feb 100644
--- a/drivers/video/omap/dispc.c
+++ b/drivers/video/omap/dispc.c
@@ -286,7 +286,7 @@ static void setup_plane_fifo(int plane, int ext_mode)
286 BUG_ON(plane > 2); 286 BUG_ON(plane > 2);
287 287
288 l = dispc_read_reg(fsz_reg[plane]); 288 l = dispc_read_reg(fsz_reg[plane]);
289 l &= FLD_MASK(0, 9); 289 l &= FLD_MASK(0, 11);
290 if (ext_mode) { 290 if (ext_mode) {
291 low = l * 3 / 4; 291 low = l * 3 / 4;
292 high = l; 292 high = l;
@@ -294,7 +294,7 @@ static void setup_plane_fifo(int plane, int ext_mode)
294 low = l / 4; 294 low = l / 4;
295 high = l * 3 / 4; 295 high = l * 3 / 4;
296 } 296 }
297 MOD_REG_FLD(ftrs_reg[plane], FLD_MASK(16, 9) | FLD_MASK(0, 9), 297 MOD_REG_FLD(ftrs_reg[plane], FLD_MASK(16, 12) | FLD_MASK(0, 12),
298 (high << 16) | low); 298 (high << 16) | low);
299} 299}
300 300
@@ -1397,7 +1397,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
1397 } 1397 }
1398 1398
1399 /* Enable smart idle and autoidle */ 1399 /* Enable smart idle and autoidle */
1400 l = dispc_read_reg(DISPC_CONTROL); 1400 l = dispc_read_reg(DISPC_SYSCONFIG);
1401 l &= ~((3 << 12) | (3 << 3)); 1401 l &= ~((3 << 12) | (3 << 3));
1402 l |= (2 << 12) | (2 << 3) | (1 << 0); 1402 l |= (2 << 12) | (2 << 3) | (1 << 0);
1403 dispc_write_reg(DISPC_SYSCONFIG, l); 1403 dispc_write_reg(DISPC_SYSCONFIG, l);
@@ -1409,7 +1409,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
1409 dispc_write_reg(DISPC_CONFIG, l); 1409 dispc_write_reg(DISPC_CONFIG, l);
1410 1410
1411 l = dispc_read_reg(DISPC_IRQSTATUS); 1411 l = dispc_read_reg(DISPC_IRQSTATUS);
1412 dispc_write_reg(l, DISPC_IRQSTATUS); 1412 dispc_write_reg(DISPC_IRQSTATUS, l);
1413 1413
1414 /* Enable those that we handle always */ 1414 /* Enable those that we handle always */
1415 omap_dispc_enable_irqs(DISPC_IRQ_FRAMEMASK); 1415 omap_dispc_enable_irqs(DISPC_IRQ_FRAMEMASK);