diff options
author | Javier Martinez Canillas <javier.martinez@collabora.co.uk> | 2014-08-18 04:33:02 -0400 |
---|---|---|
committer | Mike Turquette <mturquette@linaro.org> | 2014-09-09 16:55:53 -0400 |
commit | fcd0864cdba2a93f5c51fdf06935151663f0954a (patch) | |
tree | a835da2a1481b409f8a83bf6d389ddeaf1554822 | |
parent | 1887d69308f94eec12d581b4dbab67c28274039d (diff) |
clk: max77686: Improve Maxim 77686 PMIC clocks binding
Like most clock drivers, the Maxim 77686 PMIC clock binding
follows the convention that the "#clock-cells" property is
used to specify the number of cells in a clock provider.
But the binding document is not clear enough that it shall
be set to 1 since the PMIC support multiple clocks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add "clock-output-names" as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
-rw-r--r-- | Documentation/devicetree/bindings/clock/maxim,max77686.txt | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt index 96ce71bbd745..9c40739a661a 100644 --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt | |||
@@ -9,13 +9,21 @@ The MAX77686 contains three 32.768khz clock outputs that can be controlled | |||
9 | Following properties should be presend in main device node of the MFD chip. | 9 | Following properties should be presend in main device node of the MFD chip. |
10 | 10 | ||
11 | Required properties: | 11 | Required properties: |
12 | - #clock-cells: simple one-cell clock specifier format is used, where the | 12 | |
13 | only cell is used as an index of the clock inside the provider. Following | 13 | - #clock-cells: from common clock binding; shall be set to 1. |
14 | indices are allowed: | 14 | |
15 | Optional properties: | ||
16 | - clock-output-names: From common clock binding. | ||
17 | |||
18 | Each clock is assigned an identifier and client nodes can use this identifier | ||
19 | to specify the clock which they consume. Following indices are allowed: | ||
15 | - 0: 32khz_ap clock, | 20 | - 0: 32khz_ap clock, |
16 | - 1: 32khz_cp clock, | 21 | - 1: 32khz_cp clock, |
17 | - 2: 32khz_pmic clock. | 22 | - 2: 32khz_pmic clock. |
18 | 23 | ||
24 | Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77686.h | ||
25 | header and can be used in device tree sources. | ||
26 | |||
19 | Example: Node of the MFD chip | 27 | Example: Node of the MFD chip |
20 | 28 | ||
21 | max77686: max77686@09 { | 29 | max77686: max77686@09 { |
@@ -34,5 +42,5 @@ Example: Clock consumer node | |||
34 | compatible = "bar,foo"; | 42 | compatible = "bar,foo"; |
35 | /* ... */ | 43 | /* ... */ |
36 | clock-names = "my-clock"; | 44 | clock-names = "my-clock"; |
37 | clocks = <&max77686 2>; | 45 | clocks = <&max77686 MAX77686_CLK_PMIC>; |
38 | }; | 46 | }; |