aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHante Meuleman <meuleman@broadcom.com>2014-09-11 16:51:30 -0400
committerJohn W. Linville <linville@tuxdriver.com>2014-09-15 15:09:25 -0400
commitfac7d2a3b8798f8b58004c74c4b37b9643b5897a (patch)
treead554049948e4bd472ee33c4372d83ec4436f2c3
parentae0fd6354134e63aa3e62456e2080c430287144d (diff)
brcmfmac: Fix memory leak and missing assignment.
The function brcmf_enable_bw40_2g contains a memory leak. The function is also missing initialisation of one of the members of ch struct, which can lead to warning but this has no impact on result. Reviewed-by: Arend Van Spriel <arend@broadcom.com> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by: Daniel (Deognyoun) Kim <dekim@broadcom.com> Signed-off-by: Hante Meuleman <meuleman@broadcom.com> Signed-off-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index 02fe706fc9ec..2e134a6231c1 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -5143,6 +5143,7 @@ static int brcmf_enable_bw40_2g(struct brcmf_cfg80211_info *cfg)
5143 5143
5144 ch.band = BRCMU_CHAN_BAND_2G; 5144 ch.band = BRCMU_CHAN_BAND_2G;
5145 ch.bw = BRCMU_CHAN_BW_40; 5145 ch.bw = BRCMU_CHAN_BW_40;
5146 ch.sb = BRCMU_CHAN_SB_NONE;
5146 ch.chnum = 0; 5147 ch.chnum = 0;
5147 cfg->d11inf.encchspec(&ch); 5148 cfg->d11inf.encchspec(&ch);
5148 5149
@@ -5176,6 +5177,7 @@ static int brcmf_enable_bw40_2g(struct brcmf_cfg80211_info *cfg)
5176 5177
5177 brcmf_update_bw40_channel_flag(&band->channels[j], &ch); 5178 brcmf_update_bw40_channel_flag(&band->channels[j], &ch);
5178 } 5179 }
5180 kfree(pbuf);
5179 } 5181 }
5180 return err; 5182 return err;
5181} 5183}