diff options
| author | David S. Miller <davem@davemloft.net> | 2014-08-30 00:55:22 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-01 20:39:55 -0400 |
| commit | fa2dbdc253c2aee2a760c64de454cb62469ec11d (patch) | |
| tree | ddae689033890a3fd32e01c4d022349f6cbab673 | |
| parent | 7f2e870f2a48a0524a3b03b04fa019311d16a7f7 (diff) | |
net: Pass a "more" indication down into netdev_start_xmit() code paths.
For now it will always be false.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/wan/dlci.c | 2 | ||||
| -rw-r--r-- | include/linux/netdevice.h | 9 | ||||
| -rw-r--r-- | net/atm/mpc.c | 2 | ||||
| -rw-r--r-- | net/core/dev.c | 2 | ||||
| -rw-r--r-- | net/core/netpoll.c | 2 | ||||
| -rw-r--r-- | net/core/pktgen.c | 2 | ||||
| -rw-r--r-- | net/packet/af_packet.c | 2 | ||||
| -rw-r--r-- | net/sched/sch_teql.c | 3 |
8 files changed, 13 insertions, 11 deletions
diff --git a/drivers/net/wan/dlci.c b/drivers/net/wan/dlci.c index 6427e8283419..ae6ecf401189 100644 --- a/drivers/net/wan/dlci.c +++ b/drivers/net/wan/dlci.c | |||
| @@ -194,7 +194,7 @@ static netdev_tx_t dlci_transmit(struct sk_buff *skb, struct net_device *dev) | |||
| 194 | 194 | ||
| 195 | if (skb) { | 195 | if (skb) { |
| 196 | struct netdev_queue *txq = skb_get_tx_queue(dev, skb); | 196 | struct netdev_queue *txq = skb_get_tx_queue(dev, skb); |
| 197 | netdev_start_xmit(skb, dlp->slave, txq); | 197 | netdev_start_xmit(skb, dlp->slave, txq, false); |
| 198 | } | 198 | } |
| 199 | return NETDEV_TX_OK; | 199 | return NETDEV_TX_OK; |
| 200 | } | 200 | } |
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 16171802ea7d..5050218c5b7f 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
| @@ -3431,19 +3431,20 @@ int __init dev_proc_init(void); | |||
| 3431 | #endif | 3431 | #endif |
| 3432 | 3432 | ||
| 3433 | static inline netdev_tx_t __netdev_start_xmit(const struct net_device_ops *ops, | 3433 | static inline netdev_tx_t __netdev_start_xmit(const struct net_device_ops *ops, |
| 3434 | struct sk_buff *skb, struct net_device *dev) | 3434 | struct sk_buff *skb, struct net_device *dev, |
| 3435 | bool more) | ||
| 3435 | { | 3436 | { |
| 3436 | skb->xmit_more = 0; | 3437 | skb->xmit_more = more ? 1 : 0; |
| 3437 | return ops->ndo_start_xmit(skb, dev); | 3438 | return ops->ndo_start_xmit(skb, dev); |
| 3438 | } | 3439 | } |
| 3439 | 3440 | ||
| 3440 | static inline netdev_tx_t netdev_start_xmit(struct sk_buff *skb, struct net_device *dev, | 3441 | static inline netdev_tx_t netdev_start_xmit(struct sk_buff *skb, struct net_device *dev, |
| 3441 | struct netdev_queue *txq) | 3442 | struct netdev_queue *txq, bool more) |
| 3442 | { | 3443 | { |
| 3443 | const struct net_device_ops *ops = dev->netdev_ops; | 3444 | const struct net_device_ops *ops = dev->netdev_ops; |
| 3444 | int rc; | 3445 | int rc; |
| 3445 | 3446 | ||
| 3446 | rc = __netdev_start_xmit(ops, skb, dev); | 3447 | rc = __netdev_start_xmit(ops, skb, dev, more); |
| 3447 | if (rc == NETDEV_TX_OK) | 3448 | if (rc == NETDEV_TX_OK) |
| 3448 | txq_trans_update(txq); | 3449 | txq_trans_update(txq); |
| 3449 | 3450 | ||
diff --git a/net/atm/mpc.c b/net/atm/mpc.c index d662da161e5a..0e982222d425 100644 --- a/net/atm/mpc.c +++ b/net/atm/mpc.c | |||
| @@ -599,7 +599,7 @@ static netdev_tx_t mpc_send_packet(struct sk_buff *skb, | |||
| 599 | } | 599 | } |
| 600 | 600 | ||
| 601 | non_ip: | 601 | non_ip: |
| 602 | return __netdev_start_xmit(mpc->old_ops, skb, dev); | 602 | return __netdev_start_xmit(mpc->old_ops, skb, dev, false); |
| 603 | } | 603 | } |
| 604 | 604 | ||
| 605 | static int atm_mpoa_vcc_attach(struct atm_vcc *vcc, void __user *arg) | 605 | static int atm_mpoa_vcc_attach(struct atm_vcc *vcc, void __user *arg) |
diff --git a/net/core/dev.c b/net/core/dev.c index ab7bb809711e..f0ed5a611a97 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -2610,7 +2610,7 @@ static int xmit_one(struct sk_buff *skb, struct net_device *dev, | |||
| 2610 | 2610 | ||
| 2611 | len = skb->len; | 2611 | len = skb->len; |
| 2612 | trace_net_dev_start_xmit(skb, dev); | 2612 | trace_net_dev_start_xmit(skb, dev); |
| 2613 | rc = netdev_start_xmit(skb, dev, txq); | 2613 | rc = netdev_start_xmit(skb, dev, txq, false); |
| 2614 | trace_net_dev_xmit(skb, rc, dev, len); | 2614 | trace_net_dev_xmit(skb, rc, dev, len); |
| 2615 | 2615 | ||
| 2616 | return rc; | 2616 | return rc; |
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 05bc57edaa81..e6645b4f330a 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c | |||
| @@ -91,7 +91,7 @@ static int netpoll_start_xmit(struct sk_buff *skb, struct net_device *dev, | |||
| 91 | skb->vlan_tci = 0; | 91 | skb->vlan_tci = 0; |
| 92 | } | 92 | } |
| 93 | 93 | ||
| 94 | status = netdev_start_xmit(skb, dev, txq); | 94 | status = netdev_start_xmit(skb, dev, txq, false); |
| 95 | 95 | ||
| 96 | out: | 96 | out: |
| 97 | return status; | 97 | return status; |
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 34bd2ff9f121..5b36a9428c59 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c | |||
| @@ -3335,7 +3335,7 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev) | |||
| 3335 | goto unlock; | 3335 | goto unlock; |
| 3336 | } | 3336 | } |
| 3337 | atomic_inc(&(pkt_dev->skb->users)); | 3337 | atomic_inc(&(pkt_dev->skb->users)); |
| 3338 | ret = netdev_start_xmit(pkt_dev->skb, odev, txq); | 3338 | ret = netdev_start_xmit(pkt_dev->skb, odev, txq, false); |
| 3339 | 3339 | ||
| 3340 | switch (ret) { | 3340 | switch (ret) { |
| 3341 | case NETDEV_TX_OK: | 3341 | case NETDEV_TX_OK: |
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index fe305a05a8fc..87d20f48ff06 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c | |||
| @@ -259,7 +259,7 @@ static int packet_direct_xmit(struct sk_buff *skb) | |||
| 259 | 259 | ||
| 260 | HARD_TX_LOCK(dev, txq, smp_processor_id()); | 260 | HARD_TX_LOCK(dev, txq, smp_processor_id()); |
| 261 | if (!netif_xmit_frozen_or_drv_stopped(txq)) | 261 | if (!netif_xmit_frozen_or_drv_stopped(txq)) |
| 262 | ret = netdev_start_xmit(skb, dev, txq); | 262 | ret = netdev_start_xmit(skb, dev, txq, false); |
| 263 | HARD_TX_UNLOCK(dev, txq); | 263 | HARD_TX_UNLOCK(dev, txq); |
| 264 | 264 | ||
| 265 | local_bh_enable(); | 265 | local_bh_enable(); |
diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index 193dc2cba1ec..aaa8d03ed054 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c | |||
| @@ -316,7 +316,8 @@ restart: | |||
| 316 | unsigned int length = qdisc_pkt_len(skb); | 316 | unsigned int length = qdisc_pkt_len(skb); |
| 317 | 317 | ||
| 318 | if (!netif_xmit_frozen_or_stopped(slave_txq) && | 318 | if (!netif_xmit_frozen_or_stopped(slave_txq) && |
| 319 | netdev_start_xmit(skb, slave, slave_txq) == NETDEV_TX_OK) { | 319 | netdev_start_xmit(skb, slave, slave_txq, false) == |
| 320 | NETDEV_TX_OK) { | ||
| 320 | __netif_tx_unlock(slave_txq); | 321 | __netif_tx_unlock(slave_txq); |
| 321 | master->slaves = NEXT_SLAVE(q); | 322 | master->slaves = NEXT_SLAVE(q); |
| 322 | netif_wake_queue(dev); | 323 | netif_wake_queue(dev); |
