aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndi Kleen <ak@linux.intel.com>2013-07-18 18:58:53 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-07-22 15:58:28 -0400
commitf9ea55d0ddf66ed030b2a478625cd5792d30df16 (patch)
tree2295c78a1e3a26809d2fee9e2285d17aa3eff452
parentdbad41893c7941f3c53805f8206993719f971bfa (diff)
perf tools: Move weight back to common sort keys
This is a partial revert of Namhyung's patch afab87b91f3f331d55664172dad8e476e6ffca9d perf sort: Separate out memory-specific sort keys He wrote For global/local weights, I'm not entirely sure to place them into the memory dimension. But it's the only user at this time. Well TSX is another (in fact the original) user of the flags, and it needs them to be common. So move local/global weight back to the common sort keys. Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Link: http://lkml.kernel.org/r/1374188333-17899-1-git-send-email-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/sort.c4
-rw-r--r--tools/perf/util/sort.h6
2 files changed, 5 insertions, 5 deletions
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index cb2b108635ee..5f118a089519 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -874,6 +874,8 @@ static struct sort_dimension common_sort_dimensions[] = {
874 DIM(SORT_PARENT, "parent", sort_parent), 874 DIM(SORT_PARENT, "parent", sort_parent),
875 DIM(SORT_CPU, "cpu", sort_cpu), 875 DIM(SORT_CPU, "cpu", sort_cpu),
876 DIM(SORT_SRCLINE, "srcline", sort_srcline), 876 DIM(SORT_SRCLINE, "srcline", sort_srcline),
877 DIM(SORT_LOCAL_WEIGHT, "local_weight", sort_local_weight),
878 DIM(SORT_GLOBAL_WEIGHT, "weight", sort_global_weight),
877}; 879};
878 880
879#undef DIM 881#undef DIM
@@ -893,8 +895,6 @@ static struct sort_dimension bstack_sort_dimensions[] = {
893#define DIM(d, n, func) [d - __SORT_MEMORY_MODE] = { .name = n, .entry = &(func) } 895#define DIM(d, n, func) [d - __SORT_MEMORY_MODE] = { .name = n, .entry = &(func) }
894 896
895static struct sort_dimension memory_sort_dimensions[] = { 897static struct sort_dimension memory_sort_dimensions[] = {
896 DIM(SORT_LOCAL_WEIGHT, "local_weight", sort_local_weight),
897 DIM(SORT_GLOBAL_WEIGHT, "weight", sort_global_weight),
898 DIM(SORT_MEM_DADDR_SYMBOL, "symbol_daddr", sort_mem_daddr_sym), 898 DIM(SORT_MEM_DADDR_SYMBOL, "symbol_daddr", sort_mem_daddr_sym),
899 DIM(SORT_MEM_DADDR_DSO, "dso_daddr", sort_mem_daddr_dso), 899 DIM(SORT_MEM_DADDR_DSO, "dso_daddr", sort_mem_daddr_dso),
900 DIM(SORT_MEM_LOCKED, "locked", sort_mem_locked), 900 DIM(SORT_MEM_LOCKED, "locked", sort_mem_locked),
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 586022dc3264..4e80dbd271e7 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -143,6 +143,8 @@ enum sort_type {
143 SORT_PARENT, 143 SORT_PARENT,
144 SORT_CPU, 144 SORT_CPU,
145 SORT_SRCLINE, 145 SORT_SRCLINE,
146 SORT_LOCAL_WEIGHT,
147 SORT_GLOBAL_WEIGHT,
146 148
147 /* branch stack specific sort keys */ 149 /* branch stack specific sort keys */
148 __SORT_BRANCH_STACK, 150 __SORT_BRANCH_STACK,
@@ -154,9 +156,7 @@ enum sort_type {
154 156
155 /* memory mode specific sort keys */ 157 /* memory mode specific sort keys */
156 __SORT_MEMORY_MODE, 158 __SORT_MEMORY_MODE,
157 SORT_LOCAL_WEIGHT = __SORT_MEMORY_MODE, 159 SORT_MEM_DADDR_SYMBOL = __SORT_MEMORY_MODE,
158 SORT_GLOBAL_WEIGHT,
159 SORT_MEM_DADDR_SYMBOL,
160 SORT_MEM_DADDR_DSO, 160 SORT_MEM_DADDR_DSO,
161 SORT_MEM_LOCKED, 161 SORT_MEM_LOCKED,
162 SORT_MEM_TLB, 162 SORT_MEM_TLB,