diff options
author | Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> | 2013-09-11 17:20:36 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:57:19 -0400 |
commit | f92310c1877fc73470bdcd9228758fa3713c191b (patch) | |
tree | 9178b722246f411a60986047784f85d4a83376a9 | |
parent | fef903efcf0cb9721f3f2da719daec9bbc26f12b (diff) |
mm/page_alloc.c: fix the value of fallback_migratetype in alloc_extfrag tracepoint()
In the current code, the value of fallback_migratetype that is printed
using the mm_page_alloc_extfrag tracepoint, is the value of the
migratetype *after* it has been set to the preferred migratetype (if the
ownership was changed). Obviously that wouldn't have been the original
intent. (We already have a separate 'change_ownership' field to tell
whether the ownership of the pageblock was changed from the
fallback_migratetype to the preferred type.)
The intent of the fallback_migratetype field is to show the migratetype
from which we borrowed pages in order to satisfy the allocation request.
So fix the code to print that value correctly.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Cody P Schafer <cody@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/trace/events/kmem.h | 10 | ||||
-rw-r--r-- | mm/page_alloc.c | 5 |
2 files changed, 10 insertions, 5 deletions
diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h index 6bc943ecb841..d0c613476620 100644 --- a/include/trace/events/kmem.h +++ b/include/trace/events/kmem.h | |||
@@ -268,11 +268,13 @@ TRACE_EVENT(mm_page_alloc_extfrag, | |||
268 | 268 | ||
269 | TP_PROTO(struct page *page, | 269 | TP_PROTO(struct page *page, |
270 | int alloc_order, int fallback_order, | 270 | int alloc_order, int fallback_order, |
271 | int alloc_migratetype, int fallback_migratetype), | 271 | int alloc_migratetype, int fallback_migratetype, |
272 | int change_ownership), | ||
272 | 273 | ||
273 | TP_ARGS(page, | 274 | TP_ARGS(page, |
274 | alloc_order, fallback_order, | 275 | alloc_order, fallback_order, |
275 | alloc_migratetype, fallback_migratetype), | 276 | alloc_migratetype, fallback_migratetype, |
277 | change_ownership), | ||
276 | 278 | ||
277 | TP_STRUCT__entry( | 279 | TP_STRUCT__entry( |
278 | __field( struct page *, page ) | 280 | __field( struct page *, page ) |
@@ -280,6 +282,7 @@ TRACE_EVENT(mm_page_alloc_extfrag, | |||
280 | __field( int, fallback_order ) | 282 | __field( int, fallback_order ) |
281 | __field( int, alloc_migratetype ) | 283 | __field( int, alloc_migratetype ) |
282 | __field( int, fallback_migratetype ) | 284 | __field( int, fallback_migratetype ) |
285 | __field( int, change_ownership ) | ||
283 | ), | 286 | ), |
284 | 287 | ||
285 | TP_fast_assign( | 288 | TP_fast_assign( |
@@ -288,6 +291,7 @@ TRACE_EVENT(mm_page_alloc_extfrag, | |||
288 | __entry->fallback_order = fallback_order; | 291 | __entry->fallback_order = fallback_order; |
289 | __entry->alloc_migratetype = alloc_migratetype; | 292 | __entry->alloc_migratetype = alloc_migratetype; |
290 | __entry->fallback_migratetype = fallback_migratetype; | 293 | __entry->fallback_migratetype = fallback_migratetype; |
294 | __entry->change_ownership = change_ownership; | ||
291 | ), | 295 | ), |
292 | 296 | ||
293 | TP_printk("page=%p pfn=%lu alloc_order=%d fallback_order=%d pageblock_order=%d alloc_migratetype=%d fallback_migratetype=%d fragmenting=%d change_ownership=%d", | 297 | TP_printk("page=%p pfn=%lu alloc_order=%d fallback_order=%d pageblock_order=%d alloc_migratetype=%d fallback_migratetype=%d fragmenting=%d change_ownership=%d", |
@@ -299,7 +303,7 @@ TRACE_EVENT(mm_page_alloc_extfrag, | |||
299 | __entry->alloc_migratetype, | 303 | __entry->alloc_migratetype, |
300 | __entry->fallback_migratetype, | 304 | __entry->fallback_migratetype, |
301 | __entry->fallback_order < pageblock_order, | 305 | __entry->fallback_order < pageblock_order, |
302 | __entry->alloc_migratetype == __entry->fallback_migratetype) | 306 | __entry->change_ownership) |
303 | ); | 307 | ); |
304 | 308 | ||
305 | #endif /* _TRACE_KMEM_H */ | 309 | #endif /* _TRACE_KMEM_H */ |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b09ce5fe0cd2..2748fc6a9003 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -1101,8 +1101,9 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype) | |||
1101 | is_migrate_cma(migratetype) | 1101 | is_migrate_cma(migratetype) |
1102 | ? migratetype : start_migratetype); | 1102 | ? migratetype : start_migratetype); |
1103 | 1103 | ||
1104 | trace_mm_page_alloc_extfrag(page, order, current_order, | 1104 | trace_mm_page_alloc_extfrag(page, order, |
1105 | start_migratetype, new_type); | 1105 | current_order, start_migratetype, migratetype, |
1106 | new_type == start_migratetype); | ||
1106 | 1107 | ||
1107 | return page; | 1108 | return page; |
1108 | } | 1109 | } |