aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-08-06 19:11:31 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-06 21:01:29 -0400
commitf84223087402c45179be5e7060c5736c17a7b271 (patch)
tree98363ff18f61ff016970a110d49d27fb0b81399d
parentece9659f16e369d344fe4325d87fab3bb50d1fe2 (diff)
checkpatch: update $declaration_macros, add uninitialized_var
Using uninitialized_var reports a false positive for "Missing blank line after declarations". Fix it by adding uninitialized_var to the $declaration_macros exceptions list. Move the macro list after $Type is declared. Add optional prefixes to DECLARE_<FOO> and DEFINE_<BAR> macro declarations to allow forms like: MLX4_DECLARE_DOORBELL_LOCK Signed-off-by: Joe Perches <joe@perches.com> Reported-by: Dotan Barak <dotanb@mellanox.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-xscripts/checkpatch.pl11
1 files changed, 6 insertions, 5 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index da74e65064d1..31a731e06f50 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -423,11 +423,6 @@ foreach my $entry (@mode_permission_funcs) {
423 $mode_perms_search .= $entry->[0]; 423 $mode_perms_search .= $entry->[0];
424} 424}
425 425
426our $declaration_macros = qr{(?x:
427 (?:$Storage\s+)?(?:DECLARE|DEFINE)_[A-Z]+\s*\(|
428 (?:$Storage\s+)?LIST_HEAD\s*\(
429)};
430
431our $allowed_asm_includes = qr{(?x: 426our $allowed_asm_includes = qr{(?x:
432 irq| 427 irq|
433 memory 428 memory
@@ -490,6 +485,12 @@ our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
490our $LvalOrFunc = qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*}; 485our $LvalOrFunc = qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*};
491our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)}; 486our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
492 487
488our $declaration_macros = qr{(?x:
489 (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,2}\s*\(|
490 (?:$Storage\s+)?LIST_HEAD\s*\(|
491 (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
492)};
493
493sub deparenthesize { 494sub deparenthesize {
494 my ($string) = @_; 495 my ($string) = @_;
495 return "" if (!defined($string)); 496 return "" if (!defined($string));