aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Herrmann <dh.herrmann@gmail.com>2013-08-14 09:07:17 -0400
committerDave Airlie <airlied@redhat.com>2013-08-18 19:34:41 -0400
commitf547b22aaf4f429089b3d5a987b94a2bd8c92eb1 (patch)
treefda421826aebb80b275b8f46bea98305297abe76
parent23a9a2e075fa4a8a46575977ed2cc531424a6d2c (diff)
drm/qxl: remove unused object_pin/unpin() helpers
These two helpers are unused. Remove them. They rely on gem_obj->driver_private, which is set to NULL during setup. As this field isn't used by the driver, anymore, we can remove this assignment as well. Signed-off-by: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
-rw-r--r--drivers/gpu/drm/qxl/qxl_drv.h3
-rw-r--r--drivers/gpu/drm/qxl/qxl_gem.c26
-rw-r--r--drivers/gpu/drm/qxl/qxl_object.c1
3 files changed, 0 insertions, 30 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 4708621fe720..f7c9adde46a0 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -405,9 +405,6 @@ int qxl_gem_object_create(struct qxl_device *qdev, int size,
405 bool discardable, bool kernel, 405 bool discardable, bool kernel,
406 struct qxl_surface *surf, 406 struct qxl_surface *surf,
407 struct drm_gem_object **obj); 407 struct drm_gem_object **obj);
408int qxl_gem_object_pin(struct drm_gem_object *obj, uint32_t pin_domain,
409 uint64_t *gpu_addr);
410void qxl_gem_object_unpin(struct drm_gem_object *obj);
411int qxl_gem_object_create_with_handle(struct qxl_device *qdev, 408int qxl_gem_object_create_with_handle(struct qxl_device *qdev,
412 struct drm_file *file_priv, 409 struct drm_file *file_priv,
413 u32 domain, 410 u32 domain,
diff --git a/drivers/gpu/drm/qxl/qxl_gem.c b/drivers/gpu/drm/qxl/qxl_gem.c
index 25e1777fb0a2..1648e4125af7 100644
--- a/drivers/gpu/drm/qxl/qxl_gem.c
+++ b/drivers/gpu/drm/qxl/qxl_gem.c
@@ -101,32 +101,6 @@ int qxl_gem_object_create_with_handle(struct qxl_device *qdev,
101 return 0; 101 return 0;
102} 102}
103 103
104int qxl_gem_object_pin(struct drm_gem_object *obj, uint32_t pin_domain,
105 uint64_t *gpu_addr)
106{
107 struct qxl_bo *qobj = obj->driver_private;
108 int r;
109
110 r = qxl_bo_reserve(qobj, false);
111 if (unlikely(r != 0))
112 return r;
113 r = qxl_bo_pin(qobj, pin_domain, gpu_addr);
114 qxl_bo_unreserve(qobj);
115 return r;
116}
117
118void qxl_gem_object_unpin(struct drm_gem_object *obj)
119{
120 struct qxl_bo *qobj = obj->driver_private;
121 int r;
122
123 r = qxl_bo_reserve(qobj, false);
124 if (likely(r == 0)) {
125 qxl_bo_unpin(qobj);
126 qxl_bo_unreserve(qobj);
127 }
128}
129
130int qxl_gem_object_open(struct drm_gem_object *obj, struct drm_file *file_priv) 104int qxl_gem_object_open(struct drm_gem_object *obj, struct drm_file *file_priv)
131{ 105{
132 return 0; 106 return 0;
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index aa161cddd87e..8691c76c5ef0 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -98,7 +98,6 @@ int qxl_bo_create(struct qxl_device *qdev,
98 kfree(bo); 98 kfree(bo);
99 return r; 99 return r;
100 } 100 }
101 bo->gem_base.driver_private = NULL;
102 bo->type = domain; 101 bo->type = domain;
103 bo->pin_count = pinned ? 1 : 0; 102 bo->pin_count = pinned ? 1 : 0;
104 bo->surface_id = 0; 103 bo->surface_id = 0;