diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-12 01:04:50 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-13 20:33:00 -0400 |
| commit | f331e40ee8e4861e1d82310b1af7cf75de7370ac (patch) | |
| tree | 630dccab66fb5cbc3ba4a3968cabb5855956a8d9 | |
| parent | 6188a83f7264edebe9b8ee10ad7b2136d3531ea6 (diff) | |
USB: serial: remove CONFIG_USB_DEBUG from sierra and option drivers
These drivers should not be relying on CONFIG_USB_DEBUG. By doing this,
it prevents users of kernels that do not enable this option from
enabling debugging in these drivers, unlike all other usb-serial
drivers.
Cc: Matthias Urlichs <smurf@smurf.noris.de>
Cc: Kevin Lloyd <klloyd@sierrawireless.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/serial/option.c | 7 | ||||
| -rw-r--r-- | drivers/usb/serial/sierra.c | 2 |
2 files changed, 0 insertions, 9 deletions
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index df472c7480a0..e143198aeb02 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c | |||
| @@ -383,11 +383,7 @@ static struct usb_serial_driver option_1port_device = { | |||
| 383 | .read_int_callback = option_instat_callback, | 383 | .read_int_callback = option_instat_callback, |
| 384 | }; | 384 | }; |
| 385 | 385 | ||
| 386 | #ifdef CONFIG_USB_DEBUG | ||
| 387 | static int debug; | 386 | static int debug; |
| 388 | #else | ||
| 389 | #define debug 0 | ||
| 390 | #endif | ||
| 391 | 387 | ||
| 392 | /* per port private data */ | 388 | /* per port private data */ |
| 393 | 389 | ||
| @@ -991,8 +987,5 @@ MODULE_DESCRIPTION(DRIVER_DESC); | |||
| 991 | MODULE_VERSION(DRIVER_VERSION); | 987 | MODULE_VERSION(DRIVER_VERSION); |
| 992 | MODULE_LICENSE("GPL"); | 988 | MODULE_LICENSE("GPL"); |
| 993 | 989 | ||
| 994 | #ifdef CONFIG_USB_DEBUG | ||
| 995 | module_param(debug, bool, S_IRUGO | S_IWUSR); | 990 | module_param(debug, bool, S_IRUGO | S_IWUSR); |
| 996 | MODULE_PARM_DESC(debug, "Debug messages"); | 991 | MODULE_PARM_DESC(debug, "Debug messages"); |
| 997 | #endif | ||
| 998 | |||
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 6b7ed333386a..706033753adb 100644 --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c | |||
| @@ -766,7 +766,5 @@ MODULE_LICENSE("GPL"); | |||
| 766 | module_param(nmea, bool, S_IRUGO | S_IWUSR); | 766 | module_param(nmea, bool, S_IRUGO | S_IWUSR); |
| 767 | MODULE_PARM_DESC(nmea, "NMEA streaming"); | 767 | MODULE_PARM_DESC(nmea, "NMEA streaming"); |
| 768 | 768 | ||
| 769 | #ifdef CONFIG_USB_DEBUG | ||
| 770 | module_param(debug, bool, S_IRUGO | S_IWUSR); | 769 | module_param(debug, bool, S_IRUGO | S_IWUSR); |
| 771 | MODULE_PARM_DESC(debug, "Debug messages"); | 770 | MODULE_PARM_DESC(debug, "Debug messages"); |
| 772 | #endif | ||
