diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2014-03-14 16:34:22 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-03-14 16:36:48 -0400 |
commit | f2bb31057a42cb439161066db615ca73e4438e30 (patch) | |
tree | afd2f5399cbcb4d64b933ff72d8ba90099d838c3 | |
parent | f9f4cbde587335515acaaef9e23028fc0a616292 (diff) |
spi: efm32: properly namespace location property
While reviewing an i2c driver for efm32 that needs a similar property
Wolfram Sang pointed out that "location" is a too generic name for
something that is efm32 specific. So add an appropriate namespace and
fall back to the generic name in case of failure.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r-- | Documentation/devicetree/bindings/spi/efm32-spi.txt | 4 | ||||
-rw-r--r-- | drivers/spi/spi-efm32.c | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt index a590ca51be75..25c02ba530da 100644 --- a/Documentation/devicetree/bindings/spi/efm32-spi.txt +++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt | |||
@@ -8,7 +8,7 @@ Required properties: | |||
8 | - interrupts: pair specifying rx and tx irq | 8 | - interrupts: pair specifying rx and tx irq |
9 | - clocks: phandle to the spi clock | 9 | - clocks: phandle to the spi clock |
10 | - cs-gpios: see spi-bus.txt | 10 | - cs-gpios: see spi-bus.txt |
11 | - location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values. | 11 | - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values. |
12 | 12 | ||
13 | Example: | 13 | Example: |
14 | 14 | ||
@@ -20,7 +20,7 @@ spi1: spi@0x4000c400 { /* USART1 */ | |||
20 | interrupts = <15 16>; | 20 | interrupts = <15 16>; |
21 | clocks = <&cmu 20>; | 21 | clocks = <&cmu 20>; |
22 | cs-gpios = <&gpio 51 1>; // D3 | 22 | cs-gpios = <&gpio 51 1>; // D3 |
23 | location = <1>; | 23 | efm32,location = <1>; |
24 | status = "ok"; | 24 | status = "ok"; |
25 | 25 | ||
26 | ks8851@0 { | 26 | ks8851@0 { |
diff --git a/drivers/spi/spi-efm32.c b/drivers/spi/spi-efm32.c index 0512fedf1f13..fdb6fce0530b 100644 --- a/drivers/spi/spi-efm32.c +++ b/drivers/spi/spi-efm32.c | |||
@@ -294,7 +294,10 @@ static void efm32_spi_probe_dt(struct platform_device *pdev, | |||
294 | u32 location; | 294 | u32 location; |
295 | int ret; | 295 | int ret; |
296 | 296 | ||
297 | ret = of_property_read_u32(np, "location", &location); | 297 | ret = of_property_read_u32(np, "efm32,location", &location); |
298 | if (ret) | ||
299 | /* fall back to old and (wrongly) generic property "location" */ | ||
300 | ret = of_property_read_u32(np, "location", &location); | ||
298 | if (!ret) { | 301 | if (!ret) { |
299 | dev_dbg(&pdev->dev, "using location %u\n", location); | 302 | dev_dbg(&pdev->dev, "using location %u\n", location); |
300 | } else { | 303 | } else { |