diff options
author | Larry Finger <Larry.Finger@lwfinger.net> | 2014-12-18 04:05:31 -0500 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2014-12-24 11:30:54 -0500 |
commit | f1f21770b11ca83d688b2791b163c2b892ca6fa6 (patch) | |
tree | 0c0947aec8d464ed8a8aef3b43f27cc6abc05634 | |
parent | 99057920a2f7360977979dc4c2ba60d5f9dc9e23 (diff) |
rtlwifi: Remove extraneous argument for rate mapping
Four of the drivers (92ce, 92cu, 92de, and 92se) supply an argument to the
rate-mapping routine that is never used, thus it can be removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
-rw-r--r-- | drivers/net/wireless/rtlwifi/base.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/base.h | 2 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 5 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 6 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 3 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 11 |
6 files changed, 12 insertions, 17 deletions
diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c index 40b6d1d006d7..d4c8e95f22de 100644 --- a/drivers/net/wireless/rtlwifi/base.c +++ b/drivers/net/wireless/rtlwifi/base.c | |||
@@ -883,7 +883,7 @@ static u8 _rtl_get_highest_n_rate(struct ieee80211_hw *hw, | |||
883 | * DESC92_RATEMCS0-->DESC92_RATEMCS15 ==> idx is 0-->15 | 883 | * DESC92_RATEMCS0-->DESC92_RATEMCS15 ==> idx is 0-->15 |
884 | */ | 884 | */ |
885 | int rtlwifi_rate_mapping(struct ieee80211_hw *hw, | 885 | int rtlwifi_rate_mapping(struct ieee80211_hw *hw, |
886 | bool isht, u8 desc_rate, bool first_ampdu) | 886 | bool isht, u8 desc_rate) |
887 | { | 887 | { |
888 | int rate_idx; | 888 | int rate_idx; |
889 | 889 | ||
diff --git a/drivers/net/wireless/rtlwifi/base.h b/drivers/net/wireless/rtlwifi/base.h index 982f2450feea..936c2bba54d4 100644 --- a/drivers/net/wireless/rtlwifi/base.h +++ b/drivers/net/wireless/rtlwifi/base.h | |||
@@ -124,7 +124,7 @@ void rtl_deinit_deferred_work(struct ieee80211_hw *hw); | |||
124 | 124 | ||
125 | bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx); | 125 | bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx); |
126 | int rtlwifi_rate_mapping(struct ieee80211_hw *hw, | 126 | int rtlwifi_rate_mapping(struct ieee80211_hw *hw, |
127 | bool isht, u8 desc_rate, bool first_ampdu); | 127 | bool isht, u8 desc_rate); |
128 | bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb); | 128 | bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb); |
129 | u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx); | 129 | u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx); |
130 | 130 | ||
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c index e88dcd0e0af1..d25aeeb60b09 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | |||
@@ -400,9 +400,8 @@ bool rtl92ce_rx_query_desc(struct ieee80211_hw *hw, | |||
400 | * are use (RX_FLAG_HT) | 400 | * are use (RX_FLAG_HT) |
401 | * Notice: this is diff with windows define | 401 | * Notice: this is diff with windows define |
402 | */ | 402 | */ |
403 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, | 403 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, stats->is_ht, |
404 | stats->is_ht, stats->rate, | 404 | stats->rate); |
405 | stats->isfirst_ampdu); | ||
406 | 405 | ||
407 | rx_status->mactime = stats->timestamp_low; | 406 | rx_status->mactime = stats->timestamp_low; |
408 | if (phystatus) { | 407 | if (phystatus) { |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c index f383d5f1fed5..fa30b260e5ba 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | |||
@@ -340,8 +340,7 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw, | |||
340 | rx_status->flag |= RX_FLAG_DECRYPTED; | 340 | rx_status->flag |= RX_FLAG_DECRYPTED; |
341 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, | 341 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, |
342 | (bool)GET_RX_DESC_RX_HT(pdesc), | 342 | (bool)GET_RX_DESC_RX_HT(pdesc), |
343 | (u8)GET_RX_DESC_RX_MCS(pdesc), | 343 | (u8)GET_RX_DESC_RX_MCS(pdesc)); |
344 | (bool)GET_RX_DESC_PAGGR(pdesc)); | ||
345 | rx_status->mactime = GET_RX_DESC_TSFL(pdesc); | 344 | rx_status->mactime = GET_RX_DESC_TSFL(pdesc); |
346 | if (phystatus) { | 345 | if (phystatus) { |
347 | p_drvinfo = (struct rx_fwinfo_92c *)(skb->data + | 346 | p_drvinfo = (struct rx_fwinfo_92c *)(skb->data + |
@@ -408,8 +407,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb) | |||
408 | /* Data rate */ | 407 | /* Data rate */ |
409 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, | 408 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, |
410 | (bool)GET_RX_DESC_RX_HT(rxdesc), | 409 | (bool)GET_RX_DESC_RX_HT(rxdesc), |
411 | (u8)GET_RX_DESC_RX_MCS(rxdesc), | 410 | (u8)GET_RX_DESC_RX_MCS(rxdesc)); |
412 | (bool)GET_RX_DESC_PAGGR(rxdesc)); | ||
413 | /* There is a phy status after this rx descriptor. */ | 411 | /* There is a phy status after this rx descriptor. */ |
414 | if (GET_RX_DESC_PHY_STATUS(rxdesc)) { | 412 | if (GET_RX_DESC_PHY_STATUS(rxdesc)) { |
415 | p_drvinfo = (struct rx_fwinfo_92c *)(rxdesc + RTL_RX_DESC_SIZE); | 413 | p_drvinfo = (struct rx_fwinfo_92c *)(rxdesc + RTL_RX_DESC_SIZE); |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c index 8efbcc7af250..7fbae49b53b6 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c | |||
@@ -514,8 +514,7 @@ bool rtl92de_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats, | |||
514 | rx_status->flag |= RX_FLAG_DECRYPTED; | 514 | rx_status->flag |= RX_FLAG_DECRYPTED; |
515 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, | 515 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, |
516 | (bool)GET_RX_DESC_RXHT(pdesc), | 516 | (bool)GET_RX_DESC_RXHT(pdesc), |
517 | (u8)GET_RX_DESC_RXMCS(pdesc), | 517 | (u8)GET_RX_DESC_RXMCS(pdesc)); |
518 | (bool)GET_RX_DESC_PAGGR(pdesc)); | ||
519 | rx_status->mactime = GET_RX_DESC_TSFL(pdesc); | 518 | rx_status->mactime = GET_RX_DESC_TSFL(pdesc); |
520 | if (phystatus) { | 519 | if (phystatus) { |
521 | p_drvinfo = (struct rx_fwinfo_92d *)(skb->data + | 520 | p_drvinfo = (struct rx_fwinfo_92d *)(skb->data + |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c index 672fd3b02835..da053cbdf621 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c | |||
@@ -264,7 +264,6 @@ bool rtl92se_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats, | |||
264 | struct rx_fwinfo *p_drvinfo; | 264 | struct rx_fwinfo *p_drvinfo; |
265 | u32 phystatus = (u32)GET_RX_STATUS_DESC_PHY_STATUS(pdesc); | 265 | u32 phystatus = (u32)GET_RX_STATUS_DESC_PHY_STATUS(pdesc); |
266 | struct ieee80211_hdr *hdr; | 266 | struct ieee80211_hdr *hdr; |
267 | bool first_ampdu = false; | ||
268 | 267 | ||
269 | stats->length = (u16)GET_RX_STATUS_DESC_PKT_LEN(pdesc); | 268 | stats->length = (u16)GET_RX_STATUS_DESC_PKT_LEN(pdesc); |
270 | stats->rx_drvinfo_size = (u8)GET_RX_STATUS_DESC_DRVINFO_SIZE(pdesc) * 8; | 269 | stats->rx_drvinfo_size = (u8)GET_RX_STATUS_DESC_DRVINFO_SIZE(pdesc) * 8; |
@@ -319,8 +318,8 @@ bool rtl92se_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats, | |||
319 | rx_status->flag |= RX_FLAG_DECRYPTED; | 318 | rx_status->flag |= RX_FLAG_DECRYPTED; |
320 | } | 319 | } |
321 | 320 | ||
322 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, | 321 | rx_status->rate_idx = rtlwifi_rate_mapping(hw, stats->is_ht, |
323 | stats->is_ht, stats->rate, first_ampdu); | 322 | stats->rate); |
324 | 323 | ||
325 | rx_status->mactime = stats->timestamp_low; | 324 | rx_status->mactime = stats->timestamp_low; |
326 | if (phystatus) { | 325 | if (phystatus) { |
@@ -398,9 +397,9 @@ void rtl92se_tx_fill_desc(struct ieee80211_hw *hw, | |||
398 | 397 | ||
399 | if (rtlhal->version == VERSION_8192S_ACUT) { | 398 | if (rtlhal->version == VERSION_8192S_ACUT) { |
400 | if (ptcb_desc->hw_rate == DESC92_RATE1M || | 399 | if (ptcb_desc->hw_rate == DESC92_RATE1M || |
401 | ptcb_desc->hw_rate == DESC92_RATE2M || | 400 | ptcb_desc->hw_rate == DESC92_RATE2M || |
402 | ptcb_desc->hw_rate == DESC92_RATE5_5M || | 401 | ptcb_desc->hw_rate == DESC92_RATE5_5M || |
403 | ptcb_desc->hw_rate == DESC92_RATE11M) { | 402 | ptcb_desc->hw_rate == DESC92_RATE11M) { |
404 | ptcb_desc->hw_rate = DESC92_RATE12M; | 403 | ptcb_desc->hw_rate = DESC92_RATE12M; |
405 | } | 404 | } |
406 | } | 405 | } |