diff options
author | Christian König <christian.koenig@amd.com> | 2014-07-30 11:18:12 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2014-08-05 08:53:42 -0400 |
commit | f1d2a26b506e9dc7bbe94fae40da0a0d8dcfacd0 (patch) | |
tree | d83c6738c86a7f55791c62a71306e249fe8e37c8 | |
parent | f069dc1dbc1e17b04b2ec65f65d1c9e9af667ff5 (diff) |
drm/radeon: set VM base addr using the PFP v2
Seems to make VM flushes more stable on SI and CIK.
v2: only use the PFP on the GFX ring on CIK
Signed-off-by: Christian König <christian.koenig@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/radeon/cik.c | 5 | ||||
-rw-r--r-- | drivers/gpu/drm/radeon/si.c | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index e6576b4b849d..60c276538ba9 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c | |||
@@ -5942,12 +5942,13 @@ static void cik_vm_decode_fault(struct radeon_device *rdev, | |||
5942 | void cik_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) | 5942 | void cik_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) |
5943 | { | 5943 | { |
5944 | struct radeon_ring *ring = &rdev->ring[ridx]; | 5944 | struct radeon_ring *ring = &rdev->ring[ridx]; |
5945 | int usepfp = (ridx == RADEON_RING_TYPE_GFX_INDEX); | ||
5945 | 5946 | ||
5946 | if (vm == NULL) | 5947 | if (vm == NULL) |
5947 | return; | 5948 | return; |
5948 | 5949 | ||
5949 | radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3)); | 5950 | radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3)); |
5950 | radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(0) | | 5951 | radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) | |
5951 | WRITE_DATA_DST_SEL(0))); | 5952 | WRITE_DATA_DST_SEL(0))); |
5952 | if (vm->id < 8) { | 5953 | if (vm->id < 8) { |
5953 | radeon_ring_write(ring, | 5954 | radeon_ring_write(ring, |
@@ -5997,7 +5998,7 @@ void cik_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) | |||
5997 | radeon_ring_write(ring, 1 << vm->id); | 5998 | radeon_ring_write(ring, 1 << vm->id); |
5998 | 5999 | ||
5999 | /* compute doesn't have PFP */ | 6000 | /* compute doesn't have PFP */ |
6000 | if (ridx == RADEON_RING_TYPE_GFX_INDEX) { | 6001 | if (usepfp) { |
6001 | /* sync PFP to ME, otherwise we might get invalid PFP reads */ | 6002 | /* sync PFP to ME, otherwise we might get invalid PFP reads */ |
6002 | radeon_ring_write(ring, PACKET3(PACKET3_PFP_SYNC_ME, 0)); | 6003 | radeon_ring_write(ring, PACKET3(PACKET3_PFP_SYNC_ME, 0)); |
6003 | radeon_ring_write(ring, 0x0); | 6004 | radeon_ring_write(ring, 0x0); |
diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index 6741804e4af2..806bed1758d6 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c | |||
@@ -5013,7 +5013,7 @@ void si_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) | |||
5013 | 5013 | ||
5014 | /* write new base address */ | 5014 | /* write new base address */ |
5015 | radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3)); | 5015 | radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3)); |
5016 | radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(0) | | 5016 | radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(1) | |
5017 | WRITE_DATA_DST_SEL(0))); | 5017 | WRITE_DATA_DST_SEL(0))); |
5018 | 5018 | ||
5019 | if (vm->id < 8) { | 5019 | if (vm->id < 8) { |