diff options
author | Arnd Bergmann <arnd@arndb.de> | 2014-06-05 17:05:48 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-09 17:41:30 -0400 |
commit | f1674f213ec81c55c909bb6805d3502b5883754d (patch) | |
tree | bf8af227c51e8d928bc1734d212c7a42f3a70a8e | |
parent | d8477126f46b036b26d95b127689a3774a080e34 (diff) |
pcmcia: pxa2xx: fix logic for lubbock
The lubbock platform uses the sa1111 companion chip with a pxa250
CPU, which means it requires both the PCMCIA_SA1111 and the
PCMCIA_PXA2XX code to be built into the kernel. Unfortunately,
the Makefile and Kconfig don't agree on how this is accomplished,
leading to a situation where you get this link error when building
a lubbock kernel with PCMCIA_SA1111 enabled but PCMCIA_PXA2XX
disabled:
ERROR: "pxa2xx_configure_sockets" [drivers/pcmcia/sa1111_cs.ko] undefined!
ERROR: "pxa2xx_drv_pcmcia_ops" [drivers/pcmcia/sa1111_cs.ko] undefined!
ERROR: "pxa2xx_drv_pcmcia_add_one" [drivers/pcmcia/sa1111_cs.ko] undefined!
This patch changes the Kconfig code to disallow that particular
configuration.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/pcmcia/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig index 0c657d6af03d..51cf8083b299 100644 --- a/drivers/pcmcia/Kconfig +++ b/drivers/pcmcia/Kconfig | |||
@@ -202,6 +202,7 @@ config PCMCIA_SA1111 | |||
202 | depends on ARM && SA1111 && PCMCIA | 202 | depends on ARM && SA1111 && PCMCIA |
203 | select PCMCIA_SOC_COMMON | 203 | select PCMCIA_SOC_COMMON |
204 | select PCMCIA_SA11XX_BASE if ARCH_SA1100 | 204 | select PCMCIA_SA11XX_BASE if ARCH_SA1100 |
205 | select PCMCIA_PXA2XX if ARCH_LUBBOCK && SA1111 | ||
205 | help | 206 | help |
206 | Say Y here to include support for SA1111-based PCMCIA or CF | 207 | Say Y here to include support for SA1111-based PCMCIA or CF |
207 | sockets, found on the Jornada 720, Graphicsmaster and other | 208 | sockets, found on the Jornada 720, Graphicsmaster and other |
@@ -217,7 +218,6 @@ config PCMCIA_PXA2XX | |||
217 | || ARCOM_PCMCIA || ARCH_PXA_ESERIES || MACH_STARGATE2 \ | 218 | || ARCOM_PCMCIA || ARCH_PXA_ESERIES || MACH_STARGATE2 \ |
218 | || MACH_VPAC270 || MACH_BALLOON3 || MACH_COLIBRI \ | 219 | || MACH_VPAC270 || MACH_BALLOON3 || MACH_COLIBRI \ |
219 | || MACH_COLIBRI320 || MACH_H4700) | 220 | || MACH_COLIBRI320 || MACH_H4700) |
220 | select PCMCIA_SA1111 if ARCH_LUBBOCK && SA1111 | ||
221 | select PCMCIA_SOC_COMMON | 221 | select PCMCIA_SOC_COMMON |
222 | help | 222 | help |
223 | Say Y here to include support for the PXA2xx PCMCIA controller | 223 | Say Y here to include support for the PXA2xx PCMCIA controller |