diff options
author | Eric Sandeen <sandeen@sandeen.net> | 2014-01-21 17:44:57 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2014-01-24 12:49:20 -0500 |
commit | f0bc9985fe8bf4377d5557cd7957d9be43ec8861 (patch) | |
tree | 24877ca67f489797faca17328a6ed2afa2ece7d9 | |
parent | bf3964c188d686424ff7b69a45941851b9f437f0 (diff) |
xfs: clean up xfs_buftarg
Clean up the xfs_buftarg structure a bit:
- remove bt_bsize which is never used
- replace bt_sshift with bt_ssize; we only ever shift it back
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r-- | fs/xfs/xfs_buf.c | 5 | ||||
-rw-r--r-- | fs/xfs/xfs_buf.h | 3 | ||||
-rw-r--r-- | fs/xfs/xfs_ioctl.c | 2 |
3 files changed, 4 insertions, 6 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 9fccfb594291..b664bce57bfc 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c | |||
@@ -445,7 +445,7 @@ _xfs_buf_find( | |||
445 | numbytes = BBTOB(numblks); | 445 | numbytes = BBTOB(numblks); |
446 | 446 | ||
447 | /* Check for IOs smaller than the sector size / not sector aligned */ | 447 | /* Check for IOs smaller than the sector size / not sector aligned */ |
448 | ASSERT(!(numbytes < (1 << btp->bt_sshift))); | 448 | ASSERT(!(numbytes < btp->bt_ssize)); |
449 | ASSERT(!(BBTOB(blkno) & (xfs_off_t)btp->bt_smask)); | 449 | ASSERT(!(BBTOB(blkno) & (xfs_off_t)btp->bt_smask)); |
450 | 450 | ||
451 | /* | 451 | /* |
@@ -1599,8 +1599,7 @@ xfs_setsize_buftarg( | |||
1599 | unsigned int blocksize, | 1599 | unsigned int blocksize, |
1600 | unsigned int sectorsize) | 1600 | unsigned int sectorsize) |
1601 | { | 1601 | { |
1602 | btp->bt_bsize = blocksize; | 1602 | btp->bt_ssize = sectorsize; |
1603 | btp->bt_sshift = ffs(sectorsize) - 1; | ||
1604 | btp->bt_smask = sectorsize - 1; | 1603 | btp->bt_smask = sectorsize - 1; |
1605 | 1604 | ||
1606 | if (set_blocksize(btp->bt_bdev, sectorsize)) { | 1605 | if (set_blocksize(btp->bt_bdev, sectorsize)) { |
diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index 1cf21a4a9f22..4ef949aebb04 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h | |||
@@ -93,8 +93,7 @@ typedef struct xfs_buftarg { | |||
93 | struct block_device *bt_bdev; | 93 | struct block_device *bt_bdev; |
94 | struct backing_dev_info *bt_bdi; | 94 | struct backing_dev_info *bt_bdi; |
95 | struct xfs_mount *bt_mount; | 95 | struct xfs_mount *bt_mount; |
96 | unsigned int bt_bsize; | 96 | unsigned int bt_ssize; |
97 | unsigned int bt_sshift; | ||
98 | size_t bt_smask; | 97 | size_t bt_smask; |
99 | 98 | ||
100 | /* LRU control structures */ | 99 | /* LRU control structures */ |
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 518aa56b8f2e..584e092415d0 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c | |||
@@ -1583,7 +1583,7 @@ xfs_file_ioctl( | |||
1583 | XFS_IS_REALTIME_INODE(ip) ? | 1583 | XFS_IS_REALTIME_INODE(ip) ? |
1584 | mp->m_rtdev_targp : mp->m_ddev_targp; | 1584 | mp->m_rtdev_targp : mp->m_ddev_targp; |
1585 | 1585 | ||
1586 | da.d_mem = da.d_miniosz = 1 << target->bt_sshift; | 1586 | da.d_mem = da.d_miniosz = target->bt_ssize; |
1587 | da.d_maxiosz = INT_MAX & ~(da.d_miniosz - 1); | 1587 | da.d_maxiosz = INT_MAX & ~(da.d_miniosz - 1); |
1588 | 1588 | ||
1589 | if (copy_to_user(arg, &da, sizeof(da))) | 1589 | if (copy_to_user(arg, &da, sizeof(da))) |