diff options
author | Rik van Riel <riel@redhat.com> | 2014-06-23 11:41:29 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-07-05 05:17:33 -0400 |
commit | f0b8a4afd6a8c500161e45065a91738b490bf5ae (patch) | |
tree | ba510d83c047b38a726ee8f0bb4a65ba143a9216 | |
parent | 4486edd12b5ac8a9af7a5e16e4b9eeb3b8339c10 (diff) |
sched/numa: Use group's max nid as task's preferred nid
From task_numa_placement, always try to consolidate the tasks
in a group on the group's top nid.
In case this task is part of a group that is interleaved over
multiple nodes, task_numa_migrate will set the task's preferred
nid to the best node it could find for the task, so this patch
will cause at most one run through task_numa_migrate.
Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: mgorman@suse.de
Cc: chegu_vinod@hp.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1403538095-31256-2-git-send-email-riel@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | kernel/sched/fair.c | 17 |
1 files changed, 1 insertions, 16 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e3ff3d1c4780..96b2d3929a4e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c | |||
@@ -1594,23 +1594,8 @@ static void task_numa_placement(struct task_struct *p) | |||
1594 | 1594 | ||
1595 | if (p->numa_group) { | 1595 | if (p->numa_group) { |
1596 | update_numa_active_node_mask(p->numa_group); | 1596 | update_numa_active_node_mask(p->numa_group); |
1597 | /* | ||
1598 | * If the preferred task and group nids are different, | ||
1599 | * iterate over the nodes again to find the best place. | ||
1600 | */ | ||
1601 | if (max_nid != max_group_nid) { | ||
1602 | unsigned long weight, max_weight = 0; | ||
1603 | |||
1604 | for_each_online_node(nid) { | ||
1605 | weight = task_weight(p, nid) + group_weight(p, nid); | ||
1606 | if (weight > max_weight) { | ||
1607 | max_weight = weight; | ||
1608 | max_nid = nid; | ||
1609 | } | ||
1610 | } | ||
1611 | } | ||
1612 | |||
1613 | spin_unlock_irq(group_lock); | 1597 | spin_unlock_irq(group_lock); |
1598 | max_nid = max_group_nid; | ||
1614 | } | 1599 | } |
1615 | 1600 | ||
1616 | if (max_faults) { | 1601 | if (max_faults) { |