aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2010-12-18 17:05:02 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2010-12-29 05:17:04 -0500
commitef330dc2e794c932fcbde3f8abd3f12780d78b47 (patch)
treeb5b7e2f70814aa02fce7e2b92c236f06bddb9dea
parent10304ca65f8871ad9f6725a7480522034184f55f (diff)
[media] saa7164: Remove pointless conditional and save a few bytes in saa7164_downloadfirmware()
Hi, release_firmware() just does nothing if passed a NULL pointer. So there's no reason to test before the call in saa7164-fw.c::saa7164_downloadfirmware(). Removing the pointless conditional also saves a few bytes. before: text data bss dec hex filename 7943 112 2144 10199 27d7 drivers/media/video/saa7164/saa7164-fw.o after: text data bss dec hex filename 7931 112 2136 10179 27c3 drivers/media/video/saa7164/saa7164-fw.o Signed-off-by: Jesper Juhl <jj@chaosbits.net> Cc: Steven Toth <stoth@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/video/saa7164/saa7164-fw.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/media/video/saa7164/saa7164-fw.c b/drivers/media/video/saa7164/saa7164-fw.c
index 22b02323dca9..ebed6f786a23 100644
--- a/drivers/media/video/saa7164/saa7164-fw.c
+++ b/drivers/media/video/saa7164/saa7164-fw.c
@@ -608,8 +608,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
608 ret = 0; 608 ret = 0;
609 609
610out: 610out:
611 if (fw) 611 release_firmware(fw);
612 release_firmware(fw);
613
614 return ret; 612 return ret;
615} 613}