diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-07-11 13:30:18 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-07-23 01:05:20 -0400 |
commit | eeefa889cddb8d7e4ee6ce0212e685dd624d66a1 (patch) | |
tree | 026c1110b986caa1b7b025a7bd56eabb0450f7dc | |
parent | fa128fa647b81734ff83c3c5ee0d60ebf69e6ee5 (diff) |
drm/i915: Remove redundant HAS_PSR checks
We only need to check for this in psr_enable, everything else is
already protect by the dev_priv->psr.enabled checks. Those need the
psr locking, but these functions are called infrequent enough that the
locking overhead is negligible.
Suggested by Chris Wilson.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 333471c4dcd1..86b5e979e616 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
@@ -1772,11 +1772,6 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp) | |||
1772 | 1772 | ||
1773 | dev_priv->psr.source_ok = false; | 1773 | dev_priv->psr.source_ok = false; |
1774 | 1774 | ||
1775 | if (!HAS_PSR(dev)) { | ||
1776 | DRM_DEBUG_KMS("PSR not supported on this platform\n"); | ||
1777 | return false; | ||
1778 | } | ||
1779 | |||
1780 | if (IS_HASWELL(dev) && dig_port->port != PORT_A) { | 1775 | if (IS_HASWELL(dev) && dig_port->port != PORT_A) { |
1781 | DRM_DEBUG_KMS("HSW ties PSR to DDI A (eDP)\n"); | 1776 | DRM_DEBUG_KMS("HSW ties PSR to DDI A (eDP)\n"); |
1782 | return false; | 1777 | return false; |
@@ -1863,9 +1858,6 @@ void intel_edp_psr_disable(struct intel_dp *intel_dp) | |||
1863 | struct drm_device *dev = intel_dp_to_dev(intel_dp); | 1858 | struct drm_device *dev = intel_dp_to_dev(intel_dp); |
1864 | struct drm_i915_private *dev_priv = dev->dev_private; | 1859 | struct drm_i915_private *dev_priv = dev->dev_private; |
1865 | 1860 | ||
1866 | if (!HAS_PSR(dev)) | ||
1867 | return; | ||
1868 | |||
1869 | mutex_lock(&dev_priv->psr.lock); | 1861 | mutex_lock(&dev_priv->psr.lock); |
1870 | if (!dev_priv->psr.enabled) { | 1862 | if (!dev_priv->psr.enabled) { |
1871 | mutex_unlock(&dev_priv->psr.lock); | 1863 | mutex_unlock(&dev_priv->psr.lock); |
@@ -1940,9 +1932,6 @@ void intel_edp_psr_invalidate(struct drm_device *dev, | |||
1940 | struct drm_crtc *crtc; | 1932 | struct drm_crtc *crtc; |
1941 | enum pipe pipe; | 1933 | enum pipe pipe; |
1942 | 1934 | ||
1943 | if (!HAS_PSR(dev)) | ||
1944 | return; | ||
1945 | |||
1946 | mutex_lock(&dev_priv->psr.lock); | 1935 | mutex_lock(&dev_priv->psr.lock); |
1947 | if (!dev_priv->psr.enabled) { | 1936 | if (!dev_priv->psr.enabled) { |
1948 | mutex_unlock(&dev_priv->psr.lock); | 1937 | mutex_unlock(&dev_priv->psr.lock); |
@@ -1967,9 +1956,6 @@ void intel_edp_psr_flush(struct drm_device *dev, | |||
1967 | struct drm_crtc *crtc; | 1956 | struct drm_crtc *crtc; |
1968 | enum pipe pipe; | 1957 | enum pipe pipe; |
1969 | 1958 | ||
1970 | if (!HAS_PSR(dev)) | ||
1971 | return; | ||
1972 | |||
1973 | mutex_lock(&dev_priv->psr.lock); | 1959 | mutex_lock(&dev_priv->psr.lock); |
1974 | if (!dev_priv->psr.enabled) { | 1960 | if (!dev_priv->psr.enabled) { |
1975 | mutex_unlock(&dev_priv->psr.lock); | 1961 | mutex_unlock(&dev_priv->psr.lock); |