diff options
| author | Sam Ravnborg <sam@ravnborg.org> | 2014-05-16 17:25:59 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-05-18 22:01:31 -0400 |
| commit | ed8eb7551006dd02c14438eb374b302a39b3e92e (patch) | |
| tree | a7b257ae501987bb0f5ee80172898bc8f5ba8260 | |
| parent | 4ac7b8268ebbb0aea4dba0dd4c60d74bd8935aa6 (diff) | |
sparc64: fix sparse warnings in sys_sparc32.c
Fix following warnings:
sys_sparc32.c:52:17: warning: symbol 'sys32_truncate64' was not declared. Should it be static?
sys_sparc32.c:60:17: warning: symbol 'sys32_ftruncate64' was not declared. Should it be static?
sys_sparc32.c:98:17: warning: symbol 'compat_sys_stat64' was not declared. Should it be static?
sys_sparc32.c:109:17: warning: symbol 'compat_sys_lstat64' was not declared. Should it be static?
sys_sparc32.c:120:17: warning: symbol 'compat_sys_fstat64' was not declared. Should it be static?
sys_sparc32.c:131:17: warning: symbol 'compat_sys_fstatat64' was not declared. Should it be static?
sys_sparc32.c:196:27: warning: symbol 'sys32_pread64' was not declared. Should it be static?
sys_sparc32.c:205:27: warning: symbol 'sys32_pwrite64' was not declared. Should it be static?
sys_sparc32.c:214:17: warning: symbol 'compat_sys_readahead' was not declared. Should it be static?
sys_sparc32.c:222:6: warning: symbol 'compat_sys_fadvise64' was not declared. Should it be static?
sys_sparc32.c:230:6: warning: symbol 'compat_sys_fadvise64_64' was not declared. Should it be static?
sys_sparc32.c:241:6: warning: symbol 'sys32_sync_file_range' was not declared. Should it be static?
sys_sparc32.c:249:17: warning: symbol 'compat_sys_fallocate' was not declared. Should it be static?
Add proper prototypes in systbls.h
Include linux/compat.h to get access to necessary types
Use inverse christmas tree order in includes
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | arch/sparc/kernel/sys_sparc32.c | 2 | ||||
| -rw-r--r-- | arch/sparc/kernel/systbls.h | 55 |
2 files changed, 55 insertions, 2 deletions
diff --git a/arch/sparc/kernel/sys_sparc32.c b/arch/sparc/kernel/sys_sparc32.c index 71368850dfc0..022c30c72ebd 100644 --- a/arch/sparc/kernel/sys_sparc32.c +++ b/arch/sparc/kernel/sys_sparc32.c | |||
| @@ -49,6 +49,8 @@ | |||
| 49 | #include <asm/mmu_context.h> | 49 | #include <asm/mmu_context.h> |
| 50 | #include <asm/compat_signal.h> | 50 | #include <asm/compat_signal.h> |
| 51 | 51 | ||
| 52 | #include "systbls.h" | ||
| 53 | |||
| 52 | asmlinkage long sys32_truncate64(const char __user * path, unsigned long high, unsigned long low) | 54 | asmlinkage long sys32_truncate64(const char __user * path, unsigned long high, unsigned long low) |
| 53 | { | 55 | { |
| 54 | if ((int)high < 0) | 56 | if ((int)high < 0) |
diff --git a/arch/sparc/kernel/systbls.h b/arch/sparc/kernel/systbls.h index a3ed7ae0cf94..2dab8236d490 100644 --- a/arch/sparc/kernel/systbls.h +++ b/arch/sparc/kernel/systbls.h | |||
| @@ -1,9 +1,11 @@ | |||
| 1 | #ifndef _SYSTBLS_H | 1 | #ifndef _SYSTBLS_H |
| 2 | #define _SYSTBLS_H | 2 | #define _SYSTBLS_H |
| 3 | 3 | ||
| 4 | #include <linux/signal.h> | ||
| 4 | #include <linux/kernel.h> | 5 | #include <linux/kernel.h> |
| 6 | #include <linux/compat.h> | ||
| 5 | #include <linux/types.h> | 7 | #include <linux/types.h> |
| 6 | #include <linux/signal.h> | 8 | |
| 7 | #include <asm/utrap.h> | 9 | #include <asm/utrap.h> |
| 8 | 10 | ||
| 9 | asmlinkage unsigned long sys_getpagesize(void); | 11 | asmlinkage unsigned long sys_getpagesize(void); |
| @@ -47,6 +49,55 @@ asmlinkage long sparc_memory_ordering(unsigned long model, | |||
| 47 | struct pt_regs *regs); | 49 | struct pt_regs *regs); |
| 48 | asmlinkage void sparc64_set_context(struct pt_regs *regs); | 50 | asmlinkage void sparc64_set_context(struct pt_regs *regs); |
| 49 | asmlinkage void sparc64_get_context(struct pt_regs *regs); | 51 | asmlinkage void sparc64_get_context(struct pt_regs *regs); |
| 50 | 52 | asmlinkage long sys32_truncate64(const char __user * path, | |
| 53 | unsigned long high, | ||
| 54 | unsigned long low); | ||
| 55 | asmlinkage long sys32_ftruncate64(unsigned int fd, | ||
| 56 | unsigned long high, | ||
| 57 | unsigned long low); | ||
| 58 | struct compat_stat64; | ||
| 59 | asmlinkage long compat_sys_stat64(const char __user * filename, | ||
| 60 | struct compat_stat64 __user *statbuf); | ||
| 61 | asmlinkage long compat_sys_lstat64(const char __user * filename, | ||
| 62 | struct compat_stat64 __user *statbuf); | ||
| 63 | asmlinkage long compat_sys_fstat64(unsigned int fd, | ||
| 64 | struct compat_stat64 __user * statbuf); | ||
| 65 | asmlinkage long compat_sys_fstatat64(unsigned int dfd, | ||
| 66 | const char __user *filename, | ||
| 67 | struct compat_stat64 __user * statbuf, int flag); | ||
| 68 | asmlinkage compat_ssize_t sys32_pread64(unsigned int fd, | ||
| 69 | char __user *ubuf, | ||
| 70 | compat_size_t count, | ||
| 71 | unsigned long poshi, | ||
| 72 | unsigned long poslo); | ||
| 73 | asmlinkage compat_ssize_t sys32_pwrite64(unsigned int fd, | ||
| 74 | char __user *ubuf, | ||
| 75 | compat_size_t count, | ||
| 76 | unsigned long poshi, | ||
| 77 | unsigned long poslo); | ||
| 78 | asmlinkage long compat_sys_readahead(int fd, | ||
| 79 | unsigned long offhi, | ||
| 80 | unsigned long offlo, | ||
| 81 | compat_size_t count); | ||
| 82 | long compat_sys_fadvise64(int fd, | ||
| 83 | unsigned long offhi, | ||
| 84 | unsigned long offlo, | ||
| 85 | compat_size_t len, int advice); | ||
| 86 | long compat_sys_fadvise64_64(int fd, | ||
| 87 | unsigned long offhi, unsigned long offlo, | ||
| 88 | unsigned long lenhi, unsigned long lenlo, | ||
| 89 | int advice); | ||
| 90 | long sys32_sync_file_range(unsigned int fd, | ||
| 91 | unsigned long off_high, unsigned long off_low, | ||
| 92 | unsigned long nb_high, unsigned long nb_low, | ||
| 93 | unsigned int flags); | ||
| 94 | asmlinkage long compat_sys_fallocate(int fd, int mode, u32 offhi, u32 offlo, | ||
| 95 | u32 lenhi, u32 lenlo); | ||
| 96 | asmlinkage long compat_sys_fstat64(unsigned int fd, | ||
| 97 | struct compat_stat64 __user * statbuf); | ||
| 98 | asmlinkage long compat_sys_fstatat64(unsigned int dfd, | ||
| 99 | const char __user *filename, | ||
| 100 | struct compat_stat64 __user * statbuf, | ||
| 101 | int flag); | ||
| 51 | #endif /* CONFIG_SPARC64 */ | 102 | #endif /* CONFIG_SPARC64 */ |
| 52 | #endif /* _SYSTBLS_H */ | 103 | #endif /* _SYSTBLS_H */ |
