aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Cochran <richardcochran@gmail.com>2015-03-29 17:12:13 -0400
committerDavid S. Miller <davem@davemloft.net>2015-03-31 12:01:19 -0400
commited7c6317bc599502e1fdc7f5f95cb9a5550360a4 (patch)
tree7e9d6452f150edd63d2a6f911b355152f6d0fb60
parenta043a72909b9ed9b3505f3be42d5329cea50c273 (diff)
ptp: remove 32 bit get/set methods.
All of the PHC drivers have been converted to the new methods. This patch converts the three remaining callers within the core code and removes the older methods for good. As a result, the core PHC code is ready for the year 2038. However, some of the PHC drivers are not quite ready yet. Signed-off-by: Richard Cochran <richardcochran@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/ptp/ptp_chardev.c8
-rw-r--r--drivers/ptp/ptp_clock.c15
-rw-r--r--include/linux/ptp_clock_kernel.h8
3 files changed, 5 insertions, 26 deletions
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 95bcf1525a84..da7bae991552 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -125,7 +125,6 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
125 struct ptp_clock_info *ops = ptp->info; 125 struct ptp_clock_info *ops = ptp->info;
126 struct ptp_clock_time *pct; 126 struct ptp_clock_time *pct;
127 struct timespec64 ts; 127 struct timespec64 ts;
128 struct timespec t2;
129 int enable, err = 0; 128 int enable, err = 0;
130 unsigned int i, pin_index; 129 unsigned int i, pin_index;
131 130
@@ -202,12 +201,7 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
202 pct->sec = ts.tv_sec; 201 pct->sec = ts.tv_sec;
203 pct->nsec = ts.tv_nsec; 202 pct->nsec = ts.tv_nsec;
204 pct++; 203 pct++;
205 if (ptp->info->gettime64) { 204 ptp->info->gettime64(ptp->info, &ts);
206 ptp->info->gettime64(ptp->info, &ts);
207 } else {
208 ptp->info->gettime(ptp->info, &t2);
209 ts = timespec_to_timespec64(t2);
210 }
211 pct->sec = ts.tv_sec; 205 pct->sec = ts.tv_sec;
212 pct->nsec = ts.tv_nsec; 206 pct->nsec = ts.tv_nsec;
213 pct++; 207 pct++;
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index df50d5eeae6f..2e481b9e8ea5 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -109,9 +109,7 @@ static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp)
109 struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock); 109 struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
110 struct timespec64 ts = timespec_to_timespec64(*tp); 110 struct timespec64 ts = timespec_to_timespec64(*tp);
111 111
112 return ptp->info->settime64 ? 112 return ptp->info->settime64(ptp->info, &ts);
113 ptp->info->settime64(ptp->info, &ts) :
114 ptp->info->settime(ptp->info, tp);
115} 113}
116 114
117static int ptp_clock_gettime(struct posix_clock *pc, struct timespec *tp) 115static int ptp_clock_gettime(struct posix_clock *pc, struct timespec *tp)
@@ -120,14 +118,9 @@ static int ptp_clock_gettime(struct posix_clock *pc, struct timespec *tp)
120 struct timespec64 ts; 118 struct timespec64 ts;
121 int err; 119 int err;
122 120
123 if (ptp->info->gettime64) { 121 err = ptp->info->gettime64(ptp->info, &ts);
124 err = ptp->info->gettime64(ptp->info, &ts); 122 if (!err)
125 if (!err) 123 *tp = timespec64_to_timespec(ts);
126 *tp = timespec64_to_timespec(ts);
127 } else {
128 err = ptp->info->gettime(ptp->info, tp);
129 }
130
131 return err; 124 return err;
132} 125}
133 126
diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
index 7d6f8e66396f..b8b73066d137 100644
--- a/include/linux/ptp_clock_kernel.h
+++ b/include/linux/ptp_clock_kernel.h
@@ -64,12 +64,6 @@ struct ptp_clock_request {
64 * @adjtime: Shifts the time of the hardware clock. 64 * @adjtime: Shifts the time of the hardware clock.
65 * parameter delta: Desired change in nanoseconds. 65 * parameter delta: Desired change in nanoseconds.
66 * 66 *
67 * @gettime: Reads the current time from the hardware clock. (deprecated)
68 * parameter ts: Holds the result.
69 *
70 * @settime: Set the current time on the hardware clock. (deprecated)
71 * parameter ts: Time value to set.
72 *
73 * @gettime64: Reads the current time from the hardware clock. 67 * @gettime64: Reads the current time from the hardware clock.
74 * parameter ts: Holds the result. 68 * parameter ts: Holds the result.
75 * 69 *
@@ -110,8 +104,6 @@ struct ptp_clock_info {
110 struct ptp_pin_desc *pin_config; 104 struct ptp_pin_desc *pin_config;
111 int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta); 105 int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta);
112 int (*adjtime)(struct ptp_clock_info *ptp, s64 delta); 106 int (*adjtime)(struct ptp_clock_info *ptp, s64 delta);
113 int (*gettime)(struct ptp_clock_info *ptp, struct timespec *ts);
114 int (*settime)(struct ptp_clock_info *ptp, const struct timespec *ts);
115 int (*gettime64)(struct ptp_clock_info *ptp, struct timespec64 *ts); 107 int (*gettime64)(struct ptp_clock_info *ptp, struct timespec64 *ts);
116 int (*settime64)(struct ptp_clock_info *p, const struct timespec64 *ts); 108 int (*settime64)(struct ptp_clock_info *p, const struct timespec64 *ts);
117 int (*enable)(struct ptp_clock_info *ptp, 109 int (*enable)(struct ptp_clock_info *ptp,