drm/rockchip: use for_each_endpoint_of_node macro, drop endpoint reference on break

Using the for_each_... macro should make the code a bit shorter and
easier to read. Also, when breaking out of the loop, the endpoint node
reference count needs to be decremented.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

1 files changed, 4 insertions, 7 deletions

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 21a481b224eb..9bb4fd27d52f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -366,7 +366,7 @@ static const struct dev_pm_ops rockchip_drm_pm_ops = {
 int rockchip_drm_encoder_get_mux_id(struct device_node *node,
                                     struct drm_encoder *encoder)
 {
-        struct device_node *ep = NULL;
+        struct device_node *ep;
         struct drm_crtc *crtc = encoder->crtc;
         struct of_endpoint endpoint;
         struct device_node *port;
@@ -375,18 +375,15 @@ int rockchip_drm_encoder_get_mux_id(struct device_node *node,
         if (!node || !crtc)
                 return -EINVAL;
 
-        do {
-                ep = of_graph_get_next_endpoint(node, ep);
-                if (!ep)
-                        break;
-
+        for_each_endpoint_of_node(node, ep) {
                 port = of_graph_get_remote_port(ep);
                 of_node_put(port);
                 if (port == crtc->port) {
                         ret = of_graph_parse_endpoint(ep, &endpoint);
+                        of_node_put(ep);
                         return ret ?: endpoint.id;
                 }
-        } while (ep);
+        }
 
         return -EINVAL;
 }