aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2014-05-20 17:21:13 -0400
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-08-21 16:25:12 -0400
commiteb228e897c902a65f6da536331f7d058fde1ea73 (patch)
tree1b163c5746e453b293121f8c3197600eb4eb03ac
parent24acf8b211e25414cb288305292a1fda136c0bd8 (diff)
[media] omap3isp: Don't ignore subdev streamoff failures
Record the value returned by subdevs from s_stream(0) and handle stop failures when an error occurs. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by: Enrico Butera <ebutera@users.sourceforge.net> Acked-by: Sakari Ailus <sakari.ailus@iki.fi> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r--drivers/media/platform/omap3isp/isp.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 2c7aa6720569..7b10c461a497 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -999,16 +999,14 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe)
999 video, s_stream, 0); 999 video, s_stream, 0);
1000 } 1000 }
1001 1001
1002 v4l2_subdev_call(subdev, video, s_stream, 0); 1002 ret = v4l2_subdev_call(subdev, video, s_stream, 0);
1003 1003
1004 if (subdev == &isp->isp_res.subdev) 1004 if (subdev == &isp->isp_res.subdev)
1005 ret = isp_pipeline_wait(isp, isp_pipeline_wait_resizer); 1005 ret |= isp_pipeline_wait(isp, isp_pipeline_wait_resizer);
1006 else if (subdev == &isp->isp_prev.subdev) 1006 else if (subdev == &isp->isp_prev.subdev)
1007 ret = isp_pipeline_wait(isp, isp_pipeline_wait_preview); 1007 ret |= isp_pipeline_wait(isp, isp_pipeline_wait_preview);
1008 else if (subdev == &isp->isp_ccdc.subdev) 1008 else if (subdev == &isp->isp_ccdc.subdev)
1009 ret = isp_pipeline_wait(isp, isp_pipeline_wait_ccdc); 1009 ret |= isp_pipeline_wait(isp, isp_pipeline_wait_ccdc);
1010 else
1011 ret = 0;
1012 1010
1013 /* Handle stop failures. An entity that fails to stop can 1011 /* Handle stop failures. An entity that fails to stop can
1014 * usually just be restarted. Flag the stop failure nonetheless 1012 * usually just be restarted. Flag the stop failure nonetheless