aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDoug Anderson <dianders@chromium.org>2014-12-02 18:42:45 -0500
committerUlf Hansson <ulf.hansson@linaro.org>2015-01-19 03:56:04 -0500
commiteac86321b5c33e6b68aa4a4e0517c45df3ef02c0 (patch)
tree545b7a910dc2bb8ff93ba98642b9edd99d4dc610
parenta48fd4e77a947327faa820cadf5d8831061e337d (diff)
mmc: core: Support the optional init_card() callback for MMC and SD
In (3fcb027 ARM: MXC: mxcmmc: work around a bug in the SDHC busy line handling) the optional init_card() callback was added. According to the original change it was "for now only called from mmc_sdio_init_card()". This callback really ought to be called from the SD and MMC init functions as well. One current user of this callback (mxcmci_init_card) will not work as expected if you insert an SDIO card, then eject it and put a normal SD card in. Specifically the normal SD card will not get to run with 4-bit data. I'd like to use the init_card() callback to handle a similar quirk on dw_mmc when using SDIO Interrupts (the "low power" feature of the card needs to be disabled), so that will add a second user of the function. Signed-off-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/mmc/core/mmc.c6
-rw-r--r--drivers/mmc/core/sd.c7
2 files changed, 12 insertions, 1 deletions
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 7466ce098e60..d854bff037a2 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1297,6 +1297,12 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
1297 } 1297 }
1298 1298
1299 /* 1299 /*
1300 * Call the optional HC's init_card function to handle quirks.
1301 */
1302 if (host->ops->init_card)
1303 host->ops->init_card(host, card);
1304
1305 /*
1300 * For native busses: set card RCA and quit open drain mode. 1306 * For native busses: set card RCA and quit open drain mode.
1301 */ 1307 */
1302 if (!mmc_host_is_spi(host)) { 1308 if (!mmc_host_is_spi(host)) {
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index d90a6de7901d..29fccdcacd68 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -933,6 +933,12 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
933 } 933 }
934 934
935 /* 935 /*
936 * Call the optional HC's init_card function to handle quirks.
937 */
938 if (host->ops->init_card)
939 host->ops->init_card(host, card);
940
941 /*
936 * For native busses: get card RCA and quit open drain mode. 942 * For native busses: get card RCA and quit open drain mode.
937 */ 943 */
938 if (!mmc_host_is_spi(host)) { 944 if (!mmc_host_is_spi(host)) {
@@ -1271,4 +1277,3 @@ err:
1271 1277
1272 return err; 1278 return err;
1273} 1279}
1274