diff options
author | Zheng Liu <wenqing.lz@taobao.com> | 2014-09-01 22:22:13 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2014-09-01 22:22:13 -0400 |
commit | e963bb1de415ab06693357336c1bec664753e1e2 (patch) | |
tree | 016f5bd56b0fe12aafd5de79b0b44032d340002b | |
parent | d91bd2c1d78d8d22f9f721aae84650a08239b509 (diff) |
ext4: improve extents status tree trace point
This commit improves the trace point of extents status tree. We rename
trace_ext4_es_shrink_enter in ext4_es_count() because it is also used
in ext4_es_scan() and we can not identify them from the result.
Further this commit fixes a variable name in trace point in order to
keep consistency with others.
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r-- | fs/ext4/extents_status.c | 6 | ||||
-rw-r--r-- | include/trace/events/ext4.h | 28 |
2 files changed, 23 insertions, 11 deletions
diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index bdd400c81533..95da65c60d83 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ext4/extents_status.c | |||
@@ -1019,7 +1019,7 @@ static unsigned long ext4_es_count(struct shrinker *shrink, | |||
1019 | 1019 | ||
1020 | sbi = container_of(shrink, struct ext4_sb_info, s_es_shrinker); | 1020 | sbi = container_of(shrink, struct ext4_sb_info, s_es_shrinker); |
1021 | nr = percpu_counter_read_positive(&sbi->s_extent_cache_cnt); | 1021 | nr = percpu_counter_read_positive(&sbi->s_extent_cache_cnt); |
1022 | trace_ext4_es_shrink_enter(sbi->s_sb, sc->nr_to_scan, nr); | 1022 | trace_ext4_es_shrink_count(sbi->s_sb, sc->nr_to_scan, nr); |
1023 | return nr; | 1023 | return nr; |
1024 | } | 1024 | } |
1025 | 1025 | ||
@@ -1032,14 +1032,14 @@ static unsigned long ext4_es_scan(struct shrinker *shrink, | |||
1032 | int ret, nr_shrunk; | 1032 | int ret, nr_shrunk; |
1033 | 1033 | ||
1034 | ret = percpu_counter_read_positive(&sbi->s_extent_cache_cnt); | 1034 | ret = percpu_counter_read_positive(&sbi->s_extent_cache_cnt); |
1035 | trace_ext4_es_shrink_enter(sbi->s_sb, nr_to_scan, ret); | 1035 | trace_ext4_es_shrink_scan_enter(sbi->s_sb, nr_to_scan, ret); |
1036 | 1036 | ||
1037 | if (!nr_to_scan) | 1037 | if (!nr_to_scan) |
1038 | return ret; | 1038 | return ret; |
1039 | 1039 | ||
1040 | nr_shrunk = __ext4_es_shrink(sbi, nr_to_scan, NULL); | 1040 | nr_shrunk = __ext4_es_shrink(sbi, nr_to_scan, NULL); |
1041 | 1041 | ||
1042 | trace_ext4_es_shrink_exit(sbi->s_sb, nr_shrunk, ret); | 1042 | trace_ext4_es_shrink_scan_exit(sbi->s_sb, nr_shrunk, ret); |
1043 | return nr_shrunk; | 1043 | return nr_shrunk; |
1044 | } | 1044 | } |
1045 | 1045 | ||
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h index d4f70a7fe876..849aaba75dc8 100644 --- a/include/trace/events/ext4.h +++ b/include/trace/events/ext4.h | |||
@@ -2369,7 +2369,7 @@ TRACE_EVENT(ext4_es_lookup_extent_exit, | |||
2369 | show_extent_status(__entry->found ? __entry->status : 0)) | 2369 | show_extent_status(__entry->found ? __entry->status : 0)) |
2370 | ); | 2370 | ); |
2371 | 2371 | ||
2372 | TRACE_EVENT(ext4_es_shrink_enter, | 2372 | DECLARE_EVENT_CLASS(ext4__es_shrink_enter, |
2373 | TP_PROTO(struct super_block *sb, int nr_to_scan, int cache_cnt), | 2373 | TP_PROTO(struct super_block *sb, int nr_to_scan, int cache_cnt), |
2374 | 2374 | ||
2375 | TP_ARGS(sb, nr_to_scan, cache_cnt), | 2375 | TP_ARGS(sb, nr_to_scan, cache_cnt), |
@@ -2391,26 +2391,38 @@ TRACE_EVENT(ext4_es_shrink_enter, | |||
2391 | __entry->nr_to_scan, __entry->cache_cnt) | 2391 | __entry->nr_to_scan, __entry->cache_cnt) |
2392 | ); | 2392 | ); |
2393 | 2393 | ||
2394 | TRACE_EVENT(ext4_es_shrink_exit, | 2394 | DEFINE_EVENT(ext4__es_shrink_enter, ext4_es_shrink_count, |
2395 | TP_PROTO(struct super_block *sb, int shrunk_nr, int cache_cnt), | 2395 | TP_PROTO(struct super_block *sb, int nr_to_scan, int cache_cnt), |
2396 | |||
2397 | TP_ARGS(sb, nr_to_scan, cache_cnt) | ||
2398 | ); | ||
2399 | |||
2400 | DEFINE_EVENT(ext4__es_shrink_enter, ext4_es_shrink_scan_enter, | ||
2401 | TP_PROTO(struct super_block *sb, int nr_to_scan, int cache_cnt), | ||
2402 | |||
2403 | TP_ARGS(sb, nr_to_scan, cache_cnt) | ||
2404 | ); | ||
2405 | |||
2406 | TRACE_EVENT(ext4_es_shrink_scan_exit, | ||
2407 | TP_PROTO(struct super_block *sb, int nr_shrunk, int cache_cnt), | ||
2396 | 2408 | ||
2397 | TP_ARGS(sb, shrunk_nr, cache_cnt), | 2409 | TP_ARGS(sb, nr_shrunk, cache_cnt), |
2398 | 2410 | ||
2399 | TP_STRUCT__entry( | 2411 | TP_STRUCT__entry( |
2400 | __field( dev_t, dev ) | 2412 | __field( dev_t, dev ) |
2401 | __field( int, shrunk_nr ) | 2413 | __field( int, nr_shrunk ) |
2402 | __field( int, cache_cnt ) | 2414 | __field( int, cache_cnt ) |
2403 | ), | 2415 | ), |
2404 | 2416 | ||
2405 | TP_fast_assign( | 2417 | TP_fast_assign( |
2406 | __entry->dev = sb->s_dev; | 2418 | __entry->dev = sb->s_dev; |
2407 | __entry->shrunk_nr = shrunk_nr; | 2419 | __entry->nr_shrunk = nr_shrunk; |
2408 | __entry->cache_cnt = cache_cnt; | 2420 | __entry->cache_cnt = cache_cnt; |
2409 | ), | 2421 | ), |
2410 | 2422 | ||
2411 | TP_printk("dev %d,%d shrunk_nr %d cache_cnt %d", | 2423 | TP_printk("dev %d,%d nr_shrunk %d cache_cnt %d", |
2412 | MAJOR(__entry->dev), MINOR(__entry->dev), | 2424 | MAJOR(__entry->dev), MINOR(__entry->dev), |
2413 | __entry->shrunk_nr, __entry->cache_cnt) | 2425 | __entry->nr_shrunk, __entry->cache_cnt) |
2414 | ); | 2426 | ); |
2415 | 2427 | ||
2416 | TRACE_EVENT(ext4_collapse_range, | 2428 | TRACE_EVENT(ext4_collapse_range, |