aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAceLan Kao <acelan.kao@canonical.com>2013-05-29 22:31:50 -0400
committerMatthew Garrett <matthew.garrett@nebula.com>2013-07-10 15:42:47 -0400
commite8f56c80aedacfb1552509c0e4ed265266328bc4 (patch)
treefb9e6102ebe09a4109937600c327a80d02143559
parentb5f4f9ef0125845cd03dc9de5dbe1344e60474d0 (diff)
asus-wmi: control wlan-led only if wapf == 4
Controlling the wlan led seems to have some side effects to the machines with wapf value is not equal to 4. It will make the keyboard backlight out of order. So, the patch will enable the wlan led function only if the wapf == 4. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=46791 Reported-by: Mirto Silvio Busico <m.busico@ieee.org> Tested-by: Karol Herbst <karolherbst@me.com> Tested-by: drunkenbatman <drunkenbatman@gmail.com> Signed-off-by: AceLan Kao <acelan.kao@canonical.com> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
-rw-r--r--drivers/platform/x86/asus-wmi.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 0e58d748d7f6..19c313b056c3 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -558,7 +558,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
558 goto error; 558 goto error;
559 } 559 }
560 560
561 if (wlan_led_presence(asus)) { 561 if (wlan_led_presence(asus) && (asus->driver->quirks->wapf == 4)) {
562 INIT_WORK(&asus->wlan_led_work, wlan_led_update); 562 INIT_WORK(&asus->wlan_led_work, wlan_led_update);
563 563
564 asus->wlan_led.name = "asus::wlan"; 564 asus->wlan_led.name = "asus::wlan";
@@ -886,7 +886,8 @@ static int asus_new_rfkill(struct asus_wmi *asus,
886 if (!*rfkill) 886 if (!*rfkill)
887 return -EINVAL; 887 return -EINVAL;
888 888
889 if (dev_id == ASUS_WMI_DEVID_WLAN) 889 if ((dev_id == ASUS_WMI_DEVID_WLAN) &&
890 (asus->driver->quirks->wapf == 4))
890 rfkill_set_led_trigger_name(*rfkill, "asus-wlan"); 891 rfkill_set_led_trigger_name(*rfkill, "asus-wlan");
891 892
892 rfkill_init_sw_state(*rfkill, !result); 893 rfkill_init_sw_state(*rfkill, !result);