diff options
author | Ben Hutchings <ben@decadent.org.uk> | 2014-02-22 19:03:24 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-02-24 19:04:08 -0500 |
commit | e8b39015b591f359d464d026170dcf76f7ed5b8e (patch) | |
tree | 936c476451d06a592165c0b6509148452f93220e | |
parent | 7debf7806e0e984ea7e43cc271dc9400b0dffc14 (diff) |
cgxb4: Stop using ethtool SPEED_* constants
ethtool speed values are just numbers of megabits and there is no need
to add SPEED_40000. To be consistent, use integer constants directly
for all speeds.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 20 | ||||
-rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 8 |
2 files changed, 14 insertions, 14 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 4660f55e292b..da4edc1c77b3 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | |||
@@ -427,16 +427,16 @@ static void link_report(struct net_device *dev) | |||
427 | const struct port_info *p = netdev_priv(dev); | 427 | const struct port_info *p = netdev_priv(dev); |
428 | 428 | ||
429 | switch (p->link_cfg.speed) { | 429 | switch (p->link_cfg.speed) { |
430 | case SPEED_10000: | 430 | case 10000: |
431 | s = "10Gbps"; | 431 | s = "10Gbps"; |
432 | break; | 432 | break; |
433 | case SPEED_1000: | 433 | case 1000: |
434 | s = "1000Mbps"; | 434 | s = "1000Mbps"; |
435 | break; | 435 | break; |
436 | case SPEED_100: | 436 | case 100: |
437 | s = "100Mbps"; | 437 | s = "100Mbps"; |
438 | break; | 438 | break; |
439 | case 40000: /* Need a SPEED_40000 in ethtool.h */ | 439 | case 40000: |
440 | s = "40Gbps"; | 440 | s = "40Gbps"; |
441 | break; | 441 | break; |
442 | } | 442 | } |
@@ -2274,13 +2274,13 @@ static int get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | |||
2274 | 2274 | ||
2275 | static unsigned int speed_to_caps(int speed) | 2275 | static unsigned int speed_to_caps(int speed) |
2276 | { | 2276 | { |
2277 | if (speed == SPEED_100) | 2277 | if (speed == 100) |
2278 | return FW_PORT_CAP_SPEED_100M; | 2278 | return FW_PORT_CAP_SPEED_100M; |
2279 | if (speed == SPEED_1000) | 2279 | if (speed == 1000) |
2280 | return FW_PORT_CAP_SPEED_1G; | 2280 | return FW_PORT_CAP_SPEED_1G; |
2281 | if (speed == SPEED_10000) | 2281 | if (speed == 10000) |
2282 | return FW_PORT_CAP_SPEED_10G; | 2282 | return FW_PORT_CAP_SPEED_10G; |
2283 | if (speed == 40000) /* Need SPEED_40000 in ethtool.h */ | 2283 | if (speed == 40000) |
2284 | return FW_PORT_CAP_SPEED_40G; | 2284 | return FW_PORT_CAP_SPEED_40G; |
2285 | return 0; | 2285 | return 0; |
2286 | } | 2286 | } |
@@ -2310,8 +2310,8 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd) | |||
2310 | cap = speed_to_caps(speed); | 2310 | cap = speed_to_caps(speed); |
2311 | 2311 | ||
2312 | if (!(lc->supported & cap) || | 2312 | if (!(lc->supported & cap) || |
2313 | (speed == SPEED_1000) || | 2313 | (speed == 1000) || |
2314 | (speed == SPEED_10000) || | 2314 | (speed == 10000) || |
2315 | (speed == 40000)) | 2315 | (speed == 40000)) |
2316 | return -EINVAL; | 2316 | return -EINVAL; |
2317 | lc->requested_speed = cap; | 2317 | lc->requested_speed = cap; |
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 7ae756defc95..d3c2a516fa88 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | |||
@@ -3567,13 +3567,13 @@ int t4_handle_fw_rpl(struct adapter *adap, const __be64 *rpl) | |||
3567 | if (stat & FW_PORT_CMD_TXPAUSE) | 3567 | if (stat & FW_PORT_CMD_TXPAUSE) |
3568 | fc |= PAUSE_TX; | 3568 | fc |= PAUSE_TX; |
3569 | if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_100M)) | 3569 | if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_100M)) |
3570 | speed = SPEED_100; | 3570 | speed = 100; |
3571 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_1G)) | 3571 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_1G)) |
3572 | speed = SPEED_1000; | 3572 | speed = 1000; |
3573 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_10G)) | 3573 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_10G)) |
3574 | speed = SPEED_10000; | 3574 | speed = 10000; |
3575 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_40G)) | 3575 | else if (stat & FW_PORT_CMD_LSPEED(FW_PORT_CAP_SPEED_40G)) |
3576 | speed = 40000; /* Need SPEED_40000 in ethtool.h */ | 3576 | speed = 40000; |
3577 | 3577 | ||
3578 | if (link_ok != lc->link_ok || speed != lc->speed || | 3578 | if (link_ok != lc->link_ok || speed != lc->speed || |
3579 | fc != lc->fc) { /* something changed */ | 3579 | fc != lc->fc) { /* something changed */ |