diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2014-09-27 05:03:33 -0400 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2014-09-27 05:03:33 -0400 |
| commit | e77d99d4a4ec761ad061f1ec890c71040a92efe3 (patch) | |
| tree | aea6fe2ee5bb6e699045a3629b48208f3e2a26b6 | |
| parent | bb0ca6acd466af55c95b7ce508f29e23a24cabd9 (diff) | |
| parent | 0496daa5cf99741ce8db82686b4c7446a37feabb (diff) | |
Merge tag 'kvm-arm-for-3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into kvm-next
Changes for KVM for arm/arm64 for 3.18
This includes a bunch of changes:
- Support read-only memory slots on arm/arm64
- Various changes to fix Sparse warnings
- Correctly detect write vs. read Stage-2 faults
- Various VGIC cleanups and fixes
- Dynamic VGIC data strcuture sizing
- Fix SGI set_clear_pend offset bug
- Fix VTTBR_BADDR Mask
- Correctly report the FSC on Stage-2 faults
Conflicts:
virt/kvm/eventfd.c
[duplicate, different patch where the kvm-arm version broke x86.
The kvm tree instead has the right one]
| -rw-r--r-- | Documentation/virtual/kvm/devices/arm-vgic.txt | 10 | ||||
| -rw-r--r-- | arch/arm/include/asm/kvm_emulate.h | 5 | ||||
| -rw-r--r-- | arch/arm/include/asm/kvm_host.h | 2 | ||||
| -rw-r--r-- | arch/arm/include/asm/kvm_mmu.h | 11 | ||||
| -rw-r--r-- | arch/arm/include/uapi/asm/kvm.h | 2 | ||||
| -rw-r--r-- | arch/arm/kvm/arm.c | 17 | ||||
| -rw-r--r-- | arch/arm/kvm/coproc.c | 2 | ||||
| -rw-r--r-- | arch/arm/kvm/guest.c | 2 | ||||
| -rw-r--r-- | arch/arm/kvm/mmu.c | 40 | ||||
| -rw-r--r-- | arch/arm64/include/asm/kvm_arm.h | 13 | ||||
| -rw-r--r-- | arch/arm64/include/asm/kvm_emulate.h | 5 | ||||
| -rw-r--r-- | arch/arm64/include/asm/kvm_host.h | 4 | ||||
| -rw-r--r-- | arch/arm64/include/asm/kvm_mmu.h | 18 | ||||
| -rw-r--r-- | arch/arm64/include/uapi/asm/kvm.h | 2 | ||||
| -rw-r--r-- | arch/arm64/kvm/guest.c | 2 | ||||
| -rw-r--r-- | arch/arm64/kvm/sys_regs.c | 2 | ||||
| -rw-r--r-- | include/kvm/arm_vgic.h | 112 | ||||
| -rw-r--r-- | include/linux/kvm_host.h | 2 | ||||
| -rw-r--r-- | virt/kvm/arm/vgic.c | 631 | ||||
| -rw-r--r-- | virt/kvm/kvm_main.c | 11 |
20 files changed, 678 insertions, 215 deletions
diff --git a/Documentation/virtual/kvm/devices/arm-vgic.txt b/Documentation/virtual/kvm/devices/arm-vgic.txt index 7f4e91b1316b..df8b0c7540b6 100644 --- a/Documentation/virtual/kvm/devices/arm-vgic.txt +++ b/Documentation/virtual/kvm/devices/arm-vgic.txt | |||
| @@ -71,3 +71,13 @@ Groups: | |||
| 71 | Errors: | 71 | Errors: |
| 72 | -ENODEV: Getting or setting this register is not yet supported | 72 | -ENODEV: Getting or setting this register is not yet supported |
| 73 | -EBUSY: One or more VCPUs are running | 73 | -EBUSY: One or more VCPUs are running |
| 74 | |||
| 75 | KVM_DEV_ARM_VGIC_GRP_NR_IRQS | ||
| 76 | Attributes: | ||
| 77 | A value describing the number of interrupts (SGI, PPI and SPI) for | ||
| 78 | this GIC instance, ranging from 64 to 1024, in increments of 32. | ||
| 79 | |||
| 80 | Errors: | ||
| 81 | -EINVAL: Value set is out of the expected range | ||
| 82 | -EBUSY: Value has already be set, or GIC has already been initialized | ||
| 83 | with default values. | ||
diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h index 69b746955fca..b9db269c6e61 100644 --- a/arch/arm/include/asm/kvm_emulate.h +++ b/arch/arm/include/asm/kvm_emulate.h | |||
| @@ -149,6 +149,11 @@ static inline bool kvm_vcpu_trap_is_iabt(struct kvm_vcpu *vcpu) | |||
| 149 | 149 | ||
| 150 | static inline u8 kvm_vcpu_trap_get_fault(struct kvm_vcpu *vcpu) | 150 | static inline u8 kvm_vcpu_trap_get_fault(struct kvm_vcpu *vcpu) |
| 151 | { | 151 | { |
| 152 | return kvm_vcpu_get_hsr(vcpu) & HSR_FSC; | ||
| 153 | } | ||
| 154 | |||
| 155 | static inline u8 kvm_vcpu_trap_get_fault_type(struct kvm_vcpu *vcpu) | ||
| 156 | { | ||
| 152 | return kvm_vcpu_get_hsr(vcpu) & HSR_FSC_TYPE; | 157 | return kvm_vcpu_get_hsr(vcpu) & HSR_FSC_TYPE; |
| 153 | } | 158 | } |
| 154 | 159 | ||
diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h index 155497c2b4da..53036e21756b 100644 --- a/arch/arm/include/asm/kvm_host.h +++ b/arch/arm/include/asm/kvm_host.h | |||
| @@ -43,7 +43,7 @@ | |||
| 43 | #include <kvm/arm_vgic.h> | 43 | #include <kvm/arm_vgic.h> |
| 44 | 44 | ||
| 45 | u32 *kvm_vcpu_reg(struct kvm_vcpu *vcpu, u8 reg_num, u32 mode); | 45 | u32 *kvm_vcpu_reg(struct kvm_vcpu *vcpu, u8 reg_num, u32 mode); |
| 46 | int kvm_target_cpu(void); | 46 | int __attribute_const__ kvm_target_cpu(void); |
| 47 | int kvm_reset_vcpu(struct kvm_vcpu *vcpu); | 47 | int kvm_reset_vcpu(struct kvm_vcpu *vcpu); |
| 48 | void kvm_reset_coprocs(struct kvm_vcpu *vcpu); | 48 | void kvm_reset_coprocs(struct kvm_vcpu *vcpu); |
| 49 | 49 | ||
diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/include/asm/kvm_mmu.h index 5cc0b0f5f72f..3f688b458143 100644 --- a/arch/arm/include/asm/kvm_mmu.h +++ b/arch/arm/include/asm/kvm_mmu.h | |||
| @@ -78,17 +78,6 @@ static inline void kvm_set_pte(pte_t *pte, pte_t new_pte) | |||
| 78 | flush_pmd_entry(pte); | 78 | flush_pmd_entry(pte); |
| 79 | } | 79 | } |
| 80 | 80 | ||
| 81 | static inline bool kvm_is_write_fault(unsigned long hsr) | ||
| 82 | { | ||
| 83 | unsigned long hsr_ec = hsr >> HSR_EC_SHIFT; | ||
| 84 | if (hsr_ec == HSR_EC_IABT) | ||
| 85 | return false; | ||
| 86 | else if ((hsr & HSR_ISV) && !(hsr & HSR_WNR)) | ||
| 87 | return false; | ||
| 88 | else | ||
| 89 | return true; | ||
| 90 | } | ||
| 91 | |||
| 92 | static inline void kvm_clean_pgd(pgd_t *pgd) | 81 | static inline void kvm_clean_pgd(pgd_t *pgd) |
| 93 | { | 82 | { |
| 94 | clean_dcache_area(pgd, PTRS_PER_S2_PGD * sizeof(pgd_t)); | 83 | clean_dcache_area(pgd, PTRS_PER_S2_PGD * sizeof(pgd_t)); |
diff --git a/arch/arm/include/uapi/asm/kvm.h b/arch/arm/include/uapi/asm/kvm.h index e6ebdd3471e5..09ee408c1a67 100644 --- a/arch/arm/include/uapi/asm/kvm.h +++ b/arch/arm/include/uapi/asm/kvm.h | |||
| @@ -25,6 +25,7 @@ | |||
| 25 | 25 | ||
| 26 | #define __KVM_HAVE_GUEST_DEBUG | 26 | #define __KVM_HAVE_GUEST_DEBUG |
| 27 | #define __KVM_HAVE_IRQ_LINE | 27 | #define __KVM_HAVE_IRQ_LINE |
| 28 | #define __KVM_HAVE_READONLY_MEM | ||
| 28 | 29 | ||
| 29 | #define KVM_REG_SIZE(id) \ | 30 | #define KVM_REG_SIZE(id) \ |
| 30 | (1U << (((id) & KVM_REG_SIZE_MASK) >> KVM_REG_SIZE_SHIFT)) | 31 | (1U << (((id) & KVM_REG_SIZE_MASK) >> KVM_REG_SIZE_SHIFT)) |
| @@ -173,6 +174,7 @@ struct kvm_arch_memory_slot { | |||
| 173 | #define KVM_DEV_ARM_VGIC_CPUID_MASK (0xffULL << KVM_DEV_ARM_VGIC_CPUID_SHIFT) | 174 | #define KVM_DEV_ARM_VGIC_CPUID_MASK (0xffULL << KVM_DEV_ARM_VGIC_CPUID_SHIFT) |
| 174 | #define KVM_DEV_ARM_VGIC_OFFSET_SHIFT 0 | 175 | #define KVM_DEV_ARM_VGIC_OFFSET_SHIFT 0 |
| 175 | #define KVM_DEV_ARM_VGIC_OFFSET_MASK (0xffffffffULL << KVM_DEV_ARM_VGIC_OFFSET_SHIFT) | 176 | #define KVM_DEV_ARM_VGIC_OFFSET_MASK (0xffffffffULL << KVM_DEV_ARM_VGIC_OFFSET_SHIFT) |
| 177 | #define KVM_DEV_ARM_VGIC_GRP_NR_IRQS 3 | ||
| 176 | 178 | ||
| 177 | /* KVM_IRQ_LINE irq field index values */ | 179 | /* KVM_IRQ_LINE irq field index values */ |
| 178 | #define KVM_ARM_IRQ_TYPE_SHIFT 24 | 180 | #define KVM_ARM_IRQ_TYPE_SHIFT 24 |
diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c index 005a7b5fd0aa..779605122f32 100644 --- a/arch/arm/kvm/arm.c +++ b/arch/arm/kvm/arm.c | |||
| @@ -82,7 +82,7 @@ struct kvm_vcpu *kvm_arm_get_running_vcpu(void) | |||
| 82 | /** | 82 | /** |
| 83 | * kvm_arm_get_running_vcpus - get the per-CPU array of currently running vcpus. | 83 | * kvm_arm_get_running_vcpus - get the per-CPU array of currently running vcpus. |
| 84 | */ | 84 | */ |
| 85 | struct kvm_vcpu __percpu **kvm_get_running_vcpus(void) | 85 | struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void) |
| 86 | { | 86 | { |
| 87 | return &kvm_arm_running_vcpu; | 87 | return &kvm_arm_running_vcpu; |
| 88 | } | 88 | } |
| @@ -161,6 +161,8 @@ void kvm_arch_destroy_vm(struct kvm *kvm) | |||
| 161 | kvm->vcpus[i] = NULL; | 161 | kvm->vcpus[i] = NULL; |
| 162 | } | 162 | } |
| 163 | } | 163 | } |
| 164 | |||
| 165 | kvm_vgic_destroy(kvm); | ||
| 164 | } | 166 | } |
| 165 | 167 | ||
| 166 | int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) | 168 | int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) |
| @@ -177,6 +179,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) | |||
| 177 | case KVM_CAP_ONE_REG: | 179 | case KVM_CAP_ONE_REG: |
| 178 | case KVM_CAP_ARM_PSCI: | 180 | case KVM_CAP_ARM_PSCI: |
| 179 | case KVM_CAP_ARM_PSCI_0_2: | 181 | case KVM_CAP_ARM_PSCI_0_2: |
| 182 | case KVM_CAP_READONLY_MEM: | ||
| 180 | r = 1; | 183 | r = 1; |
| 181 | break; | 184 | break; |
| 182 | case KVM_CAP_COALESCED_MMIO: | 185 | case KVM_CAP_COALESCED_MMIO: |
| @@ -242,6 +245,7 @@ void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu) | |||
| 242 | { | 245 | { |
| 243 | kvm_mmu_free_memory_caches(vcpu); | 246 | kvm_mmu_free_memory_caches(vcpu); |
| 244 | kvm_timer_vcpu_terminate(vcpu); | 247 | kvm_timer_vcpu_terminate(vcpu); |
| 248 | kvm_vgic_vcpu_destroy(vcpu); | ||
| 245 | kmem_cache_free(kvm_vcpu_cache, vcpu); | 249 | kmem_cache_free(kvm_vcpu_cache, vcpu); |
| 246 | } | 250 | } |
| 247 | 251 | ||
| @@ -257,16 +261,9 @@ int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) | |||
| 257 | 261 | ||
| 258 | int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu) | 262 | int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu) |
| 259 | { | 263 | { |
| 260 | int ret; | ||
| 261 | |||
| 262 | /* Force users to call KVM_ARM_VCPU_INIT */ | 264 | /* Force users to call KVM_ARM_VCPU_INIT */ |
| 263 | vcpu->arch.target = -1; | 265 | vcpu->arch.target = -1; |
| 264 | 266 | ||
| 265 | /* Set up VGIC */ | ||
| 266 | ret = kvm_vgic_vcpu_init(vcpu); | ||
| 267 | if (ret) | ||
| 268 | return ret; | ||
| 269 | |||
| 270 | /* Set up the timer */ | 267 | /* Set up the timer */ |
| 271 | kvm_timer_vcpu_init(vcpu); | 268 | kvm_timer_vcpu_init(vcpu); |
| 272 | 269 | ||
| @@ -413,9 +410,9 @@ static void update_vttbr(struct kvm *kvm) | |||
| 413 | 410 | ||
| 414 | /* update vttbr to be used with the new vmid */ | 411 | /* update vttbr to be used with the new vmid */ |
| 415 | pgd_phys = virt_to_phys(kvm->arch.pgd); | ||
