aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2013-01-21 03:30:02 -0500
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-01-22 20:32:02 -0500
commite6dd8cf223d1a41b3c3168e97e2c33df0ef05e9d (patch)
tree86b5bc6a85d91b04fc23960fd4deba02ecf4d3fd
parent4e6168779508f62c27e43a4f7ded786bfdb0a394 (diff)
extcon: arizona: Retry failed HP measurements
We now have mechanisms in place to allow retries so let's use them rather than guessing. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--drivers/extcon/extcon-arizona.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index ce95f8625e8d..528303440c2e 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -31,8 +31,6 @@
31#include <linux/mfd/arizona/pdata.h> 31#include <linux/mfd/arizona/pdata.h>
32#include <linux/mfd/arizona/registers.h> 32#include <linux/mfd/arizona/registers.h>
33 33
34#define ARIZONA_DEFAULT_HP 32
35
36#define ARIZONA_NUM_BUTTONS 6 34#define ARIZONA_NUM_BUTTONS 6
37 35
38#define ARIZONA_ACCDET_MODE_MIC 0 36#define ARIZONA_ACCDET_MODE_MIC 0
@@ -208,7 +206,7 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
208 if (!(val & ARIZONA_HP_DONE)) { 206 if (!(val & ARIZONA_HP_DONE)) {
209 dev_err(arizona->dev, "HPDET did not complete: %x\n", 207 dev_err(arizona->dev, "HPDET did not complete: %x\n",
210 val); 208 val);
211 val = ARIZONA_DEFAULT_HP; 209 return -EAGAIN;
212 } 210 }
213 211
214 val &= ARIZONA_HP_LVL_MASK; 212 val &= ARIZONA_HP_LVL_MASK;
@@ -218,14 +216,14 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
218 if (!(val & ARIZONA_HP_DONE_B)) { 216 if (!(val & ARIZONA_HP_DONE_B)) {
219 dev_err(arizona->dev, "HPDET did not complete: %x\n", 217 dev_err(arizona->dev, "HPDET did not complete: %x\n",
220 val); 218 val);
221 return ARIZONA_DEFAULT_HP; 219 return -EAGAIN;
222 } 220 }
223 221
224 ret = regmap_read(arizona->regmap, ARIZONA_HP_DACVAL, &val); 222 ret = regmap_read(arizona->regmap, ARIZONA_HP_DACVAL, &val);
225 if (ret != 0) { 223 if (ret != 0) {
226 dev_err(arizona->dev, "Failed to read HP value: %d\n", 224 dev_err(arizona->dev, "Failed to read HP value: %d\n",
227 ret); 225 ret);
228 return ARIZONA_DEFAULT_HP; 226 return -EAGAIN;
229 } 227 }
230 228
231 regmap_read(arizona->regmap, ARIZONA_HEADPHONE_DETECT_1, 229 regmap_read(arizona->regmap, ARIZONA_HEADPHONE_DETECT_1,
@@ -267,7 +265,7 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
267 if (!(val & ARIZONA_HP_DONE_B)) { 265 if (!(val & ARIZONA_HP_DONE_B)) {
268 dev_err(arizona->dev, "HPDET did not complete: %x\n", 266 dev_err(arizona->dev, "HPDET did not complete: %x\n",
269 val); 267 val);
270 return ARIZONA_DEFAULT_HP; 268 return -EAGAIN;
271 } 269 }
272 270
273 val &= ARIZONA_HP_LVL_B_MASK; 271 val &= ARIZONA_HP_LVL_B_MASK;