aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2013-03-22 03:14:25 -0400
committerFelipe Balbi <balbi@ti.com>2013-03-22 03:15:10 -0400
commite6667ef7ac27d61dd36b1215da1e9ac719dcb769 (patch)
treefa0cc914b275956261c2b285371078ee3e76be26
parentaf593da481aec9ce1fba8aef3ee1a2b868744968 (diff)
usb: gadget: mv_u3d: fix sparse warnings
Fix the following sparse warnings: drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_ep_queue’: drivers/usb/gadget/mv_u3d_core.c:812:2: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:822:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:823:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:823:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_ep_dequeue’: drivers/usb/gadget/mv_u3d_core.c:905:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_probe’: drivers/usb/gadget/mv_u3d_core.c:1840:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:1855:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:1855:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] drivers/usb/gadget/mv_u3d_core.c:1858:53: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:1858:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_irq_process_tr_complete’: drivers/usb/gadget/mv_u3d_core.c:163:21: warning: ‘remaining_length’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/usb/gadget/mv_u3d_core.c:125:28: note: ‘remaining_length’ was declared here Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/gadget/mv_u3d_core.c27
1 files changed, 14 insertions, 13 deletions
diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c
index 29153bf67cb4..5a6f87cf718a 100644
--- a/drivers/usb/gadget/mv_u3d_core.c
+++ b/drivers/usb/gadget/mv_u3d_core.c
@@ -122,7 +122,7 @@ static int mv_u3d_process_ep_req(struct mv_u3d *u3d, int index,
122 struct mv_u3d_trb *curr_trb; 122 struct mv_u3d_trb *curr_trb;
123 dma_addr_t cur_deq_lo; 123 dma_addr_t cur_deq_lo;
124 struct mv_u3d_ep_context *curr_ep_context; 124 struct mv_u3d_ep_context *curr_ep_context;
125 int trb_complete, actual, remaining_length; 125 int trb_complete, actual, remaining_length = 0;
126 int direction, ep_num; 126 int direction, ep_num;
127 int retval = 0; 127 int retval = 0;
128 u32 tmp, status, length; 128 u32 tmp, status, length;
@@ -809,19 +809,19 @@ mv_u3d_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
809 return 0; 809 return 0;
810 } 810 }
811 811
812 dev_dbg(u3d->dev, "%s: %s, req: 0x%x\n", 812 dev_dbg(u3d->dev, "%s: %s, req: 0x%p\n",
813 __func__, _ep->name, (u32)req); 813 __func__, _ep->name, req);
814 814
815 /* catch various bogus parameters */ 815 /* catch various bogus parameters */
816 if (!req->req.complete || !req->req.buf 816 if (!req->req.complete || !req->req.buf
817 || !list_empty(&req->queue)) { 817 || !list_empty(&req->queue)) {
818 dev_err(u3d->dev, 818 dev_err(u3d->dev,
819 "%s, bad params, _req: 0x%x," 819 "%s, bad params, _req: 0x%p,"
820 "req->req.complete: 0x%x, req->req.buf: 0x%x," 820 "req->req.complete: 0x%p, req->req.buf: 0x%p,"
821 "list_empty: 0x%x\n", 821 "list_empty: 0x%x\n",
822 __func__, (u32)_req, 822 __func__, _req,
823 (u32)req->req.complete, (u32)req->req.buf, 823 req->req.complete, req->req.buf,
824 (u32)list_empty(&req->queue)); 824 list_empty(&req->queue));
825 return -EINVAL; 825 return -EINVAL;
826 } 826 }
827 if (unlikely(!ep->ep.desc)) { 827 if (unlikely(!ep->ep.desc)) {
@@ -902,7 +902,7 @@ static int mv_u3d_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
902 struct mv_u3d_req, queue); 902 struct mv_u3d_req, queue);
903 903
904 /* Point first TRB of next request to the EP context. */ 904 /* Point first TRB of next request to the EP context. */
905 iowrite32((u32) next_req->trb_head, 905 iowrite32((unsigned long) next_req->trb_head,
906 &ep_context->trb_addr_lo); 906 &ep_context->trb_addr_lo);
907 } else { 907 } else {
908 struct mv_u3d_ep_context *ep_context; 908 struct mv_u3d_ep_context *ep_context;
@@ -1837,8 +1837,9 @@ static int mv_u3d_probe(struct platform_device *dev)
1837 retval = -EBUSY; 1837 retval = -EBUSY;
1838 goto err_map_cap_regs; 1838 goto err_map_cap_regs;
1839 } else { 1839 } else {
1840 dev_dbg(&dev->dev, "cap_regs address: 0x%x/0x%x\n", 1840 dev_dbg(&dev->dev, "cap_regs address: 0x%lx/0x%lx\n",
1841 (unsigned int)r->start, (unsigned int)u3d->cap_regs); 1841 (unsigned long) r->start,
1842 (unsigned long) u3d->cap_regs);
1842 } 1843 }
1843 1844
1844 /* we will access controller register, so enable the u3d controller */ 1845 /* we will access controller register, so enable the u3d controller */
@@ -1852,10 +1853,10 @@ static int mv_u3d_probe(struct platform_device *dev)
1852 } 1853 }
1853 } 1854 }
1854 1855
1855 u3d->op_regs = (struct mv_u3d_op_regs __iomem *)((u32)u3d->cap_regs 1856 u3d->op_regs = (struct mv_u3d_op_regs __iomem *)(u3d->cap_regs
1856 + MV_U3D_USB3_OP_REGS_OFFSET); 1857 + MV_U3D_USB3_OP_REGS_OFFSET);
1857 1858
1858 u3d->vuc_regs = (struct mv_u3d_vuc_regs __iomem *)((u32)u3d->cap_regs 1859 u3d->vuc_regs = (struct mv_u3d_vuc_regs __iomem *)(u3d->cap_regs
1859 + ioread32(&u3d->cap_regs->vuoff)); 1860 + ioread32(&u3d->cap_regs->vuoff));
1860 1861
1861 u3d->max_eps = 16; 1862 u3d->max_eps = 16;