diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-04-29 19:19:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-04-29 21:28:27 -0400 |
commit | e38fc305f4da457b35ac4df5723c8f57ad0c9a52 (patch) | |
tree | 542c91f490bd828ad1928453c1bb0c87fa9cb8e9 | |
parent | faa43af9bc96a78b1fcd8067c7d9e3ebd044087e (diff) |
rtc: rtc-tx4939: use devm_rtc_device_register()
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/rtc/rtc-tx4939.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index 4f2c0821b020..f9a0677e4e3b 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c | |||
@@ -268,14 +268,13 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev) | |||
268 | if (devm_request_irq(&pdev->dev, irq, tx4939_rtc_interrupt, | 268 | if (devm_request_irq(&pdev->dev, irq, tx4939_rtc_interrupt, |
269 | 0, pdev->name, &pdev->dev) < 0) | 269 | 0, pdev->name, &pdev->dev) < 0) |
270 | return -EBUSY; | 270 | return -EBUSY; |
271 | rtc = rtc_device_register(pdev->name, &pdev->dev, | 271 | rtc = devm_rtc_device_register(&pdev->dev, pdev->name, |
272 | &tx4939_rtc_ops, THIS_MODULE); | 272 | &tx4939_rtc_ops, THIS_MODULE); |
273 | if (IS_ERR(rtc)) | 273 | if (IS_ERR(rtc)) |
274 | return PTR_ERR(rtc); | 274 | return PTR_ERR(rtc); |
275 | pdata->rtc = rtc; | 275 | pdata->rtc = rtc; |
276 | ret = sysfs_create_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr); | 276 | ret = sysfs_create_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr); |
277 | if (ret) | 277 | |
278 | rtc_device_unregister(rtc); | ||
279 | return ret; | 278 | return ret; |
280 | } | 279 | } |
281 | 280 | ||
@@ -284,7 +283,6 @@ static int __exit tx4939_rtc_remove(struct platform_device *pdev) | |||
284 | struct tx4939rtc_plat_data *pdata = platform_get_drvdata(pdev); | 283 | struct tx4939rtc_plat_data *pdata = platform_get_drvdata(pdev); |
285 | 284 | ||
286 | sysfs_remove_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr); | 285 | sysfs_remove_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr); |
287 | rtc_device_unregister(pdata->rtc); | ||
288 | spin_lock_irq(&pdata->lock); | 286 | spin_lock_irq(&pdata->lock); |
289 | tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP); | 287 | tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP); |
290 | spin_unlock_irq(&pdata->lock); | 288 | spin_unlock_irq(&pdata->lock); |