aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-11-23 05:46:58 -0500
committerHaavard Skinnemoen <haavard.skinnemoen@atmel.com>2009-01-06 06:39:25 -0500
commite24500193bc39ef197d9f96af5850e7345fed84d (patch)
tree195ac419cc572f90a671bfe5894d4e5eb0947beb
parentadde42b5834ed367ef7455d465bd9610190ad2a0 (diff)
arch/avr32: Eliminate NULL test and memset after alloc_bootmem
As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b, alloc_bootmem and related functions never return NULL and always return a zeroed region of memory. Thus a NULL test or memset after calls to these functions is unnecessary. This was fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E; statement S; @@ E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\|alloc_bootmem_node\|alloc_bootmem_low_pages_node\|alloc_bootmem_pages_node\)(...) ... when != E ( - BUG_ON (E == NULL); | - if (E == NULL) S ) @@ expression E,E1; @@ E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\|alloc_bootmem_node\|alloc_bootmem_low_pages_node\|alloc_bootmem_pages_node\)(...) ... when != E - memset(E,0,E1); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
-rw-r--r--arch/avr32/mm/init.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/avr32/mm/init.c b/arch/avr32/mm/init.c
index fa92ff6d95f7..e819fa69a90e 100644
--- a/arch/avr32/mm/init.c
+++ b/arch/avr32/mm/init.c
@@ -97,7 +97,6 @@ void __init paging_init(void)
97 97
98 mem_map = NODE_DATA(0)->node_mem_map; 98 mem_map = NODE_DATA(0)->node_mem_map;
99 99
100 memset(zero_page, 0, PAGE_SIZE);
101 empty_zero_page = virt_to_page(zero_page); 100 empty_zero_page = virt_to_page(zero_page);
102 flush_dcache_page(empty_zero_page); 101 flush_dcache_page(empty_zero_page);
103} 102}